From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E628C433F5 for ; Wed, 15 Sep 2021 08:50:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CC12560527 for ; Wed, 15 Sep 2021 08:50:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CC12560527 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:52428 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQQd6-00062u-SO for qemu-devel@archiver.kernel.org; Wed, 15 Sep 2021 04:50:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45818) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQQc6-00050Z-EC for qemu-devel@nongnu.org; Wed, 15 Sep 2021 04:49:54 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:48848) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQQc3-0000qN-ED for qemu-devel@nongnu.org; Wed, 15 Sep 2021 04:49:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631695789; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UbsWX5ThNzbLSLppNv0zipcECBhQ1lONYygbF5FVZZg=; b=X1uY1cyeQ/prqnx0R7/2SKtnT/hVj6H5JPSBf9Qk9Oo28NHwV01I1jtW+yKNKS45yGS5Jo BiAF24QFoLvSYDUKKJ7JK+ffsNsUH7zyQZSGc+HMFX3MGO+6UgIX0jNLUP4oDN8S/2ob/D UVXzH3ZdYZy8Kc+NXLCxTDj11/LVaHI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-235-fke9A7PLMHqixdvWp5O0SA-1; Wed, 15 Sep 2021 04:49:48 -0400 X-MC-Unique: fke9A7PLMHqixdvWp5O0SA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5F03F802928; Wed, 15 Sep 2021 08:49:44 +0000 (UTC) Received: from redhat.com (unknown [10.39.194.233]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7AFF06B54B; Wed, 15 Sep 2021 08:49:24 +0000 (UTC) Date: Wed, 15 Sep 2021 09:49:21 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH v2 09/53] target/avr: convert to use format_state instead of dump_state Message-ID: References: <20210914142042.1655100-1-berrange@redhat.com> <20210914142042.1655100-10-berrange@redhat.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.0.7 (2021-05-04) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.398, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Peter Maydell , Cornelia Huck , David Hildenbrand , Bin Meng , Mark Cave-Ayland , qemu-devel@nongnu.org, Max Filippov , Taylor Simpson , Alistair Francis , Gerd Hoffmann , Eric Blake , Marek Vasut , Yoshinori Sato , Markus Armbruster , Halil Pasic , Christian Borntraeger , qemu-ppc@nongnu.org, Artyom Tarasenko , Laurent Vivier , Thomas Huth , Eduardo Habkost , Richard Henderson , Greg Kurz , Yuval Shaia , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, Michael Rolnik , Peter Xu , Stafford Horne , David Gibson , qemu-riscv@nongnu.org, Bastian Koppelmann , Chris Wulff , Laurent Vivier , Palmer Dabbelt , Aurelien Jarno , Paolo Bonzini , Aleksandar Rikalo , "Dr. David Alan Gilbert" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Sep 15, 2021 at 09:13:14AM +0200, Philippe Mathieu-Daudé wrote: > On 9/14/21 4:19 PM, Daniel P. Berrangé wrote: > > Signed-off-by: Daniel P. Berrangé > > --- > > target/avr/cpu.c | 57 ++++++++++++++++++++++++------------------------ > > 1 file changed, 29 insertions(+), 28 deletions(-) > > > > diff --git a/target/avr/cpu.c b/target/avr/cpu.c > > index ea14175ca5..17ff21f8be 100644 > > --- a/target/avr/cpu.c > > +++ b/target/avr/cpu.c > > @@ -145,43 +145,44 @@ static ObjectClass *avr_cpu_class_by_name(const char *cpu_model) > > return oc; > > } > > > > -static void avr_cpu_dump_state(CPUState *cs, FILE *f, int flags) > > +static void avr_cpu_format_state(CPUState *cs, GString *buf, int flags) > > { > > AVRCPU *cpu = AVR_CPU(cs); > > CPUAVRState *env = &cpu->env; > > int i; > > > > - qemu_fprintf(f, "\n"); > > - qemu_fprintf(f, "PC: %06x\n", env->pc_w * 2); /* PC points to words */ > > - qemu_fprintf(f, "SP: %04x\n", env->sp); > > - qemu_fprintf(f, "rampD: %02x\n", env->rampD >> 16); > > - qemu_fprintf(f, "rampX: %02x\n", env->rampX >> 16); > > - qemu_fprintf(f, "rampY: %02x\n", env->rampY >> 16); > > - qemu_fprintf(f, "rampZ: %02x\n", env->rampZ >> 16); > > - qemu_fprintf(f, "EIND: %02x\n", env->eind >> 16); > > - qemu_fprintf(f, "X: %02x%02x\n", env->r[27], env->r[26]); > > - qemu_fprintf(f, "Y: %02x%02x\n", env->r[29], env->r[28]); > > - qemu_fprintf(f, "Z: %02x%02x\n", env->r[31], env->r[30]); > > - qemu_fprintf(f, "SREG: [ %c %c %c %c %c %c %c %c ]\n", > > - env->sregI ? 'I' : '-', > > - env->sregT ? 'T' : '-', > > - env->sregH ? 'H' : '-', > > - env->sregS ? 'S' : '-', > > - env->sregV ? 'V' : '-', > > - env->sregN ? '-' : 'N', /* Zf has negative logic */ > > - env->sregZ ? 'Z' : '-', > > - env->sregC ? 'I' : '-'); > > - qemu_fprintf(f, "SKIP: %02x\n", env->skip); > > - > > - qemu_fprintf(f, "\n"); > > + g_string_append_printf(buf, "\n"); > > This would be g_string_append_c(buf, '\n') but in this particular case > it doesn't seem helpful so I'd directly remove it. I don't want to change output format of the commands, with exception of error reporting, as this is intended to be just refactoring patch, not a cleanup patch. I'm not convinced it is worth special casing single byte strings to use g_string_append_c either really. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mQQc8-00053c-CQ for mharc-qemu-riscv@gnu.org; Wed, 15 Sep 2021 04:49:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45836) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQQc6-00050c-DQ for qemu-riscv@nongnu.org; Wed, 15 Sep 2021 04:49:54 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:48069) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQQc3-0000qM-ED for qemu-riscv@nongnu.org; Wed, 15 Sep 2021 04:49:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631695789; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UbsWX5ThNzbLSLppNv0zipcECBhQ1lONYygbF5FVZZg=; b=X1uY1cyeQ/prqnx0R7/2SKtnT/hVj6H5JPSBf9Qk9Oo28NHwV01I1jtW+yKNKS45yGS5Jo BiAF24QFoLvSYDUKKJ7JK+ffsNsUH7zyQZSGc+HMFX3MGO+6UgIX0jNLUP4oDN8S/2ob/D UVXzH3ZdYZy8Kc+NXLCxTDj11/LVaHI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-235-fke9A7PLMHqixdvWp5O0SA-1; Wed, 15 Sep 2021 04:49:48 -0400 X-MC-Unique: fke9A7PLMHqixdvWp5O0SA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5F03F802928; Wed, 15 Sep 2021 08:49:44 +0000 (UTC) Received: from redhat.com (unknown [10.39.194.233]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7AFF06B54B; Wed, 15 Sep 2021 08:49:24 +0000 (UTC) Date: Wed, 15 Sep 2021 09:49:21 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: qemu-devel@nongnu.org, Peter Maydell , Chris Wulff , David Hildenbrand , Bin Meng , Mark Cave-Ayland , Yuval Shaia , Jiaxun Yang , Laurent Vivier , Max Filippov , Taylor Simpson , Alistair Francis , Gerd Hoffmann , Eric Blake , Marek Vasut , Yoshinori Sato , Markus Armbruster , Halil Pasic , Christian Borntraeger , Marcel Apfelbaum , Palmer Dabbelt , Artyom Tarasenko , Laurent Vivier , Thomas Huth , Eduardo Habkost , Richard Henderson , Greg Kurz , "Dr. David Alan Gilbert" , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, Michael Rolnik , Peter Xu , Stafford Horne , David Gibson , qemu-riscv@nongnu.org, Bastian Koppelmann , Cornelia Huck , qemu-ppc@nongnu.org, Paolo Bonzini , Aleksandar Rikalo , Aurelien Jarno Subject: Re: [PATCH v2 09/53] target/avr: convert to use format_state instead of dump_state Message-ID: Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20210914142042.1655100-1-berrange@redhat.com> <20210914142042.1655100-10-berrange@redhat.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.0.7 (2021-05-04) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) DKIMWL_WL_HIGH=-0.398, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Sep 2021 08:49:54 -0000 On Wed, Sep 15, 2021 at 09:13:14AM +0200, Philippe Mathieu-Daudé wrote: > On 9/14/21 4:19 PM, Daniel P. Berrangé wrote: > > Signed-off-by: Daniel P. Berrangé > > --- > > target/avr/cpu.c | 57 ++++++++++++++++++++++++------------------------ > > 1 file changed, 29 insertions(+), 28 deletions(-) > > > > diff --git a/target/avr/cpu.c b/target/avr/cpu.c > > index ea14175ca5..17ff21f8be 100644 > > --- a/target/avr/cpu.c > > +++ b/target/avr/cpu.c > > @@ -145,43 +145,44 @@ static ObjectClass *avr_cpu_class_by_name(const char *cpu_model) > > return oc; > > } > > > > -static void avr_cpu_dump_state(CPUState *cs, FILE *f, int flags) > > +static void avr_cpu_format_state(CPUState *cs, GString *buf, int flags) > > { > > AVRCPU *cpu = AVR_CPU(cs); > > CPUAVRState *env = &cpu->env; > > int i; > > > > - qemu_fprintf(f, "\n"); > > - qemu_fprintf(f, "PC: %06x\n", env->pc_w * 2); /* PC points to words */ > > - qemu_fprintf(f, "SP: %04x\n", env->sp); > > - qemu_fprintf(f, "rampD: %02x\n", env->rampD >> 16); > > - qemu_fprintf(f, "rampX: %02x\n", env->rampX >> 16); > > - qemu_fprintf(f, "rampY: %02x\n", env->rampY >> 16); > > - qemu_fprintf(f, "rampZ: %02x\n", env->rampZ >> 16); > > - qemu_fprintf(f, "EIND: %02x\n", env->eind >> 16); > > - qemu_fprintf(f, "X: %02x%02x\n", env->r[27], env->r[26]); > > - qemu_fprintf(f, "Y: %02x%02x\n", env->r[29], env->r[28]); > > - qemu_fprintf(f, "Z: %02x%02x\n", env->r[31], env->r[30]); > > - qemu_fprintf(f, "SREG: [ %c %c %c %c %c %c %c %c ]\n", > > - env->sregI ? 'I' : '-', > > - env->sregT ? 'T' : '-', > > - env->sregH ? 'H' : '-', > > - env->sregS ? 'S' : '-', > > - env->sregV ? 'V' : '-', > > - env->sregN ? '-' : 'N', /* Zf has negative logic */ > > - env->sregZ ? 'Z' : '-', > > - env->sregC ? 'I' : '-'); > > - qemu_fprintf(f, "SKIP: %02x\n", env->skip); > > - > > - qemu_fprintf(f, "\n"); > > + g_string_append_printf(buf, "\n"); > > This would be g_string_append_c(buf, '\n') but in this particular case > it doesn't seem helpful so I'd directly remove it. I don't want to change output format of the commands, with exception of error reporting, as this is intended to be just refactoring patch, not a cleanup patch. I'm not convinced it is worth special casing single byte strings to use g_string_append_c either really. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|