* [PATCH] gitlab-ci: Mark manual-only jobs as allow_failure
@ 2021-09-15 12:34 Peter Maydell
2021-09-15 12:35 ` Daniel P. Berrangé
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Peter Maydell @ 2021-09-15 12:34 UTC (permalink / raw)
To: qemu-devel
Cc: Thomas Huth, Daniel P. Berrange, Philippe Mathieu-Daudé,
Wainer dos Santos Moschetta, Willian Rampazzo, Alex Bennée
If a gitlab CI job is marked as manual-only but is not marked
as allow_failure, then gitlab considers that the pipeline is
"blocked" until the job has been manually triggered. We need
to mark these manual-only jobs as also allow_failure: true
so that gitlab doesn't insist that they have run before it
will consider the pipeline to be complete.
Fixes: 4c9af1ea1457782cf0adb29
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
.gitlab-ci.d/custom-runners.yml | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/.gitlab-ci.d/custom-runners.yml b/.gitlab-ci.d/custom-runners.yml
index bcd22ca293c..a89a20da48d 100644
--- a/.gitlab-ci.d/custom-runners.yml
+++ b/.gitlab-ci.d/custom-runners.yml
@@ -60,8 +60,10 @@ ubuntu-18.04-s390x-alldbg:
rules:
- if: '$CI_PROJECT_NAMESPACE == "qemu-project" && $CI_COMMIT_BRANCH =~ /^staging/'
when: manual
+ allow_failure: true
- if: "$S390X_RUNNER_AVAILABLE"
when: manual
+ allow_failure: true
script:
- mkdir build
- cd build
@@ -79,8 +81,10 @@ ubuntu-18.04-s390x-clang:
rules:
- if: '$CI_PROJECT_NAMESPACE == "qemu-project" && $CI_COMMIT_BRANCH =~ /^staging/'
when: manual
+ allow_failure: true
- if: "$S390X_RUNNER_AVAILABLE"
when: manual
+ allow_failure: true
script:
- mkdir build
- cd build
@@ -97,8 +101,10 @@ ubuntu-18.04-s390x-tci:
rules:
- if: '$CI_PROJECT_NAMESPACE == "qemu-project" && $CI_COMMIT_BRANCH =~ /^staging/'
when: manual
+ allow_failure: true
- if: "$S390X_RUNNER_AVAILABLE"
when: manual
+ allow_failure: true
script:
- mkdir build
- cd build
@@ -114,8 +120,10 @@ ubuntu-18.04-s390x-notcg:
rules:
- if: '$CI_PROJECT_NAMESPACE == "qemu-project" && $CI_COMMIT_BRANCH =~ /^staging/'
when: manual
+ allow_failure: true
- if: "$S390X_RUNNER_AVAILABLE"
when: manual
+ allow_failure: true
script:
- mkdir build
- cd build
@@ -154,8 +162,10 @@ ubuntu-20.04-aarch64-all:
rules:
- if: '$CI_PROJECT_NAMESPACE == "qemu-project" && $CI_COMMIT_BRANCH =~ /^staging/'
when: manual
+ allow_failure: true
- if: "$AARCH64_RUNNER_AVAILABLE"
when: manual
+ allow_failure: true
script:
- mkdir build
- cd build
@@ -189,8 +199,10 @@ ubuntu-20.04-aarch64-clang:
rules:
- if: '$CI_PROJECT_NAMESPACE == "qemu-project" && $CI_COMMIT_BRANCH =~ /^staging/'
when: manual
+ allow_failure: true
- if: "$AARCH64_RUNNER_AVAILABLE"
when: manual
+ allow_failure: true
script:
- mkdir build
- cd build
@@ -207,8 +219,10 @@ ubuntu-20.04-aarch64-tci:
rules:
- if: '$CI_PROJECT_NAMESPACE == "qemu-project" && $CI_COMMIT_BRANCH =~ /^staging/'
when: manual
+ allow_failure: true
- if: "$AARCH64_RUNNER_AVAILABLE"
when: manual
+ allow_failure: true
script:
- mkdir build
- cd build
@@ -224,8 +238,10 @@ ubuntu-20.04-aarch64-notcg:
rules:
- if: '$CI_PROJECT_NAMESPACE == "qemu-project" && $CI_COMMIT_BRANCH =~ /^staging/'
when: manual
+ allow_failure: true
- if: "$AARCH64_RUNNER_AVAILABLE"
when: manual
+ allow_failure: true
script:
- mkdir build
- cd build
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] gitlab-ci: Mark manual-only jobs as allow_failure
2021-09-15 12:34 [PATCH] gitlab-ci: Mark manual-only jobs as allow_failure Peter Maydell
@ 2021-09-15 12:35 ` Daniel P. Berrangé
2021-09-15 14:01 ` Thomas Huth
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Daniel P. Berrangé @ 2021-09-15 12:35 UTC (permalink / raw)
To: Peter Maydell
Cc: Thomas Huth, qemu-devel, Wainer dos Santos Moschetta,
Philippe Mathieu-Daudé,
Willian Rampazzo, Alex Bennée
On Wed, Sep 15, 2021 at 01:34:12PM +0100, Peter Maydell wrote:
> If a gitlab CI job is marked as manual-only but is not marked
> as allow_failure, then gitlab considers that the pipeline is
> "blocked" until the job has been manually triggered. We need
> to mark these manual-only jobs as also allow_failure: true
> so that gitlab doesn't insist that they have run before it
> will consider the pipeline to be complete.
>
> Fixes: 4c9af1ea1457782cf0adb29
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> .gitlab-ci.d/custom-runners.yml | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] gitlab-ci: Mark manual-only jobs as allow_failure
2021-09-15 12:34 [PATCH] gitlab-ci: Mark manual-only jobs as allow_failure Peter Maydell
2021-09-15 12:35 ` Daniel P. Berrangé
@ 2021-09-15 14:01 ` Thomas Huth
2021-09-15 14:03 ` Willian Rampazzo
2021-09-15 15:42 ` Peter Maydell
3 siblings, 0 replies; 5+ messages in thread
From: Thomas Huth @ 2021-09-15 14:01 UTC (permalink / raw)
To: Peter Maydell, qemu-devel
Cc: Willian Rampazzo, Daniel P. Berrange, Alex Bennée,
Philippe Mathieu-Daudé,
Wainer dos Santos Moschetta
On 15/09/2021 14.34, Peter Maydell wrote:
> If a gitlab CI job is marked as manual-only but is not marked
> as allow_failure, then gitlab considers that the pipeline is
> "blocked" until the job has been manually triggered. We need
> to mark these manual-only jobs as also allow_failure: true
> so that gitlab doesn't insist that they have run before it
> will consider the pipeline to be complete.
>
> Fixes: 4c9af1ea1457782cf0adb29
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> .gitlab-ci.d/custom-runners.yml | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/.gitlab-ci.d/custom-runners.yml b/.gitlab-ci.d/custom-runners.yml
> index bcd22ca293c..a89a20da48d 100644
> --- a/.gitlab-ci.d/custom-runners.yml
> +++ b/.gitlab-ci.d/custom-runners.yml
> @@ -60,8 +60,10 @@ ubuntu-18.04-s390x-alldbg:
> rules:
> - if: '$CI_PROJECT_NAMESPACE == "qemu-project" && $CI_COMMIT_BRANCH =~ /^staging/'
> when: manual
> + allow_failure: true
> - if: "$S390X_RUNNER_AVAILABLE"
> when: manual
> + allow_failure: true
> script:
> - mkdir build
> - cd build
Do we need the "allow_failure: true" on both parts, for the staging branch
and for the manual rule? Or would it be enough for the manual rule? Anyway:
Acked-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] gitlab-ci: Mark manual-only jobs as allow_failure
2021-09-15 12:34 [PATCH] gitlab-ci: Mark manual-only jobs as allow_failure Peter Maydell
2021-09-15 12:35 ` Daniel P. Berrangé
2021-09-15 14:01 ` Thomas Huth
@ 2021-09-15 14:03 ` Willian Rampazzo
2021-09-15 15:42 ` Peter Maydell
3 siblings, 0 replies; 5+ messages in thread
From: Willian Rampazzo @ 2021-09-15 14:03 UTC (permalink / raw)
To: Peter Maydell
Cc: Thomas Huth, Daniel P. Berrange, qemu-devel,
Wainer dos Santos Moschetta, Philippe Mathieu-Daudé,
Alex Bennée
On Wed, Sep 15, 2021 at 9:34 AM Peter Maydell <peter.maydell@linaro.org> wrote:
>
> If a gitlab CI job is marked as manual-only but is not marked
> as allow_failure, then gitlab considers that the pipeline is
> "blocked" until the job has been manually triggered. We need
> to mark these manual-only jobs as also allow_failure: true
> so that gitlab doesn't insist that they have run before it
> will consider the pipeline to be complete.
>
> Fixes: 4c9af1ea1457782cf0adb29
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> .gitlab-ci.d/custom-runners.yml | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] gitlab-ci: Mark manual-only jobs as allow_failure
2021-09-15 12:34 [PATCH] gitlab-ci: Mark manual-only jobs as allow_failure Peter Maydell
` (2 preceding siblings ...)
2021-09-15 14:03 ` Willian Rampazzo
@ 2021-09-15 15:42 ` Peter Maydell
3 siblings, 0 replies; 5+ messages in thread
From: Peter Maydell @ 2021-09-15 15:42 UTC (permalink / raw)
To: QEMU Developers
Cc: Thomas Huth, Daniel P. Berrange, Philippe Mathieu-Daudé,
Wainer dos Santos Moschetta, Willian Rampazzo, Alex Bennée
On Wed, 15 Sept 2021 at 13:34, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> If a gitlab CI job is marked as manual-only but is not marked
> as allow_failure, then gitlab considers that the pipeline is
> "blocked" until the job has been manually triggered. We need
> to mark these manual-only jobs as also allow_failure: true
> so that gitlab doesn't insist that they have run before it
> will consider the pipeline to be complete.
>
> Fixes: 4c9af1ea1457782cf0adb29
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
Applied to master, thanks.
-- PMM
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-09-15 15:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-15 12:34 [PATCH] gitlab-ci: Mark manual-only jobs as allow_failure Peter Maydell
2021-09-15 12:35 ` Daniel P. Berrangé
2021-09-15 14:01 ` Thomas Huth
2021-09-15 14:03 ` Willian Rampazzo
2021-09-15 15:42 ` Peter Maydell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.