From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E009AC433F5 for ; Wed, 15 Sep 2021 21:00:48 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A6E8660F8F for ; Wed, 15 Sep 2021 21:00:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A6E8660F8F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 30EC26EA51; Wed, 15 Sep 2021 21:00:46 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4FFDE6EA51; Wed, 15 Sep 2021 21:00:43 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10108"; a="222086549" X-IronPort-AV: E=Sophos;i="5.85,296,1624345200"; d="scan'208";a="222086549" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2021 14:00:19 -0700 X-IronPort-AV: E=Sophos;i="5.85,296,1624345200"; d="scan'208";a="545102227" Received: from nvora-mobl.amr.corp.intel.com (HELO intel.com) ([10.255.36.151]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2021 14:00:18 -0700 Date: Wed, 15 Sep 2021 17:00:16 -0400 From: Rodrigo Vivi To: Jani Nikula Cc: Daniele Ceraolo Spurio , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Chris Wilson , Daniel Vetter , Dave Airlie Subject: Re: [Intel-gfx] [PATCH v9 04/17] drm/i915/pxp: allocate a vcs context for pxp usage Message-ID: References: <20210910153627.1060858-1-daniele.ceraolospurio@intel.com> <20210910153627.1060858-5-daniele.ceraolospurio@intel.com> <874kamx7vk.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <874kamx7vk.fsf@intel.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Sep 15, 2021 at 04:53:35PM +0300, Jani Nikula wrote: > On Fri, 10 Sep 2021, Daniele Ceraolo Spurio wrote: > > diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp.h b/drivers/gpu/drm/i915/pxp/intel_pxp.h > > new file mode 100644 > > index 000000000000..e87550fb9821 > > --- /dev/null > > +++ b/drivers/gpu/drm/i915/pxp/intel_pxp.h > > @@ -0,0 +1,35 @@ > > +/* SPDX-License-Identifier: MIT */ > > +/* > > + * Copyright(c) 2020, Intel Corporation. All rights reserved. > > + */ > > + > > +#ifndef __INTEL_PXP_H__ > > +#define __INTEL_PXP_H__ > > + > > +#include "gt/intel_gt_types.h" > > I've been trying to promote the idea that we don't include headers from > headers, unless really necessary. It helps with build times by reducing > rebuilds due to changes, but more importantly, it helps with coming up > with abstractions that don't need to look at the guts of other > components. > > The above include line pulls in 67 other includes. And it has to look at > the same files a *lot* more times to know not to include them again. > > Maybe we need to start being more aggressive about hiding the > abstractions behind the interfaces and headers. Static inlines are > nothing but micro-optimizations that leak abstractions. Do we need > these? Yeap, we have a few cases where this is already happening... Should we start using the container_of more directly and avoid the a_to_b() helpers? Should we create the a_to_b() helpers only inside .c files like we have in a few other cases? In this pxp case here it looks like using the container of directly is everywhere is better... is this your recommendation? > > > +#include "intel_pxp_types.h" > > + > > +static inline struct intel_gt *pxp_to_gt(const struct intel_pxp *pxp) > > +{ > > + return container_of(pxp, struct intel_gt, pxp); > > +} > > I think it's questionable to claim the parameter is const, when you can > do: > > const struct intel_pxp *const_pxp = something; > struct intel_pxp *pxp = &pxp_to_gt(const_pxp)->pxp; > > BR, > Jani. > > > + > > +static inline bool intel_pxp_is_enabled(const struct intel_pxp *pxp) > > +{ > > + return pxp->ce; > > +} > > + > > +#ifdef CONFIG_DRM_I915_PXP > > +void intel_pxp_init(struct intel_pxp *pxp); > > +void intel_pxp_fini(struct intel_pxp *pxp); > > +#else > > +static inline void intel_pxp_init(struct intel_pxp *pxp) > > +{ > > +} > > + > > +static inline void intel_pxp_fini(struct intel_pxp *pxp) > > +{ > > +} > > +#endif > > + > > +#endif /* __INTEL_PXP_H__ */ > > diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp_types.h b/drivers/gpu/drm/i915/pxp/intel_pxp_types.h > > new file mode 100644 > > index 000000000000..bd12c520e60a > > --- /dev/null > > +++ b/drivers/gpu/drm/i915/pxp/intel_pxp_types.h > > @@ -0,0 +1,15 @@ > > +/* SPDX-License-Identifier: MIT */ > > +/* > > + * Copyright(c) 2020, Intel Corporation. All rights reserved. > > + */ > > + > > +#ifndef __INTEL_PXP_TYPES_H__ > > +#define __INTEL_PXP_TYPES_H__ > > + > > +struct intel_context; > > + > > +struct intel_pxp { > > + struct intel_context *ce; > > +}; > > + > > +#endif /* __INTEL_PXP_TYPES_H__ */ > > -- > Jani Nikula, Intel Open Source Graphics Center