From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CC9FC433F5 for ; Thu, 16 Sep 2021 17:31:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EE4DD6103B for ; Thu, 16 Sep 2021 17:31:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349165AbhIPRch (ORCPT ); Thu, 16 Sep 2021 13:32:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348394AbhIPRXQ (ORCPT ); Thu, 16 Sep 2021 13:23:16 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 256EFC08EA79 for ; Thu, 16 Sep 2021 09:20:47 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id m21-20020a17090a859500b00197688449c4so5189674pjn.0 for ; Thu, 16 Sep 2021 09:20:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pPI/VFw1zzsayAVnvWLbDx7Hpbl9/4fZcCkZww1rQGI=; b=U5tiGDAAZOHXxrls9q5Eta2fq2CUA7BHgHHf3T5jpCvkx/QPHyRPhBPfweZG0EMPtM /hlDJCtbiPTvlayHon3zcnd9yz7sqPJ5lHP5Z8Pbkh1PbB3UqMcdw2sKBS3NPmvwKQhn Ucpy6KMSK1/HxW/9YJBDM1TK4/IJvjzEajlNl5gRxAAB4IUDKR/QTRpPK+BokmdnQUFb y6I2Jh720jk1mUDT6GaH6lBgO6Y3F4P5tEomc6Ik8jIVNQpMKX3n/+XkOxEDMFtpYKng 1XrZKUDHT5h/Mhc78bF1oTYRWj5BBrB4vHRsb/ajjorHArSS1sNlRWp45oEUmsp9X+z/ gAXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pPI/VFw1zzsayAVnvWLbDx7Hpbl9/4fZcCkZww1rQGI=; b=pfl9SxuBwNKA5Rb4dk0A/Khu2Ty3JmYQP/4C4BmtE6vdeDD51QVurNWWoitfdnigTJ 8DC/rVT0n9kjeamENPcLHlTM4sQf+ehoDdmamcjrbyuIFMaBNM7Tx3fZVihJrQzBG2yO YBKHDMln9MmTniuLjV7XZzyMYroEI6LpC3Eq6X3EBNxjb4HOQIyYZGmChYXtkIvmsxca 5whqld5qtZOMO/i7XL+wh1OuYODKZfrPQKF3oxn2g3rMVCBYUV5c4ZlhFP7BE9+z9sh4 uTu5nwuZWgQP0XXJQVPryppeEAasmn/rpwtBhScFEcNtRJV2v5YINDievHC9mZk0O+/X 4zWA== X-Gm-Message-State: AOAM5325Vi0fz0mNLPF/V8RyAV7hXWG3qfAIyaoa3whoMFmpgvedCGUl IFnvCMzZz0fKoFIKEZE8v0jvQg== X-Google-Smtp-Source: ABdhPJwOi/rPghzGiGvxWRxUWAxSCfJoIvU2qR/dq192mzrvuKW2ywbsmxspallCqVizxJKSmmm1ww== X-Received: by 2002:a17:902:82c2:b0:13c:916b:96a with SMTP id u2-20020a17090282c200b0013c916b096amr5611228plz.61.1631809246433; Thu, 16 Sep 2021 09:20:46 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id d4sm8224656pjo.12.2021.09.16.09.20.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Sep 2021 09:20:45 -0700 (PDT) Date: Thu, 16 Sep 2021 16:20:42 +0000 From: Sean Christopherson To: David Edmondson Cc: linux-kernel@vger.kernel.org, Wanpeng Li , Joerg Roedel , kvm@vger.kernel.org, Paolo Bonzini , Vitaly Kuznetsov , David Matlack , Borislav Petkov , Ingo Molnar , x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Jim Mattson , David Edmondson Subject: Re: [PATCH v5 1/4] KVM: x86: Clarify the kvm_run.emulation_failure structure layout Message-ID: References: <20210916083239.2168281-1-david.edmondson@oracle.com> <20210916083239.2168281-2-david.edmondson@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210916083239.2168281-2-david.edmondson@oracle.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 16, 2021, David Edmondson wrote: For all these patches, assuming you want the Author credit to go to your @oracle.com email, they need an explicit From: David Edmondson otherwise git will default to the "From" email header and make the Author "David Edmondson ". And then checkpatch will rightly complain that the SOB does not match the Author. Adding From: can be handled automatically by "git format-patch" via "--from", e.g. git format-patch --from="David Edmondson " ... > Until more flags for kvm_run.emulation_failure flags are defined, it > is undetermined whether new payload elements corresponding to those > flags will be additive or alternative. As a hint to userspace that an > alternative is possible, wrap the current payload elements in a union. > > Suggested-by: Sean Christopherson > Signed-off-by: David Edmondson > --- > include/uapi/linux/kvm.h | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h > index a067410ebea5..8618fe973215 100644 > --- a/include/uapi/linux/kvm.h > +++ b/include/uapi/linux/kvm.h > @@ -402,8 +402,12 @@ struct kvm_run { > __u32 suberror; > __u32 ndata; > __u64 flags; > - __u8 insn_size; > - __u8 insn_bytes[15]; > + union { > + struct { > + __u8 insn_size; > + __u8 insn_bytes[15]; > + }; > + }; > } emulation_failure; > /* KVM_EXIT_OSI */ > struct { > -- > 2.33.0 >