All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: "Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"Grygorii Strashko" <grygorii.strashko@ti.com>,
	"Suman Anna" <s-anna@ti.com>, "Andrew F. Davis" <afd@ti.com>,
	"Paul Barker" <paul.barker@sancloud.com>,
	"Peter Ujfalusi" <peter.ujfalusi@gmail.com>,
	"Benoît Cousson" <bcousson@baylibre.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: beaglebone black boot failure Linux v5.15.rc1
Date: Fri, 17 Sep 2021 09:14:26 +0300	[thread overview]
Message-ID: <YUQyQgFAOFnBlcdP@atomide.com> (raw)
In-Reply-To: <120a0ca4-28c7-5a7b-f1ab-2015c8817bda@fi.rohmeurope.com>

[-- Attachment #1: Type: text/plain, Size: 2149 bytes --]

Hi,

* Vaittinen, Matti <Matti.Vaittinen@fi.rohmeurope.com> [210916 09:15]:
> Yesterday I asked about this at #armlinux so if someone saw my message 
> there - this is the same topic.
> 
> My beaglebone black (rev c) based test environment fails to boot with 
> v5.15-rc1. Boot succeeds with the v5.14.
> 
> I use pretty old uBoot, TFTP to load kernel and device-tree, and have 
> hosted the rootfs on NFS server.

Using older u-boot versions should be just fine. Using bootz with zImage
instead of uimage is a good reason to update for folks using a really
old u-boot though.

> The v5.15-rc1 fails to boot with no prints from kernel visible in serial 
> console. Please see the serial log at the end of this message.
> 
> Bisecting the Linus' tree pointed out the commit:
> [1c7ba565e70365763ea780666a3eee679344b962] ARM: dts: am335x-baltos: 
> switch to new cpsw switch drv
> 
> I don't see this exact commit touching the BBB device-tree. In Linus' 
> tree it is a part of a merge commit. Reverting the whole merge on top of 
> the v5.15-rc1
> 
> This reverts commit 81b6a285737700c2e04ef0893617b80481b6b4b7, reversing
> changes made to f73979109bc11a0ed26b6deeb403fb5d05676ffc.
> 
> makes my beaglebone black to boot again.
> 
> Yesterday I tried adding this patch:
> https://lore.kernel.org/linux-omap/20210915065032.45013-1-tony@atomide.com/T/#u
> pointed by Tom on top of the v5.15-rc1 - no avail. I also did #define 
> DEBUG at ti-sys.c as was suggested by Tom - but I don't see any more output.

Correction, that was me, not Tom :)

For me, adding any kind of delay fixed the issue. Also adding some printk
statements fixed it for me.

> Any suggestions what to check next?

Maybe try the attached patch? If it helps, just try with the with the
ti,sysc-delay-us = <2> added as few modules need that after enable.

It's also possible there is an issue with some other device that is now
getting enabled other than pruss. The last XXX printk output should show
the last device being probed.

Looks like you need to also enable CONFIG_SERIAL_EARLYCON=y, and pass
console=ttyS0,115200 debug earlycon in the kernel command line.

Regards,

Tony

[-- Attachment #2: debug.patch --]
[-- Type: text/plain, Size: 1056 bytes --]

diff --git a/arch/arm/boot/dts/am33xx-l4.dtsi b/arch/arm/boot/dts/am33xx-l4.dtsi
--- a/arch/arm/boot/dts/am33xx-l4.dtsi
+++ b/arch/arm/boot/dts/am33xx-l4.dtsi
@@ -845,6 +845,7 @@ pruss_tm: target-module@300000 {	/* 0x4a300000, ap 9 04.0 */
 			ti,sysc-sidle = <SYSC_IDLE_FORCE>,
 					<SYSC_IDLE_NO>,
 					<SYSC_IDLE_SMART>;
+			ti,sysc-delay-us = <2>;
 			clocks = <&pruss_ocp_clkctrl AM3_PRUSS_OCP_PRUSS_CLKCTRL 0>;
 			clock-names = "fck";
 			resets = <&prm_per 1>;
diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
--- a/drivers/bus/ti-sysc.c
+++ b/drivers/bus/ti-sysc.c
@@ -2,7 +2,7 @@
 /*
  * ti-sysc.c - Texas Instruments sysc interconnect target driver
  */
-
+#define DEBUG
 #include <linux/io.h>
 #include <linux/clk.h>
 #include <linux/clkdev.h>
@@ -3051,6 +3051,8 @@ static int sysc_probe(struct platform_device *pdev)
 	if (!ddata)
 		return -ENOMEM;
 
+	dev_info(&pdev->dev, "XXX %s\n", __func__);
+
 	ddata->offsets[SYSC_REVISION] = -ENODEV;
 	ddata->offsets[SYSC_SYSCONFIG] = -ENODEV;
 	ddata->offsets[SYSC_SYSSTATUS] = -ENODEV;

  reply	other threads:[~2021-09-17  6:14 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-16  9:15 beaglebone black boot failure Linux v5.15.rc1 Vaittinen, Matti
2021-09-17  6:14 ` Tony Lindgren [this message]
2021-09-17 10:28   ` Vaittinen, Matti
2021-09-17 10:47     ` Tony Lindgren
2021-09-17 10:57     ` Grygorii Strashko
2021-09-17 11:01       ` Grygorii Strashko
2021-09-17 11:34         ` Vaittinen, Matti
2021-09-17 12:36           ` Grygorii Strashko
2021-09-20 10:05             ` Matti Vaittinen
2021-09-21  7:47               ` Tony Lindgren
2021-09-21 16:07                 ` Suman Anna
2021-09-21 16:40                   ` H. Nikolaus Schaller
2021-09-21 16:49                     ` Suman Anna
2021-09-22  9:27                     ` Vaittinen, Matti
2021-09-24 18:40                       ` Robert Nelson
2021-09-30  8:10                         ` Tony Lindgren
2021-09-30  9:41                           ` Vaittinen, Matti
2021-09-21 20:29                   ` Drew Fustini
2021-09-21 21:49                     ` Suman Anna
2021-09-21 22:00                       ` Robert Nelson
2021-09-21 23:53                         ` Suman Anna
2021-09-22  8:44                 ` Vaittinen, Matti
2021-09-22  8:48                   ` Tony Lindgren
2021-09-30  8:06                     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YUQyQgFAOFnBlcdP@atomide.com \
    --to=tony@atomide.com \
    --cc=Matti.Vaittinen@fi.rohmeurope.com \
    --cc=afd@ti.com \
    --cc=bcousson@baylibre.com \
    --cc=grygorii.strashko@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul.barker@sancloud.com \
    --cc=peter.ujfalusi@gmail.com \
    --cc=s-anna@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.