From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28766C433FE for ; Fri, 17 Sep 2021 14:56:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0D711611C3 for ; Fri, 17 Sep 2021 14:56:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236485AbhIQO5h (ORCPT ); Fri, 17 Sep 2021 10:57:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229834AbhIQO5h (ORCPT ); Fri, 17 Sep 2021 10:57:37 -0400 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD9B1C061574 for ; Fri, 17 Sep 2021 07:56:14 -0700 (PDT) Received: by mail-ed1-x52c.google.com with SMTP id g8so31121884edt.7 for ; Fri, 17 Sep 2021 07:56:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=X29mbY4XMQeoCuwbVUTtCWIrpaTXec+xmjDFVMtuCBM=; b=A1mcavcYt2QQTNBkoc/FLtlWT1v9wbPlqaIljyDs2v8H+aMqb3YWAo/dBjkr7bnB9Q fdKFk/C3fl1c+dc4jgBuYmy83h8ZIAXghsGelEppBnIbXsB+MPbQHYy2wL6veYXqLwB0 IXY7RuywYKGiRoaVNoO2pnLtiRV+KPnamRdbM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=X29mbY4XMQeoCuwbVUTtCWIrpaTXec+xmjDFVMtuCBM=; b=cYUg3uanQVgEzG6BxihAZS1oEpeJ6arwQSyKIM/CtgdLr2IT0qe7RYpwNabzxX0fCr nzlAZzVuH1mjHxqr12OKUhjDTgZQlV5c8BcbKEnuE34p+bgORk1Kqv5SIvMZKF+tCP5H CYVfXdnug/9Y7YSjG3NWaBN7Sfz9NbVD2muVjaEoKZ6cnIzcF67jdRi1/RyA1UlbKH6a p2TnboHpnrm10YSWLSlFXXI5YtPzns6b8lL9TnFwlUsX6OV4zLtbIUq2aGsQOG1J+fg5 cmSb+JpCR6vXRCsqVZ6g6AtMNBB/lGAYf5kgIPcZ2rl5PNxEivMx6DW3ZPYIBUpBt9Ie vaHg== X-Gm-Message-State: AOAM531Wrh9VHZJ7DE+W6SghcrBV7s/lcJ8weG4C8Q27d0wWoaV4Sw1B pNJjWVmrGV0ToCkcy6rgldgjpg== X-Google-Smtp-Source: ABdhPJzipdEA6H6mMcSGep1fE9poMh/Q4IA14eEu/6Rd+xLXMksMP/16auhU0CWMS0H+xVD6zggZfg== X-Received: by 2002:a17:906:fb13:: with SMTP id lz19mr12364559ejb.516.1631890573401; Fri, 17 Sep 2021 07:56:13 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id o23sm2752212eds.75.2021.09.17.07.56.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Sep 2021 07:56:12 -0700 (PDT) Date: Fri, 17 Sep 2021 16:56:11 +0200 From: Daniel Vetter To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: linaro-mm-sig@lists.linaro.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, intel-gfx@lists.freedesktop.org, daniel@ffwll.ch Subject: Re: [PATCH 26/26] dma-buf: nuke dma_resv_get_excl_unlocked Message-ID: References: <20210917123513.1106-1-christian.koenig@amd.com> <20210917123513.1106-27-christian.koenig@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210917123513.1106-27-christian.koenig@amd.com> X-Operating-System: Linux phenom 5.10.0-8-amd64 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Fri, Sep 17, 2021 at 02:35:13PM +0200, Christian König wrote: > Heureka, that's finally not used any more. > > Signed-off-by: Christian König Reviewed-by: Daniel Vetter > --- > include/linux/dma-resv.h | 26 -------------------------- > 1 file changed, 26 deletions(-) > > diff --git a/include/linux/dma-resv.h b/include/linux/dma-resv.h > index 8c968f8c9d33..f42ca254acb5 100644 > --- a/include/linux/dma-resv.h > +++ b/include/linux/dma-resv.h > @@ -423,32 +423,6 @@ dma_resv_excl_fence(struct dma_resv *obj) > return rcu_dereference_check(obj->fence_excl, dma_resv_held(obj)); > } > > -/** > - * dma_resv_get_excl_unlocked - get the reservation object's > - * exclusive fence, without lock held. > - * @obj: the reservation object > - * > - * If there is an exclusive fence, this atomically increments it's > - * reference count and returns it. > - * > - * RETURNS > - * The exclusive fence or NULL if none > - */ > -static inline struct dma_fence * > -dma_resv_get_excl_unlocked(struct dma_resv *obj) > -{ > - struct dma_fence *fence; > - > - if (!rcu_access_pointer(obj->fence_excl)) > - return NULL; > - > - rcu_read_lock(); > - fence = dma_fence_get_rcu_safe(&obj->fence_excl); > - rcu_read_unlock(); > - > - return fence; > -} > - > /** > * dma_resv_shared_list - get the reservation object's shared fence list > * @obj: the reservation object > -- > 2.25.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CFBFC433F5 for ; Fri, 17 Sep 2021 14:56:16 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 690F860F38 for ; Fri, 17 Sep 2021 14:56:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 690F860F38 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1124D6ED8D; Fri, 17 Sep 2021 14:56:16 +0000 (UTC) Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by gabe.freedesktop.org (Postfix) with ESMTPS id D012D6ED8D for ; Fri, 17 Sep 2021 14:56:14 +0000 (UTC) Received: by mail-ed1-x529.google.com with SMTP id v24so30994691eda.3 for ; Fri, 17 Sep 2021 07:56:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=X29mbY4XMQeoCuwbVUTtCWIrpaTXec+xmjDFVMtuCBM=; b=A1mcavcYt2QQTNBkoc/FLtlWT1v9wbPlqaIljyDs2v8H+aMqb3YWAo/dBjkr7bnB9Q fdKFk/C3fl1c+dc4jgBuYmy83h8ZIAXghsGelEppBnIbXsB+MPbQHYy2wL6veYXqLwB0 IXY7RuywYKGiRoaVNoO2pnLtiRV+KPnamRdbM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=X29mbY4XMQeoCuwbVUTtCWIrpaTXec+xmjDFVMtuCBM=; b=wPhjvgLgCv3qxQF9u47ptVNSXkF+xzBKTRuPIZkE03Yk4+HOU595X0wPeqQFHgMMR+ cUD0/7yNXoOubQTlywR7MJrHW0girccI67tNkrocNKABLfSqbGRkxlYw8lsGE3gxc9jr 1dD8NMc5qQzVHKBGiHJrDuV6QYKNDLDjyPWyVQW4qwAxOrJC1KKQRBVjTTs2XcG34vvz 4KwTvb4e5fLjBhmG1NctCigdXvJR+c8RTc6zQhzSukIL2vNn4BwOD//xm0r9sVOqWLcv B/9YnOOaLM3BM3mD0YOV1JrDYWcnQBaXaujny+V6T5l5umHoa9FjS0trCpb5AcFQQrGF AzMA== X-Gm-Message-State: AOAM531p7hYiiRDheURPO07WF3xrtIKGUaS/urvbh2SxYvuv/rAHd3LG 50lX5GN+FBHXFypUXfi44yDtOQ== X-Google-Smtp-Source: ABdhPJzipdEA6H6mMcSGep1fE9poMh/Q4IA14eEu/6Rd+xLXMksMP/16auhU0CWMS0H+xVD6zggZfg== X-Received: by 2002:a17:906:fb13:: with SMTP id lz19mr12364559ejb.516.1631890573401; Fri, 17 Sep 2021 07:56:13 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id o23sm2752212eds.75.2021.09.17.07.56.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Sep 2021 07:56:12 -0700 (PDT) Date: Fri, 17 Sep 2021 16:56:11 +0200 From: Daniel Vetter To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: linaro-mm-sig@lists.linaro.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, intel-gfx@lists.freedesktop.org, daniel@ffwll.ch Message-ID: References: <20210917123513.1106-1-christian.koenig@amd.com> <20210917123513.1106-27-christian.koenig@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210917123513.1106-27-christian.koenig@amd.com> X-Operating-System: Linux phenom 5.10.0-8-amd64 Subject: Re: [Intel-gfx] [PATCH 26/26] dma-buf: nuke dma_resv_get_excl_unlocked X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, Sep 17, 2021 at 02:35:13PM +0200, Christian König wrote: > Heureka, that's finally not used any more. > > Signed-off-by: Christian König Reviewed-by: Daniel Vetter > --- > include/linux/dma-resv.h | 26 -------------------------- > 1 file changed, 26 deletions(-) > > diff --git a/include/linux/dma-resv.h b/include/linux/dma-resv.h > index 8c968f8c9d33..f42ca254acb5 100644 > --- a/include/linux/dma-resv.h > +++ b/include/linux/dma-resv.h > @@ -423,32 +423,6 @@ dma_resv_excl_fence(struct dma_resv *obj) > return rcu_dereference_check(obj->fence_excl, dma_resv_held(obj)); > } > > -/** > - * dma_resv_get_excl_unlocked - get the reservation object's > - * exclusive fence, without lock held. > - * @obj: the reservation object > - * > - * If there is an exclusive fence, this atomically increments it's > - * reference count and returns it. > - * > - * RETURNS > - * The exclusive fence or NULL if none > - */ > -static inline struct dma_fence * > -dma_resv_get_excl_unlocked(struct dma_resv *obj) > -{ > - struct dma_fence *fence; > - > - if (!rcu_access_pointer(obj->fence_excl)) > - return NULL; > - > - rcu_read_lock(); > - fence = dma_fence_get_rcu_safe(&obj->fence_excl); > - rcu_read_unlock(); > - > - return fence; > -} > - > /** > * dma_resv_shared_list - get the reservation object's shared fence list > * @obj: the reservation object > -- > 2.25.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch