From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91CEBC433EF for ; Sat, 18 Sep 2021 20:29:48 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2773460F51 for ; Sat, 18 Sep 2021 20:29:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2773460F51 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 374D96E10E; Sat, 18 Sep 2021 20:29:47 +0000 (UTC) Received: from mx2.smtp.larsendata.com (mx2.smtp.larsendata.com [91.221.196.228]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3598B6E110 for ; Sat, 18 Sep 2021 20:29:44 +0000 (UTC) Received: from mail01.mxhotel.dk (mail01.mxhotel.dk [91.221.196.236]) by mx2.smtp.larsendata.com (Halon) with ESMTPS id 2198d68a-18bf-11ec-9416-0050568cd888; Sat, 18 Sep 2021 20:29:32 +0000 (UTC) Received: from ravnborg.org (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: sam@ravnborg.org) by mail01.mxhotel.dk (Postfix) with ESMTPSA id B1147194BA8; Sat, 18 Sep 2021 22:29:34 +0200 (CEST) Date: Sat, 18 Sep 2021 22:29:40 +0200 X-Report-Abuse-To: abuse@mxhotel.dk From: Sam Ravnborg To: Philip Chen Cc: LKML , swboyd@chromium.org, dianders@chromium.org, Andrzej Hajda , Daniel Vetter , David Airlie , Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Neil Armstrong , Robert Foss , dri-devel@lists.freedesktop.org Subject: Re: [PATCH v5 2/2] drm/bridge: parade-ps8640: Add support for AUX channel Message-ID: References: <20210918102058.v5.1.I2351df94f18d5d8debc22d4d100f36fac560409a@changeid> <20210918102058.v5.2.Ifcb5df5de5b1cead7c99e0f37b044ef5cfc69eda@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210918102058.v5.2.Ifcb5df5de5b1cead7c99e0f37b044ef5cfc69eda@changeid> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Philip, On Sat, Sep 18, 2021 at 10:21:17AM -0700, Philip Chen wrote: > Implement the first version of AUX support, which will be useful as > we expand the driver to support varied use cases. > > Signed-off-by: Philip Chen Patch is: Signed-off-by: Sam Ravnborg please consider a few follow-up patches: 1) Replace deprecated drm_bridge_funcs with the _atomic_ variants. 2) Replace the deprecated drm_bridge_chain_pre_enable() with the atomic variant. 3) Use pr_() and dev_() logging in favour of DRM_ logging. DRM_ logging is deprecated these days and do not belong in bridge drivers anyway. Maxime has a few patches pending for this driver - it would be great if you could look them up and review them. Maybe you can get some review in feedback. Sam