From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A4C8C433F5 for ; Mon, 20 Sep 2021 08:08:34 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 2F2AA610A3 for ; Mon, 20 Sep 2021 08:08:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2F2AA610A3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 840EF40DF7; Mon, 20 Sep 2021 10:08:33 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 896B040DF5 for ; Mon, 20 Sep 2021 10:08:32 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10112"; a="221201319" X-IronPort-AV: E=Sophos;i="5.85,307,1624345200"; d="scan'208";a="221201319" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2021 01:08:25 -0700 X-IronPort-AV: E=Sophos;i="5.85,307,1624345200"; d="scan'208";a="700914846" Received: from jeganx-mobl.ger.corp.intel.com (HELO bricha3-MOBL.ger.corp.intel.com) ([10.252.17.156]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 20 Sep 2021 01:08:24 -0700 Date: Mon, 20 Sep 2021 09:08:20 +0100 From: Bruce Richardson To: kefu chai Cc: dev@dpdk.org, anatoly.burakov@intel.com Message-ID: References: <20210902151100.140330-1-tchaikov@gmail.com> <20210908165131.133444-1-tchaikov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH v4] build: add meson options of max_memseg_lists and atomic_mbuf_ref_counts X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Sep 20, 2021 at 03:51:06PM +0800, kefu chai wrote: > hello Bruce, > > do you have any further concerns? is there anything i can do to move > this forward? > > cheers, > +Anatoly, for his input for the memory segments change. I still would prefer not to have these as config options, but perhaps one or both needs to be. The atomic refcount seems more reasonable to add of the two. For the max memseg lists, what is the impact if we were to increase this value globally? /Bruce > On Thu, Sep 9, 2021 at 12:51 AM Kefu Chai wrote: > > > > RTE_MAX_MEMSEG_LISTS = 128 is not enough for high-memory machines, in our > > case, we need to increase it to 8192. so add an option so user can > > override it. RTE_MBUF_REFCNT_ATOMIC = 0 is not necessary for applications > > like Seastar, where it's safe to assume that the mbuf refcnt is only > > updated by a single core only. > > > > --- > > > > v4: > > > > fix the coding style issue by reduce the line length to under 75. > > this change should silence the warning like: > > > > WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) > > #81: > > RTE_MAX_MEMSEG_LISTS = 128 is not enough for high-memory machines, in our case, > > > > total: 0 errors, 1 warnings, 35 lines checked > > > > Signed-off-by: Kefu Chai > > --- > > config/meson.build | 5 ++++- > > config/rte_config.h | 2 -- > > meson_options.txt | 4 ++++ > > 3 files changed, 8 insertions(+), 3 deletions(-) > >