From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9350C433FE for ; Mon, 20 Sep 2021 16:53:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A51D861504 for ; Mon, 20 Sep 2021 16:53:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242248AbhITQzG (ORCPT ); Mon, 20 Sep 2021 12:55:06 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:50612 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240476AbhITQuw (ORCPT ); Mon, 20 Sep 2021 12:50:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=PdjbhjDKUH4VNwSZHwS+PmBefZ+LAhElGG9ogBWEbR8=; b=4YYUBo3LWOkun1WSOq+O7nvmwk 2xEPNxsfzRcoMXscHpRtTV7sLQRvzMq6P4No3bUtCQqO+qc4YYBcTMcGOWuVEfXDBAdb6vOOlvi7M BlgMG+VonLvGr+bx9L0M9NJ8zroiBb+oPurmvlMj3/ix99ajjzZCyWBSv3ZQm+ro7qXs=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1mSMTo-007WD4-4F; Mon, 20 Sep 2021 18:49:20 +0200 Date: Mon, 20 Sep 2021 18:49:20 +0200 From: Andrew Lunn To: Min Li Cc: Jakub Kicinski , "richardcochran@gmail.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH net v2 2/2] ptp: idt82p33: implement double dco time correction Message-ID: References: <1631889589-26941-1-git-send-email-min.li.xe@renesas.com> <1631889589-26941-2-git-send-email-min.li.xe@renesas.com> <20210917125401.6e22ae13@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20210917140631.696aadc9@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 20, 2021 at 03:13:14PM +0000, Min Li wrote: > > > > > On Fri, Jun 25, 2021 at 02:24:24PM +0000, Min Li wrote: > > > > How would you suggest to implement the change that make the new > > driver behavior optional? > > > I would say, module parameter or debugfs knob. > > > > Aright, in which case devlink or debugfs, please. > > > Hi Jakub > > The target platform BSP is little old and doesn't support devlink_params_register yet. > > And our design doesn't allow debugfs to be used in released software. That does not matter. You are not submitting code to your BSP, you are submitting to mainline. Please use the features mainline provides. Andrew