From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BC96C433EF for ; Mon, 20 Sep 2021 15:31:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1B03C6115B for ; Mon, 20 Sep 2021 15:31:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241552AbhITPdH (ORCPT ); Mon, 20 Sep 2021 11:33:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:56806 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241519AbhITPdF (ORCPT ); Mon, 20 Sep 2021 11:33:05 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 80F0E60F58; Mon, 20 Sep 2021 15:31:36 +0000 (UTC) Date: Mon, 20 Sep 2021 16:31:33 +0100 From: Catalin Marinas To: Vincenzo Frascino Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, Andrew Morton , Will Deacon , Dmitry Vyukov , Andrey Ryabinin , Alexander Potapenko , Marco Elver , Evgenii Stepanov , Branislav Rankov , Andrey Konovalov , Lorenzo Pieralisi , Suzuki K Poulose Subject: Re: [PATCH 3/5] arm64: mte: CPU feature detection for Asymm MTE Message-ID: References: <20210913081424.48613-1-vincenzo.frascino@arm.com> <20210913081424.48613-4-vincenzo.frascino@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210913081424.48613-4-vincenzo.frascino@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 13, 2021 at 09:14:22AM +0100, Vincenzo Frascino wrote: > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c > index f8a3067d10c6..a18774071a45 100644 > --- a/arch/arm64/kernel/cpufeature.c > +++ b/arch/arm64/kernel/cpufeature.c > @@ -2317,6 +2317,16 @@ static const struct arm64_cpu_capabilities arm64_features[] = { > .sign = FTR_UNSIGNED, > .cpu_enable = cpu_enable_mte, > }, > + { > + .desc = "Asymmetric Memory Tagging Extension", I'd give this a better name as it's not entirely clear what it does. In the ARM ARM this is described as "asymmetric Tag Check Fault handling". Maybe just rename it to "Asymmetric MTE Tag Check Fault". Similarly in the Kconfig if you added one. Otherwise: Reviewed-by: Catalin Marinas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FCC4C433EF for ; Mon, 20 Sep 2021 15:33:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 50C9760F36 for ; Mon, 20 Sep 2021 15:33:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 50C9760F36 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ci37hm1WEOSRltP9FcPu1b43NKQdVuT323unrYGTn/M=; b=Q9IlPbbvAaAe24 h+tEoHVJB3N7YAjScHm6bWSIviJ/H35P+UXDrQxRQr34Y1TpUtxHeh+x5emcp5aTQapUrHp5v/Hg8 9GJIH1BHkdEO3BTWCUKlNhjISJjvaowY4Hz4StD1UfpJXnQ0GNXFsNJesMqp+KYW+9N6u8S++iYy/ T9gK8Z+lnF7yW4Gs0To4HK4sOK/rBpye1a06K5p3lDzw/P08+Vi8SOcAISjMT+MB1QwaS4QvvZW7D CC36Wc22u6q1cf6QM1qMmfhVLHYK6dhdkrEkwN6PZWiJnMj7ryDTOCsUf8hoo8W0GSUn/FXlE/m9x NXFlWdG8+/Kvyr9wJUiw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSLGh-002Ddd-2A; Mon, 20 Sep 2021 15:31:43 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSLGd-002Dc8-9m for linux-arm-kernel@lists.infradead.org; Mon, 20 Sep 2021 15:31:40 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 80F0E60F58; Mon, 20 Sep 2021 15:31:36 +0000 (UTC) Date: Mon, 20 Sep 2021 16:31:33 +0100 From: Catalin Marinas To: Vincenzo Frascino Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, Andrew Morton , Will Deacon , Dmitry Vyukov , Andrey Ryabinin , Alexander Potapenko , Marco Elver , Evgenii Stepanov , Branislav Rankov , Andrey Konovalov , Lorenzo Pieralisi , Suzuki K Poulose Subject: Re: [PATCH 3/5] arm64: mte: CPU feature detection for Asymm MTE Message-ID: References: <20210913081424.48613-1-vincenzo.frascino@arm.com> <20210913081424.48613-4-vincenzo.frascino@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210913081424.48613-4-vincenzo.frascino@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210920_083139_377614_A77B3D0A X-CRM114-Status: GOOD ( 11.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 13, 2021 at 09:14:22AM +0100, Vincenzo Frascino wrote: > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c > index f8a3067d10c6..a18774071a45 100644 > --- a/arch/arm64/kernel/cpufeature.c > +++ b/arch/arm64/kernel/cpufeature.c > @@ -2317,6 +2317,16 @@ static const struct arm64_cpu_capabilities arm64_features[] = { > .sign = FTR_UNSIGNED, > .cpu_enable = cpu_enable_mte, > }, > + { > + .desc = "Asymmetric Memory Tagging Extension", I'd give this a better name as it's not entirely clear what it does. In the ARM ARM this is described as "asymmetric Tag Check Fault handling". Maybe just rename it to "Asymmetric MTE Tag Check Fault". Similarly in the Kconfig if you added one. Otherwise: Reviewed-by: Catalin Marinas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel