All of lore.kernel.org
 help / color / mirror / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org, gitster@pobox.com, calbabreaker@gmail.com,
	Derrick Stolee <derrickstolee@github.com>,
	Derrick Stolee <dstolee@microsoft.com>
Subject: Re: [PATCH 2/3] sparse-checkout: clear patterns when switching modes
Date: Mon, 20 Sep 2021 14:54:01 -0400	[thread overview]
Message-ID: <YUjYyY+1IXOJYvgk@nand.local> (raw)
In-Reply-To: <YUjYZNqvvxVRctJQ@nand.local>

On Mon, Sep 20, 2021 at 02:52:20PM -0400, Taylor Blau wrote:
> See my message at [1] for some more details about a possible suggestion
> there.

OK, I see that in the third patch we do start complaining about adding
patterns in cone-mode when the existing sparse checkout configuration
does not form a cone.

So that may indicate that we expect users who wish to blow away their
configuration to just run "init --cone". I'd be OK with that (without an
additional warning step, although I think that doing that would be
better). But either way, we should document this behavior clearly.

> [1]: https://lore.kernel.org/git/YUi55%2F3L9nizTVyA@nand.local/

Thanks,
Taylor

  reply	other threads:[~2021-09-21  2:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-20 17:57 [PATCH 0/3] Sparse checkout: fix mixed-mode pattern issues Derrick Stolee via GitGitGadget
2021-09-20 17:57 ` [PATCH 1/3] sparse-checkout: fix OOM error with mixed patterns Derrick Stolee via GitGitGadget
2021-09-20 18:24   ` Taylor Blau
2021-09-21 13:06     ` Derrick Stolee
2021-09-21 16:35       ` Taylor Blau
2021-09-20 17:57 ` [PATCH 2/3] sparse-checkout: clear patterns when switching modes Derrick Stolee via GitGitGadget
2021-09-20 18:52   ` Taylor Blau
2021-09-20 18:54     ` Taylor Blau [this message]
2021-09-20 17:57 ` [PATCH 3/3] sparse-checkout: refuse to add to bad patterns Derrick Stolee via GitGitGadget
2021-09-20 18:59   ` Taylor Blau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YUjYyY+1IXOJYvgk@nand.local \
    --to=me@ttaylorr.com \
    --cc=calbabreaker@gmail.com \
    --cc=derrickstolee@github.com \
    --cc=dstolee@microsoft.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.