From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14073C433FE for ; Mon, 20 Sep 2021 19:21:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EECBC61205 for ; Mon, 20 Sep 2021 19:21:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350806AbhITTWu (ORCPT ); Mon, 20 Sep 2021 15:22:50 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:50858 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245388AbhITTUp (ORCPT ); Mon, 20 Sep 2021 15:20:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=TkN2Ia7bums+Ijew637ZfATCHcWZLf84rC4MSNogrQc=; b=zfVXbzPogWtzueEw5yX5NKNkwJ ZsvdtMjs25dfU6fsCVGbwZbV4U5pTiodfR9l8f1S0AfR++CK7+y8zgi5CPDLHE/vCW2KYaNBteUSE HzBIPdT6P6IA0/h1oh+MuAk1cSeR5L5uqloHR8Xw+pIr10eME5OGE1TEh7QxzJmja8c0=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1mSOor-007XDO-1m; Mon, 20 Sep 2021 21:19:13 +0200 Date: Mon, 20 Sep 2021 21:19:13 +0200 From: Andrew Lunn To: Ansuel Smith Cc: Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Jakub Kicinski , Rob Herring , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [net-next RFC PATCH 1/2] drivers: net: dsa: qca8k: add support for led config Message-ID: References: <20210920180851.30762-1-ansuelsmth@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Yes, can you point me to the discussion? It has gone through many cycles :-( The linux-led list is probably the better archive to look through, it is a lot lower volume than netdev. https://www.spinics.net/lists/linux-leds/msg18652.html https://www.spinics.net/lists/linux-leds/msg18527.html > I post this as RFC for this exact reason... I read somehwere that there > was a discussion on how to implementd leds for switch but never ever > found it. Most of the discussion so far has been about PHY LEDs, where the PHY driver controls the LEDs. However some Ethernet switches also have LED controls, which are not part of the PHY. And then there are some MAC drivers which control the PHY in firmware, and have firmware calls for controlling the LEDs. We need a generic solution which scales across all this. And it needs to work without DT, or at least, not block ACPI being added later. But progress is slow. I hope that the PHY use case will drive things forward, get the ABI defined. We can then scale it out to include switches, maybe with a bit of code refactoring. Andrew