From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AB36C433F5 for ; Mon, 20 Sep 2021 20:07:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0D0D261244 for ; Mon, 20 Sep 2021 20:07:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231158AbhITUIl (ORCPT ); Mon, 20 Sep 2021 16:08:41 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:65035 "EHLO relay1-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236813AbhITUGj (ORCPT ); Mon, 20 Sep 2021 16:06:39 -0400 Received: (Authenticated sender: alexandre.belloni@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 2C649240006; Mon, 20 Sep 2021 20:05:10 +0000 (UTC) Date: Mon, 20 Sep 2021 22:05:09 +0200 From: Alexandre Belloni To: Will McVicker Cc: Catalin Marinas , Will Deacon , Alessandro Zummo , Lee Jones , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org Subject: Re: [PATCH v1 4/4] rtc: change HAVE_S3C_RTC default config logic Message-ID: References: <20210920190350.3860821-1-willmcvicker@google.com> <20210920190350.3860821-5-willmcvicker@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210920190350.3860821-5-willmcvicker@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/09/2021 19:03:49+0000, Will McVicker wrote: > Switches the default config logic of HAVE_S3C_RTC to use "default y if > (ARCH_EXYNOS && RTC_CLASS)" versus having ARCH_EXYNOS directly select > it. This provides vendors flexibility to disable the config if desired > or modularize it in the presence of a generic kernel. > > Verified this change doesn't impact the .config. > > Signed-off-by: Will McVicker Acked-by: Alexandre Belloni > --- > arch/arm64/Kconfig.platforms | 1 - > drivers/rtc/Kconfig | 1 + > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms > index a884e5da8b0f..f9f829aab511 100644 > --- a/arch/arm64/Kconfig.platforms > +++ b/arch/arm64/Kconfig.platforms > @@ -91,7 +91,6 @@ config ARCH_BRCMSTB > > config ARCH_EXYNOS > bool "ARMv8 based Samsung Exynos SoC family" > - select HAVE_S3C_RTC if RTC_CLASS > select PINCTRL > select PM_GENERIC_DOMAINS if PM > help > diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig > index e1bc5214494e..40afdb37d2a5 100644 > --- a/drivers/rtc/Kconfig > +++ b/drivers/rtc/Kconfig > @@ -1406,6 +1406,7 @@ config RTC_DRV_OMAP > > config HAVE_S3C_RTC > bool > + default y if (ARCH_EXYNOS && RTC_CLASS) > help > This will include RTC support for Samsung SoCs. If > you want to include RTC support for any machine, kindly > -- > 2.33.0.464.g1972c5931b-goog > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFA20C433FE for ; Mon, 20 Sep 2021 20:07:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8AE5661244 for ; Mon, 20 Sep 2021 20:07:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8AE5661244 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=POhsjsz3RG0NFAitx6BSBPoOzzYKpC860wkUtHfn0GI=; b=ZosJAXgkrATK2i J3vZyFHdCOsT1unrUgl/VH1nnv9rUQMD5ET8zth3aMkReLt9EXE6f0QHozj83R+SqjSfejxoL5xyV /CZ5Rrj3u7338F8jyOHcRrxw27Cnln3viZOKCJC95d1eG08QH11xeWhr1yFh9jiI1VA+kx5rJniRx 7eOXf+hidYW2xTF3uTCe2ZOoKP8dpA2JwO42oJlWa1gVh0/XXq1s+Zsx7ML62+ktLQFoYiWlHzy3c OghtcO3ggT3yP5RJ53j1UhLMXDuRHKYQSp49MLF8hFMrBnwXXp1k7t/VJ3EW7FwtujOfntGXFOmgM fAv6039G3X4WDzdB1AoQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSPXS-0030PV-Fg; Mon, 20 Sep 2021 20:05:18 +0000 Received: from relay1-d.mail.gandi.net ([217.70.183.193]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSPXO-0030Oc-4a for linux-arm-kernel@lists.infradead.org; Mon, 20 Sep 2021 20:05:16 +0000 Received: (Authenticated sender: alexandre.belloni@bootlin.com) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 2C649240006; Mon, 20 Sep 2021 20:05:10 +0000 (UTC) Date: Mon, 20 Sep 2021 22:05:09 +0200 From: Alexandre Belloni To: Will McVicker Cc: Catalin Marinas , Will Deacon , Alessandro Zummo , Lee Jones , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org Subject: Re: [PATCH v1 4/4] rtc: change HAVE_S3C_RTC default config logic Message-ID: References: <20210920190350.3860821-1-willmcvicker@google.com> <20210920190350.3860821-5-willmcvicker@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210920190350.3860821-5-willmcvicker@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210920_130514_357352_E151BAE7 X-CRM114-Status: GOOD ( 18.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 20/09/2021 19:03:49+0000, Will McVicker wrote: > Switches the default config logic of HAVE_S3C_RTC to use "default y if > (ARCH_EXYNOS && RTC_CLASS)" versus having ARCH_EXYNOS directly select > it. This provides vendors flexibility to disable the config if desired > or modularize it in the presence of a generic kernel. > > Verified this change doesn't impact the .config. > > Signed-off-by: Will McVicker Acked-by: Alexandre Belloni > --- > arch/arm64/Kconfig.platforms | 1 - > drivers/rtc/Kconfig | 1 + > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms > index a884e5da8b0f..f9f829aab511 100644 > --- a/arch/arm64/Kconfig.platforms > +++ b/arch/arm64/Kconfig.platforms > @@ -91,7 +91,6 @@ config ARCH_BRCMSTB > > config ARCH_EXYNOS > bool "ARMv8 based Samsung Exynos SoC family" > - select HAVE_S3C_RTC if RTC_CLASS > select PINCTRL > select PM_GENERIC_DOMAINS if PM > help > diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig > index e1bc5214494e..40afdb37d2a5 100644 > --- a/drivers/rtc/Kconfig > +++ b/drivers/rtc/Kconfig > @@ -1406,6 +1406,7 @@ config RTC_DRV_OMAP > > config HAVE_S3C_RTC > bool > + default y if (ARCH_EXYNOS && RTC_CLASS) > help > This will include RTC support for Samsung SoCs. If > you want to include RTC support for any machine, kindly > -- > 2.33.0.464.g1972c5931b-goog > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel