All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf 0/2] netfilter: nf_nat_masquerade: don't block rtnl lock
Date: Tue, 21 Sep 2021 03:48:25 +0200	[thread overview]
Message-ID: <YUk56VxnSw1FzeCD@salvia> (raw)
In-Reply-To: <20210915144639.25024-1-fw@strlen.de>

On Wed, Sep 15, 2021 at 04:46:37PM +0200, Florian Westphal wrote:
> nf_nat_masquerade registers conntrack notifiers to early-expire
> conntracks that have been using the downed device/removed address.
> 
> With large number of disappearing devices (ppp), iterating the table
> for every notification blocks the rtnl lock for multiple seconds.
> 
> This change unconditionally defers the walk to the system work queue
> so that rtnl lock is not blocked longer than needed.
> 
> This is not a regression, the notifier and cleanup walk have existed
> since the functionality was added more than 20 years ago.

Series applied, thanks.

      parent reply	other threads:[~2021-09-21  1:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-15 14:46 [PATCH nf 0/2] netfilter: nf_nat_masquerade: don't block rtnl lock Florian Westphal
2021-09-15 14:46 ` [PATCH nf 1/2] netfilter: nf_nat_masquerade: make async masq_inet6_event handling generic Florian Westphal
2021-09-15 14:46 ` [PATCH nf 2/2] netfilter: nf_nat_masquerade: defer conntrack walk to work queue Florian Westphal
2021-09-21  1:48 ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YUk56VxnSw1FzeCD@salvia \
    --to=pablo@netfilter.org \
    --cc=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.