From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70139C433FE for ; Tue, 21 Sep 2021 15:53:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 573A161183 for ; Tue, 21 Sep 2021 15:53:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234332AbhIUPzJ (ORCPT ); Tue, 21 Sep 2021 11:55:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:41224 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234299AbhIUPyl (ORCPT ); Tue, 21 Sep 2021 11:54:41 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 86C21611EF; Tue, 21 Sep 2021 15:53:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1632239593; bh=RAm2TBCw5TxiLV9IkIE8lJLorq9H5ORzpSdJSH0VVMM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qUg8+mphxk8z+noePav16pSzYFFOMNmzS+mQUaKlcLpbGHK6p5WtGBHBlI4HZJTxn Vql2jry1zP03ruf2RdOOIloJodYdSc4Nv+ccT9Q+1Teu9mdIzVllvjI8b+AQ+LKLp9 b5ZkavNVKI87SisZLhBN+FwyykvBSzazrAIbKhOA= Date: Tue, 21 Sep 2021 17:53:10 +0200 From: Greg Kroah-Hartman To: Joe Perches Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Michael Chan , Jakub Kicinski , Sasha Levin Subject: Re: [PATCH 5.10 116/122] bnxt_en: Convert to use netif_level() helpers. Message-ID: References: <20210920163915.757887582@linuxfoundation.org> <20210920163919.617145875@linuxfoundation.org> <5662a5175932e46febd024cadc4bece443aa92c0.camel@perches.com> <0a25e9c5ff70899369134be4fdd609d2ee21baed.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0a25e9c5ff70899369134be4fdd609d2ee21baed.camel@perches.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 21, 2021 at 08:49:52AM -0700, Joe Perches wrote: > On Tue, 2021-09-21 at 17:04 +0200, Greg Kroah-Hartman wrote: > > On Tue, Sep 21, 2021 at 07:30:42AM -0700, Joe Perches wrote: > > > On Mon, 2021-09-20 at 18:44 +0200, Greg Kroah-Hartman wrote: > > > > From: Michael Chan > > > > > > > > [ Upstream commit 871127e6ab0d6abb904cec81fc022baf6953be1f ] > > > > > > > > Use the various netif_level() helpers to simplify the C code. This was > > > > suggested by Joe Perches. > > > > > > There isn't an actual change here. > > > > > > Unless this is a precursor to another patch, this isn't anything > > > that should go into stable. > > > > > It is a dependancy for other fixes. > > Then it's useful/necessary to mark it as such when applying it. > That's hard/difficult/messy to do :)