From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09422C433FE for ; Tue, 21 Sep 2021 13:33:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DE4AF61131 for ; Tue, 21 Sep 2021 13:33:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232227AbhIUNez (ORCPT ); Tue, 21 Sep 2021 09:34:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233089AbhIUNex (ORCPT ); Tue, 21 Sep 2021 09:34:53 -0400 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95EE0C061574 for ; Tue, 21 Sep 2021 06:33:24 -0700 (PDT) Received: by mail-wr1-x434.google.com with SMTP id u15so39236227wru.6 for ; Tue, 21 Sep 2021 06:33:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=A31aJO/5YcdUocsEcyn0bhc0bNHd+7HvWCL+8pVGDDU=; b=XXnHlbsVJeiz43Y3LESLsOdS/m8OXgkzBDvNRuXaOhzIFk9XPGFB8+4fzF+fhcPttK FvPwPmNgxuEnz6VX/pugMXfkccU1NnwbfTphH095zmWsunddDBDkNpBwv0V6s+OvfSzw oHQOgUsamKJGEUduN/kILiR81SKXt0x7/e7DUk55aAFS+TH1KIz3NoJsw1cXsVNhgXL7 RUkPzrz2CYT8e+24iQOzYwtNzVSKtcauNmzjGdxTocSiSIJ9HlrP9Ke2CSkTPRxCPCUK o9AyIB91PX/qD/ilB+5C7p1rcqcTBgGtp8O3JY68Tf3s61h1FgmkmmUG1rxJe5oz4d0U Xs3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=A31aJO/5YcdUocsEcyn0bhc0bNHd+7HvWCL+8pVGDDU=; b=ZPN8UfPg+is3Mixj1JxQUIgvFd0MW50BptxxDho25sbz25gvMhTeGzmBdbyH8bgA/2 taPP0QQjv8qF9x19qINoJ2/OCAiM/frhP5a9Mn6+MOp9N4rRfCmdKX5vJz89XLDgE4eK 5VqnMYqTIbXxgiXl1zvVRC9ejW4DybChUvG1btqZvlQvZwVEmPC/7KMOfsEI6yTUQXnn WUnGT6HwZ8pMd/gZeK3H+A3+ClQJTSEH7SRmyiqtYO6FS3ENVvfo0XWE37gko2/D21t9 gTO8dnb31oKGhcOGEUWHcUYm5/QqfdXnb3oGAbecK+FKiCoRNHvr0AfBfJSvZL7nBu+2 JR0A== X-Gm-Message-State: AOAM533OlL0BRGROZroKJ6HBuwtFIrgkBUDh473NwacmK4nN6jWwflvF uIK7SOwzuKl2ZMvdHq2hKc9zvA== X-Google-Smtp-Source: ABdhPJxs/pQcAS2zvnJ16CTjs9g477Rs5JMYYC8B5kkiiA0dn7lD3oQ/W7AtqrHOuibodbiz+oZI3Q== X-Received: by 2002:a1c:2351:: with SMTP id j78mr4690686wmj.40.1632231203097; Tue, 21 Sep 2021 06:33:23 -0700 (PDT) Received: from google.com ([95.148.6.233]) by smtp.gmail.com with ESMTPSA id g1sm4434940wmk.2.2021.09.21.06.33.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Sep 2021 06:33:22 -0700 (PDT) Date: Tue, 21 Sep 2021 14:33:20 +0100 From: Lee Jones To: Marek Vasut Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, Noralf =?iso-8859-1?Q?Tr=F8nnes?= , Daniel Thompson , stable@vger.kernel.org, Meghana Madhyastha , Sean Paul , Thierry Reding , Sam Ravnborg Subject: Re: [PATCH V2] video: backlight: Drop maximum brightness override for brightness zero Message-ID: References: <20210713191633.121317-1-marex@denx.de> <072e01b7-8554-de4f-046a-da11af3958d6@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <072e01b7-8554-de4f-046a-da11af3958d6@denx.de> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Sat, 11 Sep 2021, Marek Vasut wrote: > On 7/13/21 9:16 PM, Marek Vasut wrote: > > The note in c2adda27d202f ("video: backlight: Add of_find_backlight helper > > in backlight.c") says that gpio-backlight uses brightness as power state. > > This has been fixed since in ec665b756e6f7 ("backlight: gpio-backlight: > > Correct initial power state handling") and other backlight drivers do not > > require this workaround. Drop the workaround. > > > > This fixes the case where e.g. pwm-backlight can perfectly well be set to > > brightness 0 on boot in DT, which without this patch leads to the display > > brightness to be max instead of off. > > > > Fixes: c2adda27d202f ("video: backlight: Add of_find_backlight helper in backlight.c") > > Acked-by: Noralf Trønnes > > Reviewed-by: Daniel Thompson > > Cc: # 5.4+ > > Cc: # 4.19.x: ec665b756e6f7: backlight: gpio-backlight: Correct initial power state handling > > Signed-off-by: Marek Vasut > > Cc: Daniel Thompson > > Cc: Meghana Madhyastha > > Cc: Noralf Trønnes > > Cc: Sean Paul > > Cc: Thierry Reding > > --- > > V2: Add AB/RB, CC stable > > --- > > drivers/video/backlight/backlight.c | 6 ------ > > 1 file changed, 6 deletions(-) > > > > diff --git a/drivers/video/backlight/backlight.c b/drivers/video/backlight/backlight.c > > index 537fe1b376ad7..fc990e576340b 100644 > > --- a/drivers/video/backlight/backlight.c > > +++ b/drivers/video/backlight/backlight.c > > @@ -688,12 +688,6 @@ static struct backlight_device *of_find_backlight(struct device *dev) > > of_node_put(np); > > if (!bd) > > return ERR_PTR(-EPROBE_DEFER); > > - /* > > - * Note: gpio_backlight uses brightness as > > - * power state during probe > > - */ > > - if (!bd->props.brightness) > > - bd->props.brightness = bd->props.max_brightness; > > } > > } > > > > Any news on this ? > > Expanding CC list. Looks like I was left off of the original submission. I can't apply a quoted patch. Please re-submit. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog