From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D799C433EF for ; Tue, 21 Sep 2021 14:07:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 32B0A60FE8 for ; Tue, 21 Sep 2021 14:07:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 32B0A60FE8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/Zs4qX4tZr6qhfDPHDor67/nrnJpo1fy1f3a6F1MdNs=; b=B1C7QYVGOWkzMr 2Jh4M8C6B+gUTJrOh+Cqmr8VOuclPrTRCD8u2iqDuKEYh0wVGZqnHq0zv2+LKPgAkdAxsB74idJaC 6Oz2NXbc2b1GZ+NWhUixWlBZspKfe/nT14E2K5OujjOW9t5hWRfi3olxNG5lNb+7Bi/KuZSaTsNl8 N3+WP4PoN6rjjkD6Bl+uH3G4WEsPHwVaIxI5QzRuHS6USDVWSUtla+BHUtZJj0rGilu4T7WPG5/Fc hIFwogyEH87IKs+sMoFQnirBPtq//NkYdrC5GptD0LbSdLDhlrDHNE6dnOR7KRRu2Tmm8VW5R4VPX f7lbM3BU1fPkrBpQ2zJw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSgNh-004jWs-Km; Tue, 21 Sep 2021 14:04:21 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSgNd-004jCb-Mh for linux-arm-kernel@lists.infradead.org; Tue, 21 Sep 2021 14:04:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=9D4uc41C/RV9UrjukvjjJcbQz0YnEsDo/nRHIhLJq7Y=; b=14JnS5i+aRwW1wOH2IWjgMqPiE MVSd13sJemjg7qA8j6xUJ75uRy7Crw8/1rz9PpJyy8hgRGzTgJ2k90anEDbTT2o408bzpiNtD3vg0 pgJftODHqUzOi0ye+MjdBRYtyJAo011MtWTf3SXBEWsInnTA5eR7GkYsB8r/hSlWV+a468NPjsWvc obpFf4lCIn6/PJ6q/V3qSr42Stb8JHB635Udb683P8kRkRS1y4MZNCTsFez1e6a2MMN6Z1gsWmhVe eOMbu21ocNsn1ofT2WEltFmAXFhWhxBy7/IpE13lfqW2MKACkpG+6KUQjuocZJgXE3AK2ROqoz6Kn GImaXu3A==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:54706) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mSgLb-0002i8-Df; Tue, 21 Sep 2021 15:02:11 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1mSgLa-0003Im-1l; Tue, 21 Sep 2021 15:02:10 +0100 Date: Tue, 21 Sep 2021 15:02:10 +0100 From: "Russell King (Oracle)" To: Ard Biesheuvel Cc: linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Kees Cook , Keith Packard , Linus Walleij Subject: Re: [PATCH 01/10] ARM: fix incorrect use of get_kernel_nofault() Message-ID: References: <20210921095408.133210-1-ardb@kernel.org> <20210921095408.133210-2-ardb@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210921095408.133210-2-ardb@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210921_070417_786415_AF3C5D79 X-CRM114-Status: GOOD ( 13.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 21, 2021 at 11:53:59AM +0200, Ard Biesheuvel wrote: > Commit 344179fc7ef4 ("ARM: 9106/1: traps: use get_kernel_nofault instead > of set_fs()") replaced an occurrence of __get_user() with > get_kernel_nofault(), but inverted the sense of the conditional in the > process, resulting in no values to be printed at all. > > I.e., every exception stack now looks like this: > > Exception stack(0xc18d1fb0 to 0xc18d1ff8) > 1fa0: ???????? ???????? ???????? ???????? > 1fc0: ???????? ???????? ???????? ???????? ???????? ???????? ???????? ???????? > 1fe0: ???????? ???????? ???????? ???????? ???????? ???????? > > which is rather unhelpful. > > Fixes: 344179fc7ef4 ("ARM: 9106/1: traps: use get_kernel_nofault instead of set_fs()") > Signed-off-by: Ard Biesheuvel This is definitely a bug fix to one of the previous series, and should be independent of the rest of the series. Please put it in the patch system, thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel