From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEC10C433EF for ; Tue, 21 Sep 2021 14:53:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A8FFB60FC1 for ; Tue, 21 Sep 2021 14:53:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233768AbhIUOzE (ORCPT ); Tue, 21 Sep 2021 10:55:04 -0400 Received: from cloud.peff.net ([104.130.231.41]:51756 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233765AbhIUOzD (ORCPT ); Tue, 21 Sep 2021 10:55:03 -0400 Received: (qmail 5790 invoked by uid 109); 21 Sep 2021 14:53:35 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Tue, 21 Sep 2021 14:53:35 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 1159 invoked by uid 111); 21 Sep 2021 14:53:34 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Tue, 21 Sep 2021 10:53:34 -0400 Authentication-Results: peff.net; auth=none Date: Tue, 21 Sep 2021 10:53:34 -0400 From: Jeff King To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Junio C Hamano , Hamza Mahfooz , Taylor Blau Subject: Re: [PATCH 6/5] grep.c: mark eol/bol and derived as "const char * const" Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Sep 21, 2021 at 02:45:16PM +0200, Ævar Arnfjörð Bjarmason wrote: > I think that generally git's codebase could use going beyond just > "const char *" when a "const char * const" would suffice, for some > reason we seem to mostly use it for the static usage variables. I didn't dig up the references in the list archive, but I feel like we've had this discussion long ago. One of the reasons not to do so is that it pollutes the function's interface with internal details. The caller does not care whether the function is going to modify the pointer itself, because it is passed by value. You could apply the same logic that we should be passing "const int", and so on. -Peff