From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02D30C433EF for ; Wed, 22 Sep 2021 23:19:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D854660EE4 for ; Wed, 22 Sep 2021 23:19:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238442AbhIVXVF (ORCPT ); Wed, 22 Sep 2021 19:21:05 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:60502 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231259AbhIVXVE (ORCPT ); Wed, 22 Sep 2021 19:21:04 -0400 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 32273E52; Thu, 23 Sep 2021 01:19:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1632352772; bh=lirq6R1zilU8AH/ITqGiM3d1OMtteL95cTbYnXKaqJ0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jEJ2khWXsYpOfWVDgNgPUyMJ05r0aPjPLP8ScOFN0EjH9xBVdAzabLz1IOgPt+eub Bs521dGOj1sLg+Uas50hOHExvx3xL3zu4UFs3s+WqDQEyJeu8NZEF9yVSZRYlTrkua x77yV54rQmWCTzmHfw1zXrsq16B9y1O/YdACPSKI= Date: Thu, 23 Sep 2021 02:19:30 +0300 From: Laurent Pinchart To: Cai Huoqing Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/bridge: dw-hdmi-cec: Make use of the helper function devm_add_action_or_reset() Message-ID: References: <20210922125909.215-1-caihuoqing@baidu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210922125909.215-1-caihuoqing@baidu.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Cai, Thank you for the patch. On Wed, Sep 22, 2021 at 08:59:08PM +0800, Cai Huoqing wrote: > The helper function devm_add_action_or_reset() will internally > call devm_add_action(), and if devm_add_action() fails then it will > execute the action mentioned and return the error code. So > use devm_add_action_or_reset() instead of devm_add_action() > to simplify the error handling, reduce the code. > > Signed-off-by: Cai Huoqing Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c > index 70ab4fbdc23e..c8f44bcb298a 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c > @@ -265,11 +265,9 @@ static int dw_hdmi_cec_probe(struct platform_device *pdev) > /* override the module pointer */ > cec->adap->owner = THIS_MODULE; > > - ret = devm_add_action(&pdev->dev, dw_hdmi_cec_del, cec); > - if (ret) { > - cec_delete_adapter(cec->adap); > + ret = devm_add_action_or_reset(&pdev->dev, dw_hdmi_cec_del, cec); > + if (ret) > return ret; > - } > > ret = devm_request_threaded_irq(&pdev->dev, cec->irq, > dw_hdmi_cec_hardirq, -- Regards, Laurent Pinchart