From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D270C433F5 for ; Wed, 22 Sep 2021 21:22:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2AD5E6112F for ; Wed, 22 Sep 2021 21:22:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237946AbhIVVYC (ORCPT ); Wed, 22 Sep 2021 17:24:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237770AbhIVVYC (ORCPT ); Wed, 22 Sep 2021 17:24:02 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74882C061574 for ; Wed, 22 Sep 2021 14:22:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=KsnryHZvsewJwHxjPAMINXkoQOX1qMUhXwLNx58bPXc=; b=W50S8D3t0cKoMD/S5QDCYwtnES /SUmxsmhnFnOKX5l5PdY5m3t36eMFNieCk+RgsoMkoAS6+/48XRDs8c3mR6QBrLQZ3OlLzq1oSdTw N1VRCA7bif06Xna9g+4c6ucX+yo9FfobVzRgveijCbW4kH5SIWO9wCAq4k07cOo5qx0lABFGjrf69 RGQrHcHlxSJm779csKbm4htFw1I6M4sjIXuk1dCMbllIplo2/qPoO3tM27worqZ+/jW78myJ93UFP 6e74ub6T1xQLjAFL++EH3+4gFyfjxKQvtf3GRY4oX3E1pUr1nABulexX5tMGUXvwSdk+DesMpEf8u MuRM4ltw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:54742) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mT9hB-0004MB-Nu; Wed, 22 Sep 2021 22:22:25 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1mT9h5-0004aC-Jw; Wed, 22 Sep 2021 22:22:19 +0100 Date: Wed, 22 Sep 2021 22:22:19 +0100 From: "Russell King (Oracle)" To: Vladimir Oltean Cc: netdev@vger.kernel.org, Antoine Tenart , Michael Walle , Heiner Kallweit , Andrew Lunn , Florian Fainelli , Ioana Ciornei , Maxim Kochetkov , Bjarni Jonasson , Steen Hegelund , UNGLinuxDriver@microchip.com, bcm-kernel-feedback-list@broadcom.com, Nicolas Ferre , Claudiu Beznea Subject: Re: [RFC PATCH v3 net-next 2/6] net: phylink: introduce a generic method for querying PHY in-band autoneg capability Message-ID: References: <20210922181446.2677089-1-vladimir.oltean@nxp.com> <20210922181446.2677089-3-vladimir.oltean@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210922181446.2677089-3-vladimir.oltean@nxp.com> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Sep 22, 2021 at 09:14:42PM +0300, Vladimir Oltean wrote: > +static unsigned int phylink_fixup_inband_aneg(struct phylink *pl, > + struct phy_device *phy, > + unsigned int mode) > +{ > + int ret; > + > + ret = phy_validate_inband_aneg(phy, pl->link_interface); > + if (ret == PHY_INBAND_ANEG_UNKNOWN) { > + phylink_dbg(pl, > + "PHY driver does not report in-band autoneg capability, assuming %s\n", > + phylink_autoneg_inband(mode) ? "true" : "false"); > + > + return mode; > + } > + > + if (phylink_autoneg_inband(mode) && !(ret & PHY_INBAND_ANEG_ON)) { > + phylink_err(pl, > + "Requested in-band autoneg but driver does not support this, disabling it.\n"); If we add support to the BCM84881 driver to work with phy_validate_inband_aneg(), then this will always return PHY_INBAND_ANEG_OFF and never PHY_INBAND_ANEG_ON. Consequently, this will always produce this "error". It is not an error in the SFP case, but it is if firmware is misconfigured. So, this needs better handling - we should not be issuing an error- level kernel message for something that is "normal". -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!