From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABF8EC433F5 for ; Thu, 23 Sep 2021 08:19:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8CD9561248 for ; Thu, 23 Sep 2021 08:19:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239861AbhIWIVB (ORCPT ); Thu, 23 Sep 2021 04:21:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237996AbhIWIVA (ORCPT ); Thu, 23 Sep 2021 04:21:00 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC214C061574 for ; Thu, 23 Sep 2021 01:19:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ao4ccLwyooufgrmk2CojZeNgKOy5V8GBM4YWvOAJKUM=; b=KCbXGLZVRx/0U40LJxg8X6WUaw Ng53BaekUXu5RMEz6j4DHrm9QPCKeJOyAfIjvtCM7spa8m/k8uEpYN+QiP+3blwaE2aPQnG5Fn3zy JwUcziyDj/r2lNDkfLV7Xe9rVZvxHU1deWmPTIjl7kXguxqD8jz+03iWAs2+FpqTHEQotY4SWPLAt ZfOxHRQq33QjFs/QsEGB7ZiqRMAV7AGAe6dJVxgCSpAH9HmUBbDQdgSO3BFqlqtzcdrLgSEk231Zf Wg3MOYyNXPHObeCL+LIENwpE0D68c0W0dsnwx04v6dhg1/NxJxprSBEqysBt5ug7D11xFVirnOho7 a+bW3J1w==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:54750) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mTJwx-0004lA-IZ; Thu, 23 Sep 2021 09:19:23 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1mTJwv-000553-6G; Thu, 23 Sep 2021 09:19:21 +0100 Date: Thu, 23 Sep 2021 09:19:21 +0100 From: "Russell King (Oracle)" To: Vladimir Oltean Cc: "netdev@vger.kernel.org" , Antoine Tenart , Michael Walle , Heiner Kallweit , Andrew Lunn , Florian Fainelli , Ioana Ciornei , Maxim Kochetkov , Bjarni Jonasson , Steen Hegelund , "UNGLinuxDriver@microchip.com" , "bcm-kernel-feedback-list@broadcom.com" , Nicolas Ferre , Claudiu Beznea Subject: Re: [RFC PATCH v3 net-next 2/6] net: phylink: introduce a generic method for querying PHY in-band autoneg capability Message-ID: References: <20210922181446.2677089-1-vladimir.oltean@nxp.com> <20210922181446.2677089-3-vladimir.oltean@nxp.com> <20210922213116.7wlvnjfeqjltiecs@skbuf> <20210922214827.wczsgk3yw3vjsv5w@skbuf> <20210922235033.hoz4rbx2eid6snyc@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210922235033.hoz4rbx2eid6snyc@skbuf> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Sep 22, 2021 at 11:50:34PM +0000, Vladimir Oltean wrote: > On Thu, Sep 23, 2021 at 12:03:22AM +0100, Russell King (Oracle) wrote: > > On Wed, Sep 22, 2021 at 09:48:28PM +0000, Vladimir Oltean wrote: > > > On Thu, Sep 23, 2021 at 12:31:16AM +0300, Vladimir Oltean wrote: > > > > On Wed, Sep 22, 2021 at 10:22:19PM +0100, Russell King (Oracle) wrote: > > > > > On Wed, Sep 22, 2021 at 09:14:42PM +0300, Vladimir Oltean wrote: > > > > > > +static unsigned int phylink_fixup_inband_aneg(struct phylink *pl, > > > > > > + struct phy_device *phy, > > > > > > + unsigned int mode) > > > > > > +{ > > > > > > + int ret; > > > > > > + > > > > > > + ret = phy_validate_inband_aneg(phy, pl->link_interface); > > > > > > + if (ret == PHY_INBAND_ANEG_UNKNOWN) { > > > > > > + phylink_dbg(pl, > > > > > > + "PHY driver does not report in-band autoneg capability, assuming %s\n", > > > > > > + phylink_autoneg_inband(mode) ? "true" : "false"); > > > > > > + > > > > > > + return mode; > > > > > > + } > > > > > > + > > > > > > + if (phylink_autoneg_inband(mode) && !(ret & PHY_INBAND_ANEG_ON)) { > > > > > > + phylink_err(pl, > > > > > > + "Requested in-band autoneg but driver does not support this, disabling it.\n"); > > > > > > > > > > If we add support to the BCM84881 driver to work with > > > > > phy_validate_inband_aneg(), then this will always return > > > > > PHY_INBAND_ANEG_OFF and never PHY_INBAND_ANEG_ON. Consequently, > > > > > this will always produce this "error". It is not an error in the > > > > > SFP case, but it is if firmware is misconfigured. > > > > > > > > > > So, this needs better handling - we should not be issuing an error- > > > > > level kernel message for something that is "normal". > > > > > > > > Is this better? > > > > > > > > phylink_printk(phy_on_sfp(phy) ? KERN_DEBUG : KERN_ERR, pl, > > > > "Requested in-band autoneg but driver does not support this, disabling it.\n"); > > > > > > Ah, not sure whether that was a trick question or not, but > > > phylink_fixup_inband_aneg function does not get called for the SFP code > > > path, I even noted this in the commit message but forgot: > > > > No it wasn't a trick question. I thought you were calling > > phylink_fixup_inband_aneg() from phylink_sfp_config(), but I see now > > that you don't. That's what happens when you try and rush to review. > > How did I "rush to review" exactly? I waited for 24 days since the v2 > for even a single review comment, with even a ping in between, before > resending the series largely unaltered, just with an extra patch appended. FFS. Are you intentionally trying to misinterpret everything I say? Who here is doing a review? You or me? "That's what happens when you try and rush to review." is a form of speech - clearly the "you" is not aimed at you Vladimir, but me. Let's put this a different way. I am blaming myself for rushing to review this last night. Is that more clear for you? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!