From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B22F1C433EF for ; Thu, 23 Sep 2021 21:37:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9498F61019 for ; Thu, 23 Sep 2021 21:37:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243343AbhIWViy (ORCPT ); Thu, 23 Sep 2021 17:38:54 -0400 Received: from mail-ot1-f43.google.com ([209.85.210.43]:39615 "EHLO mail-ot1-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243232AbhIWViv (ORCPT ); Thu, 23 Sep 2021 17:38:51 -0400 Received: by mail-ot1-f43.google.com with SMTP id j11-20020a9d190b000000b00546fac94456so10487347ota.6; Thu, 23 Sep 2021 14:37:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=hbjFCOlJlbx4SbaGurKbZs2byZ6bHJqMjwDwtqafseo=; b=FlLKG9X+eqjM7P9iLB+tI6i0KXrlSf+XjUs0PhprNvY1faNiVQcmkz8kebju821Jai W76nJaQdBinXWH8DQKRQlYHB7hMTWqy0lwMIC2A+/uzkg0JxLxXo75A52Ga3JA6oKFJ3 pdiPEqxy+YU1n3nyLM08RZ2VrXSVZG0TLaoagTX337/uJoK29r542X/2GZHEnFvzlxeW AL/LHDVTqMIj6mTZx/PDA2gkeeKfFuvcJGbtgwusmpnpFKKYhBEEze/BtuetA+Mj3g1I zQRAGpS9KjOs3yXvmXfLhka5xICQjAiLdqI1dOO/KnurPcqk7PX4ylG8AJOrpVa4Dp8v 2xWQ== X-Gm-Message-State: AOAM533MXikHI8IF9DIDa15i1NsOlAuAvHdaiRcXtfM7KGdjRWAY/CJd wnjTtq7VulfxBYJLuwiqTA== X-Google-Smtp-Source: ABdhPJw9O910RBB8A8n+sNR/MsA9Mhom39GmnQpb8UhkS6Adr5dy3tU9MjBf9Q4AZZ6ab2VkDe4ejA== X-Received: by 2002:a9d:615c:: with SMTP id c28mr768898otk.381.1632433039231; Thu, 23 Sep 2021 14:37:19 -0700 (PDT) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id y12sm1536267otu.11.2021.09.23.14.37.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Sep 2021 14:37:18 -0700 (PDT) Received: (nullmailer pid 3568677 invoked by uid 1000); Thu, 23 Sep 2021 21:37:17 -0000 Date: Thu, 23 Sep 2021 16:37:17 -0500 From: Rob Herring To: Oskar Senft Cc: Jean Delvare , Guenter Roeck , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2 1/2] dt-bindings: hwmon: Add nct7802 bindings Message-ID: References: <20210921004627.2786132-1-osk@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210921004627.2786132-1-osk@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org On Mon, Sep 20, 2021 at 08:46:26PM -0400, Oskar Senft wrote: > Document bindings for the Nuvoton NCT7802Y driver. > > Signed-off-by: Oskar Senft > --- > .../bindings/hwmon/nuvoton,nct7802.yaml | 92 +++++++++++++++++++ > 1 file changed, 92 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/nuvoton,nct7802.yaml > > diff --git a/Documentation/devicetree/bindings/hwmon/nuvoton,nct7802.yaml b/Documentation/devicetree/bindings/hwmon/nuvoton,nct7802.yaml > new file mode 100644 > index 000000000000..7512acbc9d1a > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/nuvoton,nct7802.yaml > @@ -0,0 +1,92 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > + > +$id: http://devicetree.org/schemas/hwmon/nuvoton,nct7802.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Nuvoton NCT7802Y Hardware Monitoring IC > + > +maintainers: > + - Guenter Roeck Should be someone that cares about this h/w, not who applies patches. > + > +description: | > + The NCT7802Y is a hardware monitor IC which supports one on-die and up to > + 5 remote temperature sensors with SMBus interface. > + > + Datasheets: > + https://www.nuvoton.com/export/resource-files/Nuvoton_NCT7802Y_Datasheet_V12.pdf > + > +properties: > + compatible: > + enum: > + - nuvoton,nct7802 > + > + reg: > + maxItems: 1 > + > + temperature-sensors: > + type: object > + description: > + | Drop. Not needed if formatting is not needed to be maintained. (Also belongs on the prior line.) > + Configuration for temperature sensors. If temperature-sensors > + is not provided at all, the internal temperature sensor will be > + enabled. If temperature-sensors is provided, only the listed > + sensors will be configured as specified. The runtime configuration > + for un-listed sensors will not be touched in the chip. This allows > + sensors to be configured at power-up time from an EEPROM connected > + to the chip and at the sime time allows to override these settings > + using device tree configuration. > + > + properties: > + ltd: > + type: object > + description: Internal Temperature Sensor ("LTD") No child properties? > + > + rtd3: > + type: object > + description: > + | > + Remote Temperature Sensor ("RTD3"). This sensor only supports > + thermistor mode. No child properties? > + > + patternProperties: > + "^rtd[1-2]$": > + type: object > + description: Remote Temperature Sensor ("RTDx") > + properties: > + "type": Don't need quotes. > + description: Sensor type (3=thermal diode, 4=thermistor). 2nd time I've seen this property this week[1]. Needs to be more specific than just 'type'. > + allOf: Don't need allOf. > + - $ref: "http://devicetree.org/schemas/types.yaml#/definitions/uint32" > + - items: > + - enum: [ 3, 4 ] > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + nct7802@28 { > + compatible = "nuvoton,nct7802"; > + reg = <0x28>; > + > + temperature-sensors { > + ltd { > + status = "disabled"; Don't show status in examples. > + }; > + > + rtd1 { > + status = "okay"; > + type = <4> /* thermistor */; > + }; > + }; > + }; > + }; > -- [1] https://lore.kernel.org/all/CAL_Jsq+NXuF+F7OE3vyEbTUj6sxyMHVWHXbCuPPoFaKjpyZREQ@mail.gmail.com/