From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11FCBC433EF for ; Wed, 6 Oct 2021 04:12:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D997A6109D for ; Wed, 6 Oct 2021 04:12:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230429AbhJFEOR (ORCPT ); Wed, 6 Oct 2021 00:14:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230330AbhJFEON (ORCPT ); Wed, 6 Oct 2021 00:14:13 -0400 Received: from mail-ot1-x335.google.com (mail-ot1-x335.google.com [IPv6:2607:f8b0:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0B4AC061753 for ; Tue, 5 Oct 2021 21:12:21 -0700 (PDT) Received: by mail-ot1-x335.google.com with SMTP id j11-20020a9d190b000000b00546fac94456so1525306ota.6 for ; Tue, 05 Oct 2021 21:12:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=JeqQPQlkPMyybH7Ylv9LL4C+2+30wYTv9mWLfCOyW68=; b=XEjeIZfNuBmJTMi6wtAtetYggf2aHs3GPhHg1KwJz1egGXL5njhCRw3DDPgbsH7cJv OUWOA1oOvi2LLIVGnWT3wGH+TmJA95TyM0M6gC2kao6MWJu+bZzC5cnO84s06z3CI1AA XVvMCCFyDHcpCO8U8QelLmZi7fD9CRI8OYcPo6qSRxfBbT/AxB2YjYAxUJ6hV57S0w7A tv9MugLiCri9LD2ijJPmIfSvtHSZYv6q8bsMiyIMxl6jokP6DoYrt1m4hdtVohghtVTl EEr+bbftzq4eN6V4Bov3juUBbxPCEkxk4V/sQTSbb+6ENfzMeMK65PcTxz1DE8SImzIX +iKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=JeqQPQlkPMyybH7Ylv9LL4C+2+30wYTv9mWLfCOyW68=; b=0FFfREidn8lg1/lBcKJhKhPzohdP7hHANn2w/rbmFM0b8U03sAJl7UOgkYjAUyfsnj mcT6+qjgp9W8IDnxL9vgP5VtCdJciieYdEbH41uPVH6B+HAhoTY6gmtrGTlCv+1dgVBB JEstiYqc7qq8iUFCorXNbJJX49wFOLUw/pTuPcWAc9SUvowWn53iiliFz9v+bMoCoeLm tm9aHYB4DL7IMa57jOWoYfsvElCTTbeCtIn8DENP/JZqI5gA9rTeRQ4ynfQ7p5e+r0b7 IoWkIDjduP0g7qbCPBdGw9VIW/yi2hHsNgpchV/RcfpjL2ILLyEjc7ExqU4WqfeIh3UZ RyoA== X-Gm-Message-State: AOAM530upPUDNTZ+CUxou9yaqGBP/ImEjO7FV/QmjAFBvFT4sg6W3Eue v/IKEkrMMDNl2Dop0RCOAbcAQA== X-Google-Smtp-Source: ABdhPJx/5egmLBcK43fNwucfO1oEx4RaFxVzQH0A8+50zHcH+LenRxckCdmVbnSpKpPJhWTVbKHZbA== X-Received: by 2002:a9d:12c8:: with SMTP id g66mr276609otg.7.1633493541062; Tue, 05 Oct 2021 21:12:21 -0700 (PDT) Received: from yoga ([2600:1700:a0:3dc8:c84c:8eff:fe1e:256f]) by smtp.gmail.com with ESMTPSA id u12sm4009329otq.20.2021.10.05.21.12.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Oct 2021 21:12:20 -0700 (PDT) Date: Tue, 5 Oct 2021 23:12:18 -0500 From: Bjorn Andersson To: Matthias Kaehlcke Cc: Pavel Machek , Rob Herring , Andy Gross , Thierry Reding , Uwe Kleine-K?nig , Lee Jones , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-pwm@vger.kernel.org, Marijn Suijten , Yassine Oudjana , Luca Weiss , Subbaraman Narayanamurthy Subject: Re: [PATCH v9 1/2] dt-bindings: leds: Add Qualcomm Light Pulse Generator binding Message-ID: References: <20210623035039.772660-1-bjorn.andersson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Thu 09 Sep 10:18 CDT 2021, Matthias Kaehlcke wrote: > On Tue, Jun 22, 2021 at 08:50:38PM -0700, Bjorn Andersson wrote: [..] > > + - | > > + #include > > + > > + lpg { > > + compatible = "qcom,pmi8994-lpg"; > > + > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + qcom,power-source = <1>; > > + > > + multi-led { > > + color = ; > > + function = LED_FUNCTION_STATUS; > > + > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + led@1 { > > + reg = <1>; > > + color = ; > > + }; > > + > > + led@2 { > > + reg = <2>; > > + color = ; > > + }; > > + > > + led@3 { > > + reg = <3>; > > + color = ; > > + }; > > + }; > > + }; > > + - | > > + lpg { > > nit: should the node be named 'lpg-pwm'? > > IIUC a PMIC .dtsi could have both a 'lpg' and a 'lpg-pwm' node, even though > only one of them can be enabled at any time. > No, there's only the one "LPG", with N channels. The lpg exposes a pwm chip and the child nodes may describe LEDs connected to the channels. So this example is the configuration where there's no LEDs attached. The compatible is "pwm", because the PM8916 lacks the pattern and RGB blocks that makes up the LPG - and is hence named "PWM" in the datasheet instead. So perhaps the example should be generically named "pwm" instead. In all other PMICs I know of the hardware block is named "lpg". Regards, Bjorn > > + compatible = "qcom,pm8916-pwm"; > > + #pwm-cells = <2>; > > + };