From: Andrew Lunn <andrew@lunn.ch>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, gregkh@linuxfoundation.org,
rafael@kernel.org, saravanak@google.com, mw@semihalf.com,
jeremy.linton@arm.com
Subject: Re: [RFC] fwnode: change the return type of mac address helpers
Date: Wed, 6 Oct 2021 16:49:36 +0200 [thread overview]
Message-ID: <YV23gINkk3b9m6tb@lunn.ch> (raw)
In-Reply-To: <20211006022444.3155482-1-kuba@kernel.org>
> --- a/drivers/net/ethernet/apm/xgene-v2/main.c
> +++ b/drivers/net/ethernet/apm/xgene-v2/main.c
> @@ -36,7 +36,7 @@ static int xge_get_resources(struct xge_pdata *pdata)
> return -ENOMEM;
> }
>
> - if (!device_get_ethdev_addr(dev, ndev))
> + if (device_get_ethdev_addr(dev, ndev))
> eth_hw_addr_random(ndev);
That is going to be interesting for out of tree drivers.
Otherwise, this looks O.K.
Andrew
next prev parent reply other threads:[~2021-10-06 14:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-06 2:24 [RFC] fwnode: change the return type of mac address helpers Jakub Kicinski
2021-10-06 14:49 ` Andrew Lunn [this message]
2021-10-06 15:49 ` Jakub Kicinski
2021-10-06 16:55 ` Shannon Nelson
2021-10-06 17:49 ` Jakub Kicinski
2021-10-06 18:13 ` Shannon Nelson
2021-10-06 15:23 ` Marcin Wojtas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YV23gINkk3b9m6tb@lunn.ch \
--to=andrew@lunn.ch \
--cc=gregkh@linuxfoundation.org \
--cc=jeremy.linton@arm.com \
--cc=kuba@kernel.org \
--cc=mw@semihalf.com \
--cc=netdev@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.