From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 073A2C433F5 for ; Wed, 6 Oct 2021 14:26:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DE3F6610A3 for ; Wed, 6 Oct 2021 14:26:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239005AbhJFO2e (ORCPT ); Wed, 6 Oct 2021 10:28:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238875AbhJFO2c (ORCPT ); Wed, 6 Oct 2021 10:28:32 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99A7CC061749 for ; Wed, 6 Oct 2021 07:26:40 -0700 (PDT) Received: from zn.tnic (p200300ec2f0d3600bd612f435519a27c.dip0.t-ipconnect.de [IPv6:2003:ec:2f0d:3600:bd61:2f43:5519:a27c]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 2DE4A1EC0298; Wed, 6 Oct 2021 16:26:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1633530399; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=c8HncWWjkOCJNcpjE65wOxQUt6zKO4hMGVTQYopo1WA=; b=Jxm0jSgA1kXDGfU8E47pMjxPbBEAEcwhGDbMaVK6xXqoBuHo0g0+wZliN9SfAaNjIqCch+ ClMv885IY4Wt8sjnmfunh1w8z2l814pjsgc2RB7BHnLWWN/TDDpUpN+k7nWJ60HVG/2c9M u0yLCuBeAiUJO5TGXN5l2zvJFwJWFok= Date: Wed, 6 Oct 2021 16:26:33 +0200 From: Borislav Petkov To: Josh Poimboeuf Cc: "Kuppuswamy, Sathyanarayanan" , Thomas Gleixner , Ingo Molnar , x86@kernel.org, Paolo Bonzini , David Hildenbrand , Andrea Arcangeli , Juergen Gross , Deep Shah , VMware Inc , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Peter H Anvin , Dave Hansen , Tony Luck , Dan Williams , Andi Kleen , Kirill Shutemov , Sean Christopherson , Kuppuswamy Sathyanarayanan , linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 03/11] x86/cpufeatures: Add TDX Guest CPU feature Message-ID: References: <20211005025205.1784480-1-sathyanarayanan.kuppuswamy@linux.intel.com> <20211005025205.1784480-4-sathyanarayanan.kuppuswamy@linux.intel.com> <20211005210423.yfftpxxmj3cjprtv@treble> <15a07997-2659-6be1-b8a3-da57e72562b5@linux.intel.com> <20211006034218.ynamwigsvpgad7sr@treble> <20211006050309.ldn5myznmpurnomm@treble> <20211006141105.offh3fqhyupzqs7v@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20211006141105.offh3fqhyupzqs7v@treble> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 06, 2021 at 07:11:05AM -0700, Josh Poimboeuf wrote: > Ok. At least it sounds like cc_platform_has() needs a comment stating > that caps can't be relied on, and why. I thought about turning the hunk here: https://lkml.kernel.org/r/YVL4ZUGhfsh1QfRX@zn.tnic into a patch. But since we won't be using caps there, it would look weird so I guess a comment's fine. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette