From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C557DC433EF for ; Wed, 6 Oct 2021 15:49:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A4D5B610A3 for ; Wed, 6 Oct 2021 15:49:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239263AbhJFPu5 (ORCPT ); Wed, 6 Oct 2021 11:50:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:36710 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230021AbhJFPuv (ORCPT ); Wed, 6 Oct 2021 11:50:51 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0876561058; Wed, 6 Oct 2021 15:48:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633535339; bh=47gQvTqBUwVekDVQzpGg9z1YxiQhRhuibQ0ZZS8DDms=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GROolJw06y0WPU8RbKw/7NqgAV4KoLfBV8lLaFc2FmLRCleim5MTMGzrKWQZg1AEi SGri5CduGoeqDIboZo6Nj2+jYGQBQ0cu8GyZktrgzSPI9ShBDDzdXoKYOK7j5ZUGta mDo3x7hZjst4piPdrrZFrs0QYmnrKe8MkfQHHmbMCHj+MmT3qnAFZPGAvho2smR87S AZ1wtSI5j27Oj8y/xLh6a5VeD7D+pnqUwT76guGybO4bAmcO4hL9gbJBEsDZhoNegh 7Z9SKrmP3oDzBjACsjGrIFvNECLgfVQgAUPYg6vODyxs9F25tSS3Mj0jIsrR0gnpMd mDJeRcfhSPXng== Date: Wed, 6 Oct 2021 16:48:57 +0100 From: Mark Brown To: Andy Shevchenko Cc: Joe Perches , Pierre-Louis Bossart , Hans de Goede , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Cezary Rojewski , Liam Girdwood , Jie Yang , Jaroslav Kysela , Takashi Iwai Subject: Re: [PATCH v1 2/4] ASoC: Intel: bytcr_rt5640: Use temporary variable for struct device Message-ID: References: <20211006150442.16503-1-andriy.shevchenko@linux.intel.com> <20211006150442.16503-2-andriy.shevchenko@linux.intel.com> <4b81a10dca78e286a9f806464b97111b5a15a91e.camel@perches.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kyawfiakXrTSOOdd" Content-Disposition: inline In-Reply-To: X-Cookie: A is for Apple. Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --kyawfiakXrTSOOdd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Oct 06, 2021 at 06:44:07PM +0300, Andy Shevchenko wrote: > On Wed, Oct 06, 2021 at 08:21:01AM -0700, Joe Perches wrote: > > Some will complain about a lack of commit message. > Yeah, sorry for that, it wasn't deliberate. I forgot to run `git msg-filter` > on these three patches to add it. > Mark, do you want me resend entire bunch(es) or just starting from these > patches? Or...? If you're adding a commit message with automation it's probably not adding any value. --kyawfiakXrTSOOdd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmFdxWgACgkQJNaLcl1U h9Dj6Qf/d4hZFf/MYBhKCyGf2BxUJWrfHkBWX9kcLxCJmVG5Yz2jw9oBQKgq7pZM pYF4EntfZ2RDTGY7/aV7ZmrG8Wk3gYHgaZSzjTYR2KcldtFHTo0VikUbSvArp5HB gPpP2BpyO4k8+O8aNjeGAjKcQ1jBd+Buezd9jELU/IAdoeuJVMkfeI9Fkd/7IzzM 4gJw6b++c9IuaZ1m1Gz33cB6qkSqfiinWcd6sO6wOzJ9gcnYrZBHtKQwsvkf5iZe vP7YN9Yl9yR9ngyPUGegbrk9OX9mUOWUkM0t1Z9SoWrZgq9VoUJ+QWYENo0gkt19 qqIuupXs2MN80/oJeD21JGRJlOIZNA== =MIjN -----END PGP SIGNATURE----- --kyawfiakXrTSOOdd-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EDEFC433F5 for ; Wed, 6 Oct 2021 15:50:02 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 40CBB610E6 for ; Wed, 6 Oct 2021 15:50:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 40CBB610E6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 80982112; Wed, 6 Oct 2021 17:49:09 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 80982112 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1633535399; bh=47gQvTqBUwVekDVQzpGg9z1YxiQhRhuibQ0ZZS8DDms=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=DWUWvz/cSYgEVep7wZpThdGiu0C6urikE+2I0mIhDANalva0XdhE2GqxOgwLaf3cs RLpPuweFrkI3F+TUtDUvS/dFV6COqbh3rDRSpS9Bbx2MSwhA2fRBD9Lj4ItvnAIrNn QoMRkJ6L9gdwdYZdwbkimsrTntIIyzDCeqXpqD7w= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id D849AF80229; Wed, 6 Oct 2021 17:49:08 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 43818F80240; Wed, 6 Oct 2021 17:49:07 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 958C7F8020D for ; Wed, 6 Oct 2021 17:49:03 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 958C7F8020D Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GROolJw0" Received: by mail.kernel.org (Postfix) with ESMTPSA id 0876561058; Wed, 6 Oct 2021 15:48:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633535339; bh=47gQvTqBUwVekDVQzpGg9z1YxiQhRhuibQ0ZZS8DDms=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GROolJw06y0WPU8RbKw/7NqgAV4KoLfBV8lLaFc2FmLRCleim5MTMGzrKWQZg1AEi SGri5CduGoeqDIboZo6Nj2+jYGQBQ0cu8GyZktrgzSPI9ShBDDzdXoKYOK7j5ZUGta mDo3x7hZjst4piPdrrZFrs0QYmnrKe8MkfQHHmbMCHj+MmT3qnAFZPGAvho2smR87S AZ1wtSI5j27Oj8y/xLh6a5VeD7D+pnqUwT76guGybO4bAmcO4hL9gbJBEsDZhoNegh 7Z9SKrmP3oDzBjACsjGrIFvNECLgfVQgAUPYg6vODyxs9F25tSS3Mj0jIsrR0gnpMd mDJeRcfhSPXng== Date: Wed, 6 Oct 2021 16:48:57 +0100 From: Mark Brown To: Andy Shevchenko Subject: Re: [PATCH v1 2/4] ASoC: Intel: bytcr_rt5640: Use temporary variable for struct device Message-ID: References: <20211006150442.16503-1-andriy.shevchenko@linux.intel.com> <20211006150442.16503-2-andriy.shevchenko@linux.intel.com> <4b81a10dca78e286a9f806464b97111b5a15a91e.camel@perches.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kyawfiakXrTSOOdd" Content-Disposition: inline In-Reply-To: X-Cookie: A is for Apple. Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Takashi Iwai , Jie Yang , Cezary Rojewski , Pierre-Louis Bossart , Liam Girdwood , Hans de Goede , Joe Perches X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --kyawfiakXrTSOOdd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Oct 06, 2021 at 06:44:07PM +0300, Andy Shevchenko wrote: > On Wed, Oct 06, 2021 at 08:21:01AM -0700, Joe Perches wrote: > > Some will complain about a lack of commit message. > Yeah, sorry for that, it wasn't deliberate. I forgot to run `git msg-filter` > on these three patches to add it. > Mark, do you want me resend entire bunch(es) or just starting from these > patches? Or...? If you're adding a commit message with automation it's probably not adding any value. --kyawfiakXrTSOOdd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmFdxWgACgkQJNaLcl1U h9Dj6Qf/d4hZFf/MYBhKCyGf2BxUJWrfHkBWX9kcLxCJmVG5Yz2jw9oBQKgq7pZM pYF4EntfZ2RDTGY7/aV7ZmrG8Wk3gYHgaZSzjTYR2KcldtFHTo0VikUbSvArp5HB gPpP2BpyO4k8+O8aNjeGAjKcQ1jBd+Buezd9jELU/IAdoeuJVMkfeI9Fkd/7IzzM 4gJw6b++c9IuaZ1m1Gz33cB6qkSqfiinWcd6sO6wOzJ9gcnYrZBHtKQwsvkf5iZe vP7YN9Yl9yR9ngyPUGegbrk9OX9mUOWUkM0t1Z9SoWrZgq9VoUJ+QWYENo0gkt19 qqIuupXs2MN80/oJeD21JGRJlOIZNA== =MIjN -----END PGP SIGNATURE----- --kyawfiakXrTSOOdd--