From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB95DC433EF for ; Wed, 6 Oct 2021 16:20:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B1CCC61131 for ; Wed, 6 Oct 2021 16:20:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239351AbhJFQWB (ORCPT ); Wed, 6 Oct 2021 12:22:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:43196 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230021AbhJFQV6 (ORCPT ); Wed, 6 Oct 2021 12:21:58 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0A7DA610EA; Wed, 6 Oct 2021 16:20:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633537206; bh=pGzTV3esiIv298q9BXKhGUzD+f9XRjx1SUiQN9dwFBY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aFzjtpdXCVTqawava5IljBa+/tcy/RpCd62RroTXoFADFrgIN7a7nbqhZR3FNa+5u n6vpDB4cL8O0y8JrseDB0TyqzlXdR+W1B7Ofy3p9ULIh4hajefc6MQFJbx6A9fOlKE TQXcV2juY27R2xwpm0OHNrAh/RN6Y76ND4wztZIPFRjNY/noEbWVI/l7pcTK4mAYo2 ZZeqnuk6nWtAJi1bNQxBAxpwNXfMMsYqe0qkO9ps/VXfUM3LFHYHqJ9Fs94tShKJd9 YArdRonQoxF6gYglcqx/Qj21TcntUkX8vqLTq7BJtHWvP0qWJqp3Pb6bZcUnaIngwf OuOpforfcU63w== Date: Wed, 6 Oct 2021 17:20:04 +0100 From: Mark Brown To: Andy Shevchenko Cc: Joe Perches , Pierre-Louis Bossart , Hans de Goede , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Cezary Rojewski , Liam Girdwood , Jie Yang , Jaroslav Kysela , Takashi Iwai Subject: Re: [PATCH v1 2/4] ASoC: Intel: bytcr_rt5640: Use temporary variable for struct device Message-ID: References: <20211006150442.16503-1-andriy.shevchenko@linux.intel.com> <20211006150442.16503-2-andriy.shevchenko@linux.intel.com> <4b81a10dca78e286a9f806464b97111b5a15a91e.camel@perches.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="pvNYqT1s2XmLNWBp" Content-Disposition: inline In-Reply-To: X-Cookie: A is for Apple. Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --pvNYqT1s2XmLNWBp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Oct 06, 2021 at 07:05:47PM +0300, Andy Shevchenko wrote: > On Wed, Oct 06, 2021 at 04:48:57PM +0100, Mark Brown wrote: > > On Wed, Oct 06, 2021 at 06:44:07PM +0300, Andy Shevchenko wrote: > > > On Wed, Oct 06, 2021 at 08:21:01AM -0700, Joe Perches wrote: > > > > Some will complain about a lack of commit message. > > > Yeah, sorry for that, it wasn't deliberate. I forgot to run `git msg-filter` > > > on these three patches to add it. > > > Mark, do you want me resend entire bunch(es) or just starting from these > > > patches? Or...? > > If you're adding a commit message with automation it's probably not > > adding any value. > What do you mean? I add it exceptionally for the same (by nature) patches. > What do you expect to be altered in these three, if the idea behind the change > is very well the same? I really don't care if there's a separate changelog for trivial patches like this, it adds nothing of value. --pvNYqT1s2XmLNWBp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmFdzLMACgkQJNaLcl1U h9AeiAf/WqCqXROZjxlY7thdJTvoxPef03P18FKvWx2PcZs8ydd2++38FMk9Kt1E 8SY7llTHx97Sy/7MohSU/I5RyxMb/16nBfc6G75elHUzZPpYMscrgNHvDsruNM50 dDl5jgXeah4PA/zkdYnyKdB5PsgDHfUH6fqlen5DdvZkBD8bgcsDmGNm5Au30XPL fytYGo8lKxq6mbHouLyqw+Cp01n75TVaz/V1v5tCSpYrLX2j5fEIMd58rPy52/hV mGrt+61/oqOJ6y0vwCH9aw1TRuHUgOX6iUfBV4d5AHpwpqqiNfA79+leR5VjUn0j 7Ax5qxo33fPbRqZQCvBqQDgktUY2Gg== =I4Dh -----END PGP SIGNATURE----- --pvNYqT1s2XmLNWBp-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B150DC433EF for ; Wed, 6 Oct 2021 16:21:49 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF527610E5 for ; Wed, 6 Oct 2021 16:21:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EF527610E5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 64DA2846; Wed, 6 Oct 2021 18:20:57 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 64DA2846 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1633537307; bh=pGzTV3esiIv298q9BXKhGUzD+f9XRjx1SUiQN9dwFBY=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=mRn9kZpOIn6DgTLtKv/DovnEyAhPc+3X/yMP4akzrw/Q9BkIhjufsAL0Oyuwl9MDQ 1gfXaTUz+x51AcGKztn2ifrRKBT2CzDfAGeL92YNgwi8/BrJiIPYvvmqgBrfSlg6nx OfT7EHOhDo7IZROolGjzKf1Irsou2QYnvBPpAiPU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 4FE3DF80249; Wed, 6 Oct 2021 18:20:14 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id A1661F80302; Wed, 6 Oct 2021 18:20:13 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 594DAF8010B for ; Wed, 6 Oct 2021 18:20:09 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 594DAF8010B Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aFzjtpdX" Received: by mail.kernel.org (Postfix) with ESMTPSA id 0A7DA610EA; Wed, 6 Oct 2021 16:20:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633537206; bh=pGzTV3esiIv298q9BXKhGUzD+f9XRjx1SUiQN9dwFBY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aFzjtpdXCVTqawava5IljBa+/tcy/RpCd62RroTXoFADFrgIN7a7nbqhZR3FNa+5u n6vpDB4cL8O0y8JrseDB0TyqzlXdR+W1B7Ofy3p9ULIh4hajefc6MQFJbx6A9fOlKE TQXcV2juY27R2xwpm0OHNrAh/RN6Y76ND4wztZIPFRjNY/noEbWVI/l7pcTK4mAYo2 ZZeqnuk6nWtAJi1bNQxBAxpwNXfMMsYqe0qkO9ps/VXfUM3LFHYHqJ9Fs94tShKJd9 YArdRonQoxF6gYglcqx/Qj21TcntUkX8vqLTq7BJtHWvP0qWJqp3Pb6bZcUnaIngwf OuOpforfcU63w== Date: Wed, 6 Oct 2021 17:20:04 +0100 From: Mark Brown To: Andy Shevchenko Subject: Re: [PATCH v1 2/4] ASoC: Intel: bytcr_rt5640: Use temporary variable for struct device Message-ID: References: <20211006150442.16503-1-andriy.shevchenko@linux.intel.com> <20211006150442.16503-2-andriy.shevchenko@linux.intel.com> <4b81a10dca78e286a9f806464b97111b5a15a91e.camel@perches.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="pvNYqT1s2XmLNWBp" Content-Disposition: inline In-Reply-To: X-Cookie: A is for Apple. Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Takashi Iwai , Jie Yang , Cezary Rojewski , Pierre-Louis Bossart , Liam Girdwood , Hans de Goede , Joe Perches X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --pvNYqT1s2XmLNWBp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Oct 06, 2021 at 07:05:47PM +0300, Andy Shevchenko wrote: > On Wed, Oct 06, 2021 at 04:48:57PM +0100, Mark Brown wrote: > > On Wed, Oct 06, 2021 at 06:44:07PM +0300, Andy Shevchenko wrote: > > > On Wed, Oct 06, 2021 at 08:21:01AM -0700, Joe Perches wrote: > > > > Some will complain about a lack of commit message. > > > Yeah, sorry for that, it wasn't deliberate. I forgot to run `git msg-filter` > > > on these three patches to add it. > > > Mark, do you want me resend entire bunch(es) or just starting from these > > > patches? Or...? > > If you're adding a commit message with automation it's probably not > > adding any value. > What do you mean? I add it exceptionally for the same (by nature) patches. > What do you expect to be altered in these three, if the idea behind the change > is very well the same? I really don't care if there's a separate changelog for trivial patches like this, it adds nothing of value. --pvNYqT1s2XmLNWBp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmFdzLMACgkQJNaLcl1U h9AeiAf/WqCqXROZjxlY7thdJTvoxPef03P18FKvWx2PcZs8ydd2++38FMk9Kt1E 8SY7llTHx97Sy/7MohSU/I5RyxMb/16nBfc6G75elHUzZPpYMscrgNHvDsruNM50 dDl5jgXeah4PA/zkdYnyKdB5PsgDHfUH6fqlen5DdvZkBD8bgcsDmGNm5Au30XPL fytYGo8lKxq6mbHouLyqw+Cp01n75TVaz/V1v5tCSpYrLX2j5fEIMd58rPy52/hV mGrt+61/oqOJ6y0vwCH9aw1TRuHUgOX6iUfBV4d5AHpwpqqiNfA79+leR5VjUn0j 7Ax5qxo33fPbRqZQCvBqQDgktUY2Gg== =I4Dh -----END PGP SIGNATURE----- --pvNYqT1s2XmLNWBp--