From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A52E5C433FE for ; Wed, 6 Oct 2021 17:32:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 84BC460F22 for ; Wed, 6 Oct 2021 17:32:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238847AbhJFRe0 (ORCPT ); Wed, 6 Oct 2021 13:34:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:33210 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231617AbhJFReW (ORCPT ); Wed, 6 Oct 2021 13:34:22 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id CA90060F22; Wed, 6 Oct 2021 17:32:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633541550; bh=xoTeSecthPoIVCFE9eaK5YWgW5FqM8Wx1GaGkk8TILk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iIbYkjKXrup+H9Fn37cRW5UkrXPxi8XPCEh7pJPwELSWYkHM9P2RBvoyr8xSXQYq3 OZUYyP8/0tbM5ndWjzDB3EhVUfZd9ZNshZPZEro1JQkGhGdPWogZfXEtpywQY4vGj7 eAGd2gNPrs/+bx+28YK/h+h0YKJnxLmOfTKpkmpVR+ZtvwONSiZGMn/zUpzPojvM6S UQmGx3moCXZ7C2g5tPB2eC7jUjwCE+yE6HI0+9xlUQAZqIy3V9ttlHj81WvoeKzDBN 4OoToLMnLBBmGUnLnb874Z3JkteR1r4l2WjeSTm/D7S/9j5ATxGC7Ij9qC1zkrTdyg lVn24l3nvK+LA== Date: Wed, 6 Oct 2021 18:32:26 +0100 From: Mark Brown To: Alexandru Elisei Cc: davem@davemloft.net, michael.riesch@wolfvision.net, peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, kuba@kernel.org, mcoquelin.stm32@gmail.com, p.zabel@pengutronix.de, lgirdwood@gmail.com, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [BUG RESEND] net: stmmac: dwmac-rk: Ethernet broken on rockpro64 by commit 2d26f6e39afb ("net: stmmac: dwmac-rk: fix unbalanced pm_runtime_enable warnings") Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6A6VXl3ajkDFtK+b" Content-Disposition: inline In-Reply-To: X-Cookie: A is for Apple. Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --6A6VXl3ajkDFtK+b Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 06, 2021 at 04:58:11PM +0100, Alexandru Elisei wrote: > Resending this because my previous email client inserted HTML into the em= ail, > which was then rejected by the linux-kernel@vger.kernel.org spam filter. >=20 > After commit 2d26f6e39afb ("net: stmmac: dwmac-rk: fix unbalanced > pm_runtime_enable warnings"), the network card on my rockpro64-v2 was left > unable to get a DHCP lease from the network. The offending commit was fou= nd by > bisecting the kernel; I tried reverting the commit from v5.15-rc4 and the > network card started working as expected. I did end up glancing briefly at this (though no idea how I ended up showing in get_maintainers...) - the revert dropped both the runtime PM enables and the get/puts, I suspect the driver may need the get/puts either where they are in the commit or at a level up. --6A6VXl3ajkDFtK+b Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmFd3akACgkQJNaLcl1U h9A+tAf/R80GdTYRa1orKc1W7WXATKEMT82qq11h/wdjVecfx/p0OGtKF6DGKXE5 fiDA0ZogMuvjFc0keAF/hwoPTvfYbKyxpXFVphdvUZgprmRbY2VXXnbAvVf/nkEz an9dEsWf4CQiMa1ZlF0klMbQN/R8+CmnTlK7bJ8tz7sRXRZOPU5Gq+DYSYKs729h UMCqB/oD6f+9MSIqCFu0ltirDRL6Gih9ZAGcbvluUKJjkqiTrbjXIpVNw6nqBFOt 3DZMTrgWyfHOyEFnRFeGD3yEb6zFCPC/IB/PZzHN01DFw7oC0jAFBQko+Jlijzur DZF6KX1d84dhjWLO5WeS6ctqCQQKSA== =8enb -----END PGP SIGNATURE----- --6A6VXl3ajkDFtK+b-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF6D4C433EF for ; Wed, 6 Oct 2021 17:34:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC0D560F22 for ; Wed, 6 Oct 2021 17:34:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AC0D560F22 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=o51HJRajXg7lhLXeqXEJ1CA9pse/9NNae/0bGYju6fA=; b=NhUrwDaf2HPJMYPRzPEmE7NyGT G1Uc5Y0gq7I8pFYkDEOnXD9n5nne59mPRPal0sBtY0RjuzCtPUx7PGFRmwdJQ0F0ErsGitjmQPtN0 2tL346gzWtKp1aZsIZUKZHgSaZijMn8lORQzPh9Fkf1Y6BDh/NdC0db/I5JtlXRPlZoJhfkflzPXX Hv5zG4jWny3KOaM24bDdDolYc4pE8NYOjxA1j+BQz1iGkAVl2Fh6URTrNJ1akKKiKcXo3ZB3tzMth 0RdFA27QgFj9CPbGgh8CRyb4hjUFa3l0mnF0mDVLcko4sGjB3HEKqxoaMiYbHrWu7SzfxvnvHCOzF H1GAJ3yA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mYAmR-00FCzl-25; Wed, 06 Oct 2021 17:32:35 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mYAmN-00FCzD-3D for linux-arm-kernel@lists.infradead.org; Wed, 06 Oct 2021 17:32:32 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id CA90060F22; Wed, 6 Oct 2021 17:32:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633541550; bh=xoTeSecthPoIVCFE9eaK5YWgW5FqM8Wx1GaGkk8TILk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iIbYkjKXrup+H9Fn37cRW5UkrXPxi8XPCEh7pJPwELSWYkHM9P2RBvoyr8xSXQYq3 OZUYyP8/0tbM5ndWjzDB3EhVUfZd9ZNshZPZEro1JQkGhGdPWogZfXEtpywQY4vGj7 eAGd2gNPrs/+bx+28YK/h+h0YKJnxLmOfTKpkmpVR+ZtvwONSiZGMn/zUpzPojvM6S UQmGx3moCXZ7C2g5tPB2eC7jUjwCE+yE6HI0+9xlUQAZqIy3V9ttlHj81WvoeKzDBN 4OoToLMnLBBmGUnLnb874Z3JkteR1r4l2WjeSTm/D7S/9j5ATxGC7Ij9qC1zkrTdyg lVn24l3nvK+LA== Date: Wed, 6 Oct 2021 18:32:26 +0100 From: Mark Brown To: Alexandru Elisei Cc: davem@davemloft.net, michael.riesch@wolfvision.net, peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, kuba@kernel.org, mcoquelin.stm32@gmail.com, p.zabel@pengutronix.de, lgirdwood@gmail.com, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [BUG RESEND] net: stmmac: dwmac-rk: Ethernet broken on rockpro64 by commit 2d26f6e39afb ("net: stmmac: dwmac-rk: fix unbalanced pm_runtime_enable warnings") Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-Cookie: A is for Apple. X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211006_103231_182670_6ABD242A X-CRM114-Status: GOOD ( 13.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============3708519073159267607==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3708519073159267607== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6A6VXl3ajkDFtK+b" Content-Disposition: inline --6A6VXl3ajkDFtK+b Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 06, 2021 at 04:58:11PM +0100, Alexandru Elisei wrote: > Resending this because my previous email client inserted HTML into the em= ail, > which was then rejected by the linux-kernel@vger.kernel.org spam filter. >=20 > After commit 2d26f6e39afb ("net: stmmac: dwmac-rk: fix unbalanced > pm_runtime_enable warnings"), the network card on my rockpro64-v2 was left > unable to get a DHCP lease from the network. The offending commit was fou= nd by > bisecting the kernel; I tried reverting the commit from v5.15-rc4 and the > network card started working as expected. I did end up glancing briefly at this (though no idea how I ended up showing in get_maintainers...) - the revert dropped both the runtime PM enables and the get/puts, I suspect the driver may need the get/puts either where they are in the commit or at a level up. --6A6VXl3ajkDFtK+b Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmFd3akACgkQJNaLcl1U h9A+tAf/R80GdTYRa1orKc1W7WXATKEMT82qq11h/wdjVecfx/p0OGtKF6DGKXE5 fiDA0ZogMuvjFc0keAF/hwoPTvfYbKyxpXFVphdvUZgprmRbY2VXXnbAvVf/nkEz an9dEsWf4CQiMa1ZlF0klMbQN/R8+CmnTlK7bJ8tz7sRXRZOPU5Gq+DYSYKs729h UMCqB/oD6f+9MSIqCFu0ltirDRL6Gih9ZAGcbvluUKJjkqiTrbjXIpVNw6nqBFOt 3DZMTrgWyfHOyEFnRFeGD3yEb6zFCPC/IB/PZzHN01DFw7oC0jAFBQko+Jlijzur DZF6KX1d84dhjWLO5WeS6ctqCQQKSA== =8enb -----END PGP SIGNATURE----- --6A6VXl3ajkDFtK+b-- --===============3708519073159267607== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3708519073159267607==--