From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65B0EC433EF for ; Thu, 7 Oct 2021 05:23:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 49F2761175 for ; Thu, 7 Oct 2021 05:23:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231814AbhJGFZo (ORCPT ); Thu, 7 Oct 2021 01:25:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:35628 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229497AbhJGFZj (ORCPT ); Thu, 7 Oct 2021 01:25:39 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3EFBD61053; Thu, 7 Oct 2021 05:23:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1633584215; bh=OJWLSXs7WMHf5W8p7Um+O8pjpdMLATkfdV9BJF09A88=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=y4bJZR66/3+KLZiTTfuSH0PEuGPh8NzU5/o7ZuB8ALz0IWqOvUHRgX5BF1VzVgbCC Bw8upTF0XFaBnNVAPhx6H39Ux1p6mozrl6iKYIcusg2sU6bxqh+4p6WSDpO/3pb0Jv RKUoNPS9CJYt4n6HHJIt7srnIebbyxEYbc/O6Hj4= Date: Thu, 7 Oct 2021 07:23:33 +0200 From: Greg Kroah-Hartman To: Zev Weiss Cc: openbmc@lists.ozlabs.org, Jeremy Kerr , Joel Stanley , Rob Herring , devicetree@vger.kernel.org, "Rafael J. Wysocki" , Daniel Vetter , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Heiner Kallweit , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/9] sysfs: add sysfs_remove_bin_file_self() function Message-ID: References: <20211007000954.30621-1-zev@bewilderbeest.net> <20211007000954.30621-2-zev@bewilderbeest.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211007000954.30621-2-zev@bewilderbeest.net> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 06, 2021 at 05:09:46PM -0700, Zev Weiss wrote: > This is simply the bin_attribute analog to sysfs_remove_file_self(). No, no binary sysfs file should be triggering a remove. binary sysfs files are "pass-through-only" from userspace to hardware, the kernel should not be even knowing what is read/written to them. What do you think this is needed for? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95031C433EF for ; Thu, 7 Oct 2021 05:24:21 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E700E6120D for ; Thu, 7 Oct 2021 05:24:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E700E6120D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4HQ09v2Yqlz2ywW for ; Thu, 7 Oct 2021 16:24:19 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=y4bJZR66; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linuxfoundation.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=gregkh@linuxfoundation.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=y4bJZR66; dkim-atps=neutral Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4HQ0982QXDz2xXx for ; Thu, 7 Oct 2021 16:23:39 +1100 (AEDT) Received: by mail.kernel.org (Postfix) with ESMTPSA id 3EFBD61053; Thu, 7 Oct 2021 05:23:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1633584215; bh=OJWLSXs7WMHf5W8p7Um+O8pjpdMLATkfdV9BJF09A88=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=y4bJZR66/3+KLZiTTfuSH0PEuGPh8NzU5/o7ZuB8ALz0IWqOvUHRgX5BF1VzVgbCC Bw8upTF0XFaBnNVAPhx6H39Ux1p6mozrl6iKYIcusg2sU6bxqh+4p6WSDpO/3pb0Jv RKUoNPS9CJYt4n6HHJIt7srnIebbyxEYbc/O6Hj4= Date: Thu, 7 Oct 2021 07:23:33 +0200 From: Greg Kroah-Hartman To: Zev Weiss Subject: Re: [PATCH 1/9] sysfs: add sysfs_remove_bin_file_self() function Message-ID: References: <20211007000954.30621-1-zev@bewilderbeest.net> <20211007000954.30621-2-zev@bewilderbeest.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211007000954.30621-2-zev@bewilderbeest.net> X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, "Rafael J. Wysocki" , Daniel Vetter , openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Jeremy Kerr , Heiner Kallweit Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Wed, Oct 06, 2021 at 05:09:46PM -0700, Zev Weiss wrote: > This is simply the bin_attribute analog to sysfs_remove_file_self(). No, no binary sysfs file should be triggering a remove. binary sysfs files are "pass-through-only" from userspace to hardware, the kernel should not be even knowing what is read/written to them. What do you think this is needed for? thanks, greg k-h