From: Cyril Hrubis <chrubis@suse.cz>
To: Yang Xu <xuyang2018.jy@fujitsu.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v1 2/3] syscalls/dup206: Add a test when newfd equals oldfd
Date: Thu, 7 Oct 2021 15:15:09 +0200 [thread overview]
Message-ID: <YV7y3fJibq1t5F8g@yuki> (raw)
In-Reply-To: <1632289182-2191-2-git-send-email-xuyang2018.jy@fujitsu.com>
Hi!
> +static void setup(void)
> +{
> + char testfile[40];
> +
> + sprintf(testfile, "dup206.%d", getpid());
> + fd = SAFE_OPEN(testfile, O_RDWR | O_CREAT, 0666);
There is no reason to append the pid here, so I've changed this to just
SAFE_OPEN("testfile", ...) and pushed, thanks.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2021-10-07 13:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 5:39 [LTP] [PATCH v1 1/3] syscalls/dup202: Also check mode whethter change when calling chmod after dup2 Yang Xu
2021-09-22 5:39 ` [LTP] [PATCH v1 2/3] syscalls/dup206: Add a test when newfd equals oldfd Yang Xu
2021-10-07 13:15 ` Cyril Hrubis [this message]
2021-09-22 5:39 ` [LTP] [PATCH v1 3/3] syscalls/dup207: Add file offset check test Yang Xu
2021-10-07 13:36 ` Cyril Hrubis
2021-10-07 12:53 ` [LTP] [PATCH v1 1/3] syscalls/dup202: Also check mode whethter change when calling chmod after dup2 Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YV7y3fJibq1t5F8g@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=xuyang2018.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.