From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Simon Horman <horms@verge.net.au>
Cc: Julian Anastasov <ja@ssi.bg>, Dust Li <dust.li@linux.alibaba.com>,
Wensong Zhang <wensong@linux-vs.org>,
lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org,
netdev@vger.kernel.org, yunhong-cgl jiang <xintian1976@gmail.com>
Subject: Re: [PATCH net-next v4] net: ipvs: add sysctl_run_estimation to support disable estimation
Date: Thu, 7 Oct 2021 19:53:32 +0200 [thread overview]
Message-ID: <YV80HOzv+2oV4ppf@salvia> (raw)
In-Reply-To: <20211002085929.GA27500@vergenet.net>
On Sat, Oct 02, 2021 at 10:59:29AM +0200, Simon Horman wrote:
> On Sat, Aug 21, 2021 at 11:41:50AM +0300, Julian Anastasov wrote:
> >
> > Hello,
> >
> > On Fri, 20 Aug 2021, Dust Li wrote:
> >
> > > estimation_timer will iterate the est_list to do estimation
> > > for each ipvs stats. When there are lots of services, the
> > > list can be very large.
> > > We found that estimation_timer() run for more then 200ms on a
> > > machine with 104 CPU and 50K services.
> > >
> > > yunhong-cgl jiang report the same phenomenon before:
> > > https://www.spinics.net/lists/lvs-devel/msg05426.html
> > >
> > > In some cases(for example a large K8S cluster with many ipvs services),
> > > ipvs estimation may not be needed. So adding a sysctl blob to allow
> > > users to disable this completely.
> > >
> > > Default is: 1 (enable)
> > >
> > > Cc: yunhong-cgl jiang <xintian1976@gmail.com>
> > > Signed-off-by: Dust Li <dust.li@linux.alibaba.com>
> >
> > Looks good to me, thanks!
> >
> > Acked-by: Julian Anastasov <ja@ssi.bg>
>
> Likwewise, thanks. And sorry for the delay.
>
> Acked-by: Simon Horman <horms@verge.net.au>
>
> Pablo, could you consider picking this up?
Applied, thanks.
prev parent reply other threads:[~2021-10-07 17:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 5:37 [PATCH net-next v4] net: ipvs: add sysctl_run_estimation to support disable estimation Dust Li
2021-08-21 8:41 ` Julian Anastasov
2021-10-02 8:59 ` Simon Horman
2021-10-07 17:53 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YV80HOzv+2oV4ppf@salvia \
--to=pablo@netfilter.org \
--cc=dust.li@linux.alibaba.com \
--cc=horms@verge.net.au \
--cc=ja@ssi.bg \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=wensong@linux-vs.org \
--cc=xintian1976@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.