From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D508C4332F for ; Thu, 7 Oct 2021 16:49:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 27F716103B for ; Thu, 7 Oct 2021 16:49:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237053AbhJGQvN (ORCPT ); Thu, 7 Oct 2021 12:51:13 -0400 Received: from mga06.intel.com ([134.134.136.31]:51976 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242891AbhJGQvI (ORCPT ); Thu, 7 Oct 2021 12:51:08 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10130"; a="287191133" X-IronPort-AV: E=Sophos;i="5.85,355,1624345200"; d="scan'208";a="287191133" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2021 09:47:44 -0700 X-IronPort-AV: E=Sophos;i="5.85,355,1624345200"; d="scan'208";a="713396822" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2021 09:47:39 -0700 Received: from andy by smile with local (Exim 4.95) (envelope-from ) id 1mYWYR-009bL5-Qf; Thu, 07 Oct 2021 19:47:35 +0300 Date: Thu, 7 Oct 2021 19:47:35 +0300 From: Andy Shevchenko To: Joe Perches Cc: Brendan Higgins , Peter Zijlstra , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-media@vger.kernel.org, Ingo Molnar , Will Deacon , Waiman Long , Boqun Feng , Sakari Ailus , Laurent Pinchart , Mauro Carvalho Chehab , Andrew Morton , Miguel Ojeda , jic23@kernel.org, linux@rasmusvillemoes.dk, Thorsten Leemhuis Subject: Re: [PATCH v4 2/7] kernel.h: Split out container_of() and typeof_member() macros Message-ID: References: <20211007154407.29746-1-andriy.shevchenko@linux.intel.com> <20211007154407.29746-3-andriy.shevchenko@linux.intel.com> <86b05929e5aa8fa6e975c59cf523ad84498351b6.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86b05929e5aa8fa6e975c59cf523ad84498351b6.camel@perches.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 07, 2021 at 09:27:38AM -0700, Joe Perches wrote: > On Thu, 2021-10-07 at 18:44 +0300, Andy Shevchenko wrote: > > kernel.h is being used as a dump for all kinds of stuff for a long time. > > Here is the attempt cleaning it up by splitting out container_of() and > > typeof_member() macros. > > > > For time being include new header back to kernel.h to avoid twisted > > indirected includes for existing users. > > IMO: this new file is missing 2 #include directives. Thanks, Joe, I'll address this in v5. -- With Best Regards, Andy Shevchenko