From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39F4CC433EF for ; Thu, 7 Oct 2021 17:32:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1B35561108 for ; Thu, 7 Oct 2021 17:32:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242872AbhJGReU (ORCPT ); Thu, 7 Oct 2021 13:34:20 -0400 Received: from mga05.intel.com ([192.55.52.43]:4228 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235301AbhJGReS (ORCPT ); Thu, 7 Oct 2021 13:34:18 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10130"; a="312511028" X-IronPort-AV: E=Sophos;i="5.85,355,1624345200"; d="scan'208";a="312511028" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2021 10:32:21 -0700 X-IronPort-AV: E=Sophos;i="5.85,355,1624345200"; d="scan'208";a="568716098" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2021 10:32:17 -0700 Received: from andy by smile with local (Exim 4.95) (envelope-from ) id 1mYXFd-009cFj-35; Thu, 07 Oct 2021 20:32:13 +0300 Date: Thu, 7 Oct 2021 20:32:13 +0300 From: Andy Shevchenko To: Joe Perches Cc: Brendan Higgins , Peter Zijlstra , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-media@vger.kernel.org, Ingo Molnar , Will Deacon , Waiman Long , Boqun Feng , Sakari Ailus , Laurent Pinchart , Mauro Carvalho Chehab , Andrew Morton , Miguel Ojeda , jic23@kernel.org, linux@rasmusvillemoes.dk, Thorsten Leemhuis Subject: Re: [PATCH v4 6/7] plist: Replace kernel.h with the necessary inclusions Message-ID: References: <20211007154407.29746-1-andriy.shevchenko@linux.intel.com> <20211007154407.29746-7-andriy.shevchenko@linux.intel.com> <1ec405c5a8fd24de9066277ce855d7e39f93e691.camel@perches.com> <04ebb29ccb707bc37df2d3ddd684781114a1a62e.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <04ebb29ccb707bc37df2d3ddd684781114a1a62e.camel@perches.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 07, 2021 at 10:26:05AM -0700, Joe Perches wrote: > On Thu, 2021-10-07 at 20:19 +0300, Andy Shevchenko wrote: > > On Thu, Oct 07, 2021 at 10:12:56AM -0700, Joe Perches wrote: > > > On Thu, 2021-10-07 at 18:44 +0300, Andy Shevchenko wrote: > > > > When kernel.h is used in the headers it adds a lot into dependency hell, > > > > especially when there are circular dependencies are involved. > > > > > > > > Replace kernel.h inclusion with the list of what is really being used. > > > [] > > > > diff --git a/include/linux/plist.h b/include/linux/plist.h > > > [] > > > > @@ -73,8 +73,11 @@ > > > [] > > > > +#include > > > > > > why asm/bug.h and not linux/bug.h ? > > > > The direct inclusion is from that one. Why linux/bug? > > A general guideline is to avoid asm includes. It's fine when it has any useful background. Doing cargo cult is not always a good idea. I plead for common sense. -- With Best Regards, Andy Shevchenko