From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A59CC4332F for ; Mon, 27 Sep 2021 04:04:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2154A61151 for ; Mon, 27 Sep 2021 04:04:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231814AbhI0EGP (ORCPT ); Mon, 27 Sep 2021 00:06:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:49614 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229445AbhI0EGO (ORCPT ); Mon, 27 Sep 2021 00:06:14 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 30B26610A2; Mon, 27 Sep 2021 04:04:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1632715476; bh=l8rONjICwE2lHMGY6qOv7rr80KcJ8HFyxEn+LuNw9d8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=V7dd2NARTlgDGjZ3TONLGqhIXpIhI2ej0jM4+LCs/CqluMwgyLRPfO8iPu2CriXt9 +SAD2jDm3AKA5Hs7IDvBWIaaVqrAfQsP+ebPSBEVPYf3SzLpyISLRbffCpILTMOtgX KBJoHevslCJxXRiDgznbWXHpwl4/pCTWn/jIalKU= Date: Mon, 27 Sep 2021 06:04:33 +0200 From: Greg KH To: "David E. Box" Cc: lee.jones@linaro.org, hdegoede@redhat.com, mgross@linux.intel.com, andriy.shevchenko@linux.intel.com, srinivas.pandruvada@intel.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: Re: [PATCH 2/2] platform/x86: Add Intel Software Defined Silicon driver Message-ID: References: <20210924213157.3584061-1-david.e.box@linux.intel.com> <20210924213157.3584061-2-david.e.box@linux.intel.com> <3392aea6b112926b063bbe46b1decaad4c9f9e6e.camel@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3392aea6b112926b063bbe46b1decaad4c9f9e6e.camel@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 26, 2021 at 06:15:16PM -0700, David E. Box wrote: > > > +static struct platform_driver sdsi_driver = { > > > +       .driver = { > > > +               .name           = SDSI_DEV_NAME, > > > +               .dev_groups     = sdsi_groups, > > > +       }, > > > +       .probe  = sdsi_probe, > > > +       .remove = sdsi_remove, > > > +}; > > > +module_platform_driver(sdsi_driver); > > > > What causes the platform to know to register, and enable, this platform > > driver?  Shouldn't there be some hardware involved that is discoverable > > to enable it to load dynamically? > > Ah. The patch that adds the SDSi platform device string was added to a series for the intel_pmt MFD > driver and it's still waiting review. I see that complicates things. I can combine the two series > together. Do you have a pointer to the lore.kernel.org location of that series? Your code right here will bind to any system that it is loaded on, a very dangerous thing... thanks, greg k-h