All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
	Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: Signed-off-by missing for commits in the rpmsg tree
Date: Mon, 27 Sep 2021 16:45:40 -0700	[thread overview]
Message-ID: <YVJXpBwfdMYKaE0R@ripper> (raw)
In-Reply-To: <20210928084011.3f2318fc@canb.auug.org.au>

On Mon 27 Sep 15:40 PDT 2021, Stephen Rothwell wrote:

> Hi all,
> 
> Commits
> 
>   5346c95245ad ("dt-bindings: remoteproc: k3-dsp: Cleanup SoC compatible from DT example")
>   e24acced0dd9 ("dt-bindings: remoteproc: k3-r5f: Cleanup SoC compatible from DT example")
>   6944d19dfd0d ("remoteproc: mediatek: Support mt8195 scp")
>   3c14c79a4c32 ("dt-bindings: remoteproc: mediatek: Convert mtk,scp to json-schema")
>   fc265554dbc8 ("dt-bindings: remoteproc: mediatek: Add binding for mt8192 scp")
>   d75e3e9fa929 ("dt-bindings: remoteproc: mediatek: Add binding for mt8195 scp")
>   4d2236dbeb09 ("remoteproc: meson-mx-ao-arc: Add a driver for the AO ARC remote procesor")
>   059efbbfa03a ("dt-bindings: remoteproc: Add the documentation for Meson AO ARC rproc")
>   ee3eec23f843 ("remoteproc: imx_rproc: Change to ioremap_wc for dram")
>   9da2a820edc7 ("remoteproc: imx_rproc: Fix rsc-table name")
>   f64051b28d2d ("remoteproc: imx_rproc: Fix ignoring mapping vdev regions")
>   cfaa53387e8b ("remoteproc: imx_rproc: Fix TCM io memory type")
>   a46fb6875d39 ("remoteproc: Fix the wrong default value of is_iomem")
>   c7e587505b2b ("remoteproc: elf_loader: Fix loading segment when is_iomem true")
>   a57645ea04bf ("rpmsg: Change naming of mediatek rpmsg property")
> 
> are missing a Signed-off-by from their committer.
> 
> All presumablyrebased :-(
> 

That's exactly the case, I rebased Mathieu's patches to avoid having the
sha1s of the already published commits change, and wasn't aware that the
rebase would alter the committer field (but it does make sense in
hindsight).

I've now signed all the changes off and pushed the branches again,
hopefully no one will "notice"...to much...Going forward we'll avoid
rebasing things and shouldn't run into this problem again.


May I ask what tool you use to detect this? Given that checkpatch
doesn't care about the committer (afaict)...

Regards,
Bjorn

  reply	other threads:[~2021-09-27 23:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-27 22:40 linux-next: Signed-off-by missing for commits in the rpmsg tree Stephen Rothwell
2021-09-27 23:45 ` Bjorn Andersson [this message]
2021-09-28  0:43   ` Stephen Rothwell
2021-09-28  3:03     ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YVJXpBwfdMYKaE0R@ripper \
    --to=bjorn.andersson@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.