From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9077529CA for ; Tue, 28 Sep 2021 07:10:47 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 78B2A611C0; Tue, 28 Sep 2021 07:10:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1632813046; bh=zPQccM6PFEYRzZcyQsbZ75u4XbjptgQYbBq0Dj3jSg8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=u0j2gqTNNZoN29EBZTmf3PhT1ZSFx2bTT/xlXhE4nJBerzQEFIZ7wboWUIm5XW5LD SVJaoc6N0o+RgQvl4BHQfQzKnPcRWQxnypODFASneRpgC3h3dlMLjlmKyzA2EtqKPS QmEFq9BPrmhJsxNgSu8GGcjSrB0aPpgLmxEla84Q= Date: Tue, 28 Sep 2021 09:10:44 +0200 From: Greg KH To: Ojaswin Mujoo Cc: nsaenz@kernel.org, stefan.wahren@i2se.com, dan.carpenter@oracle.com, phil@raspberrypi.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: vchiq: Update TODO file Message-ID: References: <20210927181323.10931-1-ojaswin98@gmail.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210927181323.10931-1-ojaswin98@gmail.com> On Mon, Sep 27, 2021 at 11:43:23PM +0530, Ojaswin Mujoo wrote: > Remove completed tasks from TODO and add some relevant details to task > 14. > > Signed-off-by: Ojaswin Mujoo > --- > drivers/staging/vc04_services/interface/TODO | 43 ++++---------------- > 1 file changed, 7 insertions(+), 36 deletions(-) > > diff --git a/drivers/staging/vc04_services/interface/TODO b/drivers/staging/vc04_services/interface/TODO > index 39810ce017cd..5a6b3fc2663a 100644 > --- a/drivers/staging/vc04_services/interface/TODO > +++ b/drivers/staging/vc04_services/interface/TODO > @@ -16,23 +16,6 @@ some of the ones we want: > to manage these buffers as dmabufs so that we can zero-copy import > camera images into vc4 for rendering/display. > > -2) Garbage-collect unused code > - > -One of the reasons this driver wasn't upstreamed previously was that > -there's a lot code that got built that's probably unnecessary these > -days. Once we have the set of VCHI-using drivers we want in tree, we > -should be able to do a sweep of the code to see what's left that's > -unused. > - > -3) Make driver more portable > - > -Building this driver with arm/multi_v7_defconfig or arm64/defconfig > -leads to data corruption during the following command: > - > - vchiq_test -f 1 > - > -This should be fixed. > - > 4) Fix kernel module support Now the numbering is out of order? How about a first patch to remove the numbering and just replace it with a list of items that are not numbered, and then remove the tasks that are already done? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E21BC433F5 for ; Tue, 28 Sep 2021 07:11:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2A8C6611C0 for ; Tue, 28 Sep 2021 07:11:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2A8C6611C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7gD0Yjh+Hbs/AJGqFG23n+bigHqmcx28KvAqDOhJ7ac=; b=DbuTS0Gjmx8CGJ ZfZ2hx6K6g3b3BLz31bOJ3hkI2lernEk1g8rceALk2rK8OdOEqTzYJHth7GZonhUi8QjZMh0nZ/30 WyhJZ/KcDIJooRvX8GVK1hV3oJgc7Fm4LRkM9FlP2kZS3LaRcN0QyuS611BJp0tr1fSQBUNlx/q3P Yy+4YtipYmNCMRnVx6Xn6gZifLiLh8iQqmdpk2AC2jDR7gpLvsDeiPmNMJIAXi3mFFcJgR2UyhJbj /ScwQLqT0AK+W/3qsdRCAKtFCihIdd0I6kSC8V8Disw3TDvPKc2p52F/yGvQI6zmjROB0W8gG7I4B b/G4J+nuwsuLqlSC9gIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mV7GN-005xVS-JL; Tue, 28 Sep 2021 07:10:51 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mV7GJ-005xUU-8o for linux-arm-kernel@lists.infradead.org; Tue, 28 Sep 2021 07:10:48 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 78B2A611C0; Tue, 28 Sep 2021 07:10:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1632813046; bh=zPQccM6PFEYRzZcyQsbZ75u4XbjptgQYbBq0Dj3jSg8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=u0j2gqTNNZoN29EBZTmf3PhT1ZSFx2bTT/xlXhE4nJBerzQEFIZ7wboWUIm5XW5LD SVJaoc6N0o+RgQvl4BHQfQzKnPcRWQxnypODFASneRpgC3h3dlMLjlmKyzA2EtqKPS QmEFq9BPrmhJsxNgSu8GGcjSrB0aPpgLmxEla84Q= Date: Tue, 28 Sep 2021 09:10:44 +0200 From: Greg KH To: Ojaswin Mujoo Cc: nsaenz@kernel.org, stefan.wahren@i2se.com, dan.carpenter@oracle.com, phil@raspberrypi.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: vchiq: Update TODO file Message-ID: References: <20210927181323.10931-1-ojaswin98@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210927181323.10931-1-ojaswin98@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210928_001047_350807_7B782A84 X-CRM114-Status: GOOD ( 21.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 27, 2021 at 11:43:23PM +0530, Ojaswin Mujoo wrote: > Remove completed tasks from TODO and add some relevant details to task > 14. > > Signed-off-by: Ojaswin Mujoo > --- > drivers/staging/vc04_services/interface/TODO | 43 ++++---------------- > 1 file changed, 7 insertions(+), 36 deletions(-) > > diff --git a/drivers/staging/vc04_services/interface/TODO b/drivers/staging/vc04_services/interface/TODO > index 39810ce017cd..5a6b3fc2663a 100644 > --- a/drivers/staging/vc04_services/interface/TODO > +++ b/drivers/staging/vc04_services/interface/TODO > @@ -16,23 +16,6 @@ some of the ones we want: > to manage these buffers as dmabufs so that we can zero-copy import > camera images into vc4 for rendering/display. > > -2) Garbage-collect unused code > - > -One of the reasons this driver wasn't upstreamed previously was that > -there's a lot code that got built that's probably unnecessary these > -days. Once we have the set of VCHI-using drivers we want in tree, we > -should be able to do a sweep of the code to see what's left that's > -unused. > - > -3) Make driver more portable > - > -Building this driver with arm/multi_v7_defconfig or arm64/defconfig > -leads to data corruption during the following command: > - > - vchiq_test -f 1 > - > -This should be fixed. > - > 4) Fix kernel module support Now the numbering is out of order? How about a first patch to remove the numbering and just replace it with a list of items that are not numbered, and then remove the tasks that are already done? thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel