From: Lee Jones <lee.jones@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>,
Rob Herring <robh@kernel.org>
Subject: Re: [RESEND PATCH v2 2/4] mfd: max77686: Do not enforce (incorrect) interrupt trigger type
Date: Tue, 28 Sep 2021 10:53:02 +0100 [thread overview]
Message-ID: <YVLl/tJAYU5sEFO0@google.com> (raw)
In-Reply-To: <20210602110445.33536-2-krzysztof.kozlowski@canonical.com>
On Wed, 02 Jun 2021, Krzysztof Kozlowski wrote:
> From: Krzysztof Kozlowski <krzk@kernel.org>
>
> Interrupt line can be configured on different hardware in different way,
> even inverted. Therefore driver should not enforce specific trigger
> type - edge falling - but instead rely on Devicetree to configure it.
>
> The Maxim 77686 datasheet describes the interrupt line as active low
> with a requirement of acknowledge from the CPU therefore the edge
> falling is not correct.
>
> The interrupt line is shared between PMIC and RTC driver, so using level
> sensitive interrupt is here especially important to avoid races. With
> an edge configuration in case if first PMIC signals interrupt followed
> shortly after by the RTC, the interrupt might not be yet cleared/acked
> thus the second one would not be noticed.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> Acked-by: Rob Herring <robh@kernel.org>
>
> ---
>
> Changes since v1:
> 1. Add ack.
> ---
> Documentation/devicetree/bindings/clock/maxim,max77686.txt | 4 ++--
> Documentation/devicetree/bindings/mfd/max77686.txt | 2 +-
> Documentation/devicetree/bindings/regulator/max77686.txt | 2 +-
> drivers/mfd/max77686.c | 3 +--
> 4 files changed, 5 insertions(+), 6 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2021-09-28 9:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 11:04 [RESEND PATCH v2 1/4] mfd: sec-irq: Do not enforce (incorrect) interrupt trigger type Krzysztof Kozlowski
2021-06-02 11:04 ` [RESEND PATCH v2 2/4] mfd: max77686: " Krzysztof Kozlowski
2021-09-28 9:53 ` Lee Jones [this message]
2021-06-02 11:04 ` [RESEND PATCH v2 3/4] mfd: max77693: " Krzysztof Kozlowski
2021-09-28 9:52 ` Lee Jones
2021-06-02 11:04 ` [RESEND PATCH v2 4/4] mfd: max14577: " Krzysztof Kozlowski
2021-09-28 9:52 ` Lee Jones
2021-09-22 8:10 ` [RESEND PATCH v2 1/4] mfd: sec-irq: " Krzysztof Kozlowski
2021-09-28 9:52 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVLl/tJAYU5sEFO0@google.com \
--to=lee.jones@linaro.org \
--cc=b.zolnierkie@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=lgirdwood@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.