From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DA23C433FE for ; Tue, 28 Sep 2021 10:01:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 025B7610E5 for ; Tue, 28 Sep 2021 10:01:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240112AbhI1KCr (ORCPT ); Tue, 28 Sep 2021 06:02:47 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:58967 "EHLO relay12.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239815AbhI1KCr (ORCPT ); Tue, 28 Sep 2021 06:02:47 -0400 Received: (Authenticated sender: alexandre.belloni@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 09C38200020; Tue, 28 Sep 2021 10:01:05 +0000 (UTC) Date: Tue, 28 Sep 2021 12:01:05 +0200 From: Alexandre Belloni To: Claudiu Beznea Cc: nicolas.ferre@microchip.com, ludovic.desroches@microchip.com, linux@armlinux.org.uk, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 2/3] ARM: at91: pm: group constants and addresses loading Message-ID: References: <20210928084257.2188017-1-claudiu.beznea@microchip.com> <20210928084257.2188017-3-claudiu.beznea@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210928084257.2188017-3-claudiu.beznea@microchip.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On 28/09/2021 11:42:56+0300, Claudiu Beznea wrote: > Group constants and addresses loading. This commit prepares the field for > the next one. Added fixes tag on this commit as the next one will fail > to apply if backported alone to older kernels. The proper notation is to use Depends-on: on the next patch. > > Fixes: f0bbf17958e8 ("ARM: at91: pm: add self-refresh support for sama7g5") > Signed-off-by: Claudiu Beznea > --- > arch/arm/mach-at91/pm_suspend.S | 17 +++++++++-------- > 1 file changed, 9 insertions(+), 8 deletions(-) > > diff --git a/arch/arm/mach-at91/pm_suspend.S b/arch/arm/mach-at91/pm_suspend.S > index cbd61a3bcab1..34f251fdb743 100644 > --- a/arch/arm/mach-at91/pm_suspend.S > +++ b/arch/arm/mach-at91/pm_suspend.S > @@ -1014,6 +1014,15 @@ ENTRY(at91_pm_suspend_in_sram) > mov tmp1, #0 > mcr p15, 0, tmp1, c7, c10, 4 > > + ldr tmp1, [r0, #PM_DATA_PMC_MCKR_OFFSET] > + str tmp1, .mckr_offset > + ldr tmp1, [r0, #PM_DATA_PMC_VERSION] > + str tmp1, .pmc_version > + ldr tmp1, [r0, #PM_DATA_MEMCTRL] > + str tmp1, .memtype > + ldr tmp1, [r0, #PM_DATA_MODE] > + str tmp1, .pm_mode > + > ldr tmp1, [r0, #PM_DATA_PMC] > str tmp1, .pmc_base > ldr tmp1, [r0, #PM_DATA_RAMC0] > @@ -1022,14 +1031,6 @@ ENTRY(at91_pm_suspend_in_sram) > str tmp1, .sramc1_base > ldr tmp1, [r0, #PM_DATA_RAMC_PHY] > str tmp1, .sramc_phy_base > - ldr tmp1, [r0, #PM_DATA_MEMCTRL] > - str tmp1, .memtype > - ldr tmp1, [r0, #PM_DATA_MODE] > - str tmp1, .pm_mode > - ldr tmp1, [r0, #PM_DATA_PMC_MCKR_OFFSET] > - str tmp1, .mckr_offset > - ldr tmp1, [r0, #PM_DATA_PMC_VERSION] > - str tmp1, .pmc_version > /* Both ldrne below are here to preload their address in the TLB */ > ldr tmp1, [r0, #PM_DATA_SHDWC] > str tmp1, .shdwc > -- > 2.25.1 > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82034C433FE for ; Tue, 28 Sep 2021 10:03:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 55963610E5 for ; Tue, 28 Sep 2021 10:03:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 55963610E5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VVQZOmW8dd2bRP/KLWUAe5Xbc8jd3SFiUY/QsXoPhy4=; b=gxDwkYoYTBsgls Jfu7NfYaEbOYSXX/xbiAV25j4CcwtMswg2V6xF+yiPC1XS91pakgF+WQY1Xp+IclBceExG6jYlStc wgKL7SO+gmdSEVl+eSW5Vr/QMYA7lgrnmGWwfBfdwle1ZmntGxWkJFHDjnXIF8wW1n4B4x7tzQaI+ uA86VRZqeHLD2l3Bn1Oi9Fe1H4I5VOxoCEtd/UOc19U0cWGs+IYRzGPMhNuJmVCXilxEemM1N9SlV lyMXm2HlhtR67ehHk8ljSZ1eAmvxZ9vFQ6WmhimFpqFKLgJ5v6nVxh8E7czGTqaj48nX4BjydzYDv ZbPXSVeAqv5rFa97RbmA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mV9vH-006hNA-G1; Tue, 28 Sep 2021 10:01:15 +0000 Received: from relay12.mail.gandi.net ([217.70.178.232]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mV9vD-006hHp-8J for linux-arm-kernel@lists.infradead.org; Tue, 28 Sep 2021 10:01:13 +0000 Received: (Authenticated sender: alexandre.belloni@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 09C38200020; Tue, 28 Sep 2021 10:01:05 +0000 (UTC) Date: Tue, 28 Sep 2021 12:01:05 +0200 From: Alexandre Belloni To: Claudiu Beznea Subject: Re: [PATCH 2/3] ARM: at91: pm: group constants and addresses loading Message-ID: References: <20210928084257.2188017-1-claudiu.beznea@microchip.com> <20210928084257.2188017-3-claudiu.beznea@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210928084257.2188017-3-claudiu.beznea@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210928_030111_462907_AEB1D33D X-CRM114-Status: GOOD ( 15.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ludovic.desroches@microchip.com, robh+dt@kernel.org, linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello, On 28/09/2021 11:42:56+0300, Claudiu Beznea wrote: > Group constants and addresses loading. This commit prepares the field for > the next one. Added fixes tag on this commit as the next one will fail > to apply if backported alone to older kernels. The proper notation is to use Depends-on: on the next patch. > > Fixes: f0bbf17958e8 ("ARM: at91: pm: add self-refresh support for sama7g5") > Signed-off-by: Claudiu Beznea > --- > arch/arm/mach-at91/pm_suspend.S | 17 +++++++++-------- > 1 file changed, 9 insertions(+), 8 deletions(-) > > diff --git a/arch/arm/mach-at91/pm_suspend.S b/arch/arm/mach-at91/pm_suspend.S > index cbd61a3bcab1..34f251fdb743 100644 > --- a/arch/arm/mach-at91/pm_suspend.S > +++ b/arch/arm/mach-at91/pm_suspend.S > @@ -1014,6 +1014,15 @@ ENTRY(at91_pm_suspend_in_sram) > mov tmp1, #0 > mcr p15, 0, tmp1, c7, c10, 4 > > + ldr tmp1, [r0, #PM_DATA_PMC_MCKR_OFFSET] > + str tmp1, .mckr_offset > + ldr tmp1, [r0, #PM_DATA_PMC_VERSION] > + str tmp1, .pmc_version > + ldr tmp1, [r0, #PM_DATA_MEMCTRL] > + str tmp1, .memtype > + ldr tmp1, [r0, #PM_DATA_MODE] > + str tmp1, .pm_mode > + > ldr tmp1, [r0, #PM_DATA_PMC] > str tmp1, .pmc_base > ldr tmp1, [r0, #PM_DATA_RAMC0] > @@ -1022,14 +1031,6 @@ ENTRY(at91_pm_suspend_in_sram) > str tmp1, .sramc1_base > ldr tmp1, [r0, #PM_DATA_RAMC_PHY] > str tmp1, .sramc_phy_base > - ldr tmp1, [r0, #PM_DATA_MEMCTRL] > - str tmp1, .memtype > - ldr tmp1, [r0, #PM_DATA_MODE] > - str tmp1, .pm_mode > - ldr tmp1, [r0, #PM_DATA_PMC_MCKR_OFFSET] > - str tmp1, .mckr_offset > - ldr tmp1, [r0, #PM_DATA_PMC_VERSION] > - str tmp1, .pmc_version > /* Both ldrne below are here to preload their address in the TLB */ > ldr tmp1, [r0, #PM_DATA_SHDWC] > str tmp1, .shdwc > -- > 2.25.1 > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel