All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Yanan Wang <wangyanan55@huawei.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Andrew Jones <drjones@redhat.com>,
	Cornelia Huck <cohuck@redhat.com>,
	Eduardo Habkost <ehabkost@redhat.com>,
	Pierre Morel <pmorel@linux.ibm.com>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	Pankaj Gupta <pankaj.gupta.linux@gmail.com>,
	qemu-devel@nongnu.org, qemu-s390x@nongnu.org,
	qemu-arm@nongnu.org, qemu-ppc@nongnu.org,
	wanghaibin.wang@huawei.com, Paolo Bonzini <pbonzini@redhat.com>,
	David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH v11 04/14] machine: Set the value of cpus to match maxcpus if it's omitted
Date: Tue, 28 Sep 2021 11:10:40 +0100	[thread overview]
Message-ID: <YVLqIMqQE6YXDTH3@redhat.com> (raw)
In-Reply-To: <20210928035755.11684-5-wangyanan55@huawei.com>

On Tue, Sep 28, 2021 at 11:57:45AM +0800, Yanan Wang wrote:
> Currently we directly calculate the omitted cpus based on the given
> incomplete collection of parameters. This makes some cmdlines like:
>   -smp maxcpus=16
>   -smp sockets=2,maxcpus=16
>   -smp sockets=2,dies=2,maxcpus=16
>   -smp sockets=2,cores=4,maxcpus=16
> not work. We should probably set the value of cpus to match maxcpus
> if it's omitted, which will make above configs start to work.
> 
> So the calculation logic of cpus/maxcpus after this patch will be:
> When both maxcpus and cpus are omitted, maxcpus will be calculated
> from the given parameters and cpus will be set equal to maxcpus.
> When only one of maxcpus and cpus is given then the omitted one
> will be set to its counterpart's value. Both maxcpus and cpus may
> be specified, but maxcpus must be equal to or greater than cpus.
> 
> Note: change in this patch won't affect any existing working cmdlines
> but allows more incomplete configs to be valid.
> 
> Signed-off-by: Yanan Wang <wangyanan55@huawei.com>
> Reviewed-by: Andrew Jones <drjones@redhat.com>
> ---
>  hw/core/machine.c | 29 ++++++++++++++++-------------
>  hw/i386/pc.c      | 29 ++++++++++++++++-------------
>  qemu-options.hx   | 11 ++++++++---
>  3 files changed, 40 insertions(+), 29 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



  reply	other threads:[~2021-09-28 10:12 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-28  3:57 [PATCH v11 00/14] machine: smp parsing fixes and improvement Yanan Wang
2021-09-28  3:57 ` [PATCH v11 01/14] machine: Deprecate "parameter=0" SMP configurations Yanan Wang
2021-09-28  9:58   ` Daniel P. Berrangé
2021-09-28 11:15     ` wangyanan (Y)
2021-09-28  3:57 ` [PATCH v11 02/14] machine: Minor refactor/fix for the smp parsers Yanan Wang
2021-09-28 10:06   ` Daniel P. Berrangé
2021-09-28  3:57 ` [PATCH v11 03/14] machine: Uniformly use maxcpus to calculate the omitted parameters Yanan Wang
2021-09-28 10:09   ` Daniel P. Berrangé
2021-09-28  3:57 ` [PATCH v11 04/14] machine: Set the value of cpus to match maxcpus if it's omitted Yanan Wang
2021-09-28 10:10   ` Daniel P. Berrangé [this message]
2021-09-28  3:57 ` [PATCH v11 05/14] machine: Improve the error reporting of smp parsing Yanan Wang
2021-09-28 10:13   ` Daniel P. Berrangé
2021-09-28 10:50   ` Philippe Mathieu-Daudé
2021-09-28  3:57 ` [PATCH v11 06/14] qtest/numa-test: Use detailed -smp CLIs in pc_dynamic_cpu_cfg Yanan Wang
2021-09-28 10:17   ` Daniel P. Berrangé
2021-09-28 10:51   ` Philippe Mathieu-Daudé
2021-09-28  3:57 ` [PATCH v11 07/14] qtest/numa-test: Use detailed -smp CLIs in test_def_cpu_split Yanan Wang
2021-09-28 10:19   ` Daniel P. Berrangé
2021-09-28 10:51   ` Philippe Mathieu-Daudé
2021-09-28  3:57 ` [PATCH v11 08/14] machine: Prefer cores over sockets in smp parsing since 6.2 Yanan Wang
2021-09-28 10:21   ` Daniel P. Berrangé
2021-09-28  3:57 ` [PATCH v11 09/14] machine: Use ms instead of global current_machine in sanity-check Yanan Wang
2021-09-28 10:21   ` Daniel P. Berrangé
2021-09-28 10:52   ` Philippe Mathieu-Daudé
2021-09-28  3:57 ` [PATCH v11 10/14] machine: Tweak the order of topology members in struct CpuTopology Yanan Wang
2021-09-28 10:23   ` Daniel P. Berrangé
2021-09-28 10:58   ` Philippe Mathieu-Daudé
2021-09-28  3:57 ` [PATCH v11 11/14] machine: Make smp_parse generic enough for all arches Yanan Wang
2021-09-28 10:25   ` Daniel P. Berrangé
2021-09-28 10:57   ` Philippe Mathieu-Daudé
2021-09-28 10:58     ` Daniel P. Berrangé
2021-09-28 11:02       ` Philippe Mathieu-Daudé
2021-09-28 11:07       ` wangyanan (Y)
2021-09-28 12:25     ` Markus Armbruster
2021-09-28 12:53       ` wangyanan (Y)
2021-09-28  3:57 ` [PATCH v11 12/14] machine: Remove smp_parse callback from MachineClass Yanan Wang
2021-09-28 10:25   ` Daniel P. Berrangé
2021-09-28 10:58   ` Philippe Mathieu-Daudé
2021-09-28  3:57 ` [PATCH v11 13/14] machine: Move smp_prefer_sockets to struct SMPCompatProps Yanan Wang
2021-09-28 10:26   ` Daniel P. Berrangé
2021-09-28  3:57 ` [PATCH v11 14/14] machine: Put all sanity-check in the generic SMP parser Yanan Wang
2021-09-28 10:38   ` Daniel P. Berrangé
2021-09-28 11:01   ` Philippe Mathieu-Daudé
2021-09-28 11:20     ` wangyanan (Y)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YVLqIMqQE6YXDTH3@redhat.com \
    --to=berrange@redhat.com \
    --cc=cohuck@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=drjones@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=mst@redhat.com \
    --cc=pankaj.gupta.linux@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=pmorel@linux.ibm.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=wanghaibin.wang@huawei.com \
    --cc=wangyanan55@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.