From: Andrew Lunn <andrew@lunn.ch>
To: Cai Huoqing <caihuoqing@baidu.com>
Cc: Horatiu Vultur <horatiu.vultur@microchip.com>,
hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
kuba@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: mdio: mscc-miim: Fix the mdio controller
Date: Tue, 28 Sep 2021 14:00:12 +0200 [thread overview]
Message-ID: <YVMDzAcQSjuiqoud@lunn.ch> (raw)
In-Reply-To: <20210928085414.GA1723@LAPTOP-UKSR4ENP.internal.baidu.com>
On Tue, Sep 28, 2021 at 04:54:14PM +0800, Cai Huoqing wrote:
> On 28 9月 21 09:17:20, Horatiu Vultur wrote:
> Hi Horatiu,
>
> Thank for your feedback.
>
> I'm sorry for this commit, my mistake.
>
> After I have checked my recent submission history
>
> the commit-
> commit fa14d03e014a130839f9dc1b97ea61fe598d873d
> drivers/net/mdio/mdio-ipq4019.c 225 line
>
> has the same issue, an optional phy-regs
> Are you willing to fix it at the same time:)
Hi
Since it was a separate patch which broken it, it should be a separate
patch which fixes it. Please send a fix.
You can also give a Reviewed-by: to Horatiu patch, if you think it is
correct.
Andrew
next prev parent reply other threads:[~2021-09-28 12:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 7:17 [PATCH net] net: mdio: mscc-miim: Fix the mdio controller Horatiu Vultur
2021-09-28 8:54 ` Cai Huoqing
2021-09-28 12:00 ` Andrew Lunn [this message]
2021-09-28 12:19 ` Cai Huoqing
2021-09-28 12:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVMDzAcQSjuiqoud@lunn.ch \
--to=andrew@lunn.ch \
--cc=caihuoqing@baidu.com \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.