From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id E7ED06E07D for ; Tue, 28 Sep 2021 13:49:43 +0000 (UTC) Date: Tue, 28 Sep 2021 16:53:05 +0300 From: Petri Latvala Message-ID: References: <20210927160700.1570885-1-aurabindo.pillai@amd.com> <0e047200-f40a-daa8-80d8-4745da3b9430@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0e047200-f40a-daa8-80d8-4745da3b9430@amd.com> Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_flip : skip subtest bo-too-big List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Aurabindo Pillai Cc: Mark Yacoub , Development mailing list for IGT GPU Tools , Mark Yacoub , "Siqueira, Rodrigo" List-ID: On Tue, Sep 28, 2021 at 09:35:10AM -0400, Aurabindo Pillai wrote: > > On 9/28/21 5:15 AM, Petri Latvala wrote: > > On Mon, Sep 27, 2021 at 07:10:45PM +0000, Pillai, Aurabindo wrote: > > > Skipping using the continue statement has the side effect of this > > > subtest being absent from the list of subtests, when running the > > > test executable with paramter --list-subtest. Is that okay ? > > It's not okay btw. When you're not in an igt_fixture or an > > igt_subtest, you cannot use anything that touches the hardware or the > > running system in any way. > > > > > In that case, please discard v2. Is this version good enough ? > No objections with v1. Acked-by: Petri Latvala