All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jose R. Ziviani" <jziviani@suse.de>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org
Subject: Re: [PATCH v2 0/2] modules: Improve modinfo.c support
Date: Tue, 28 Sep 2021 10:54:06 -0300	[thread overview]
Message-ID: <YVMefnvHATyjBChA@pizza> (raw)
In-Reply-To: <20210928050628.l344ydhuzr25rsox@sirius.home.kraxel.org>

[-- Attachment #1: Type: text/plain, Size: 1479 bytes --]

Hello, Gerd!

On Tue, Sep 28, 2021 at 07:06:28AM +0200, Gerd Hoffmann wrote:
> On Mon, Sep 27, 2021 at 11:11:58AM -0300, Jose R. Ziviani wrote:
> > This patchset introduces the modinfo_need and changes
> > modinfo-generate.py/meson.build to generate/link one modinfo per target.
> > 
> > modinfo-generate.py will know, thanks to modinfo_need, which modules are
> > currently enabled for a given target before adding it in the array of
> > modules. It will give a hint about why some modules failed, so
> > developers can have a clue about it:
> 
> The approach looks good to me.

Awesome, I'll apply your review and send a new version.

Thank you!

> 
> >     /* hw-display-qxl.modinfo */
> >     /* module  QXL is missing. */
> 
> You are using kconfig symbols here, so the comment should say so ;)
> 
> Renaming modinfo_need to modinfo_kconfig will probably also help
> to make that clear.
> 
> >     /* hw-display-virtio-gpu.modinfo */
> >     .name = "hw-display-virtio-gpu",
> >     .objs = ((const char*[]){  "virtio-gpu-base",  "virtio-gpu-device",  "vhost-user-gpu", NULL }),
> 
> Hmm?  Leftover from an older version of the series?
> 
> >  - accelerators can be filtered as well (this only covers the device
> >    part), then the field QemuModinfo.arch can be removed.
> 
> It's target-specific modules.  Although accelerators are the only
> in-tree users right this is not limited to accelerators.
> 
> take care,
>   Gerd
> 

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2021-09-28 14:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-27 14:11 [PATCH v2 0/2] modules: Improve modinfo.c support Jose R. Ziviani
2021-09-27 14:11 ` Jose R. Ziviani
2021-09-27 14:12 ` [PATCH v2 1/2] modules: introduces module_needs directive Jose R. Ziviani
2021-09-27 14:12 ` [PATCH v2 2/2] modules: generates per-target modinfo Jose R. Ziviani
2021-09-28  5:06 ` [PATCH v2 0/2] modules: Improve modinfo.c support Gerd Hoffmann
2021-09-28 13:54   ` Jose R. Ziviani [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YVMefnvHATyjBChA@pizza \
    --to=jziviani@suse.de \
    --cc=kraxel@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.