From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18C57C433F5 for ; Tue, 28 Sep 2021 14:58:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DFFE161213 for ; Tue, 28 Sep 2021 14:58:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241279AbhI1O7z (ORCPT ); Tue, 28 Sep 2021 10:59:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241406AbhI1O7y (ORCPT ); Tue, 28 Sep 2021 10:59:54 -0400 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39DA0C06161C for ; Tue, 28 Sep 2021 07:58:15 -0700 (PDT) Received: by mail-wm1-x332.google.com with SMTP id z184-20020a1c7ec1000000b003065f0bc631so2583598wmc.0 for ; Tue, 28 Sep 2021 07:58:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=QW/iGDRyZchN8Mm3Lgfi04v5R4JX67d3vWd6I5nvOfo=; b=FvlIwZje7r3p4KVXKgsdwTakffjTJxcd4A9dlfMHkXtKs7DHBGoAvR8MW+KJ9f/hw2 6Tut5KjpHd2FMxSXkoZTVrsglrVf2C/S98s+ca3WF2S7w/Vbw6acGa2JMSDs5nchXV5A CLIW6COY/gSYlO4B5aNuaPAXuzOxcC3FpDwEXWm6bhC+nENuW1x2aP/+T6Y0qckbS2Q8 H0ytpN5VGVN6urXXLIIyQ7RSljWlhjuBqld1d9qCOWzfsPALe4kQ0dT7dIvbQuIt4yBx d2fDN5qZ2+7fPl1KAPFf5tvR4TxyVTEqVt4UaZjSO1GeCVEzcawSYUle2SD8VJBxqW06 uTLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=QW/iGDRyZchN8Mm3Lgfi04v5R4JX67d3vWd6I5nvOfo=; b=K7hPinRFwC+SHAXxkGFUm/e7/XpgVbbvANbMI58TZKfwiY5HFg9Zbt90zcqY9KfRP9 e7VZaTrntkfI3G5tA2ymGYNQKop9gzcvA2unpsife51tAhliK88p7LifT33WSxk6JzzI 9gniC8l5YkDlj9sw+eFyVlZM8tpXK4FHxgBpavZjkHOEo7aV9co4OGzHLPbdqHBx0pKx E9Wy9rbj/1mb+7VU5NJpPoDqfnMQ/S3+WimTEfPxdwHUoNzkfADbJem6AGZb+fW/m6GC 1OCUcgqLJHFxbwLopTqPHSNIaceD1yBLq7NiG5x8xK3HTIYT+yC2LSYzSelhxCYpR2dW 31Dw== X-Gm-Message-State: AOAM530mW15h3DGTyOkQHFHnV0KGtPfwX2CkFjrGhlb2xjQk+hZSirSJ lO2UK9fTzHffNDA20LCrLwQOHA== X-Google-Smtp-Source: ABdhPJyAA3f06QGMTVpZuEqToVOc8cuAiYcICGxkpGqBtD1I5r+gyQ+DGMhDjtEeRgVh9SnNFt+29w== X-Received: by 2002:a7b:ca58:: with SMTP id m24mr1846215wml.0.1632841093668; Tue, 28 Sep 2021 07:58:13 -0700 (PDT) Received: from google.com (216.131.76.34.bc.googleusercontent.com. [34.76.131.216]) by smtp.gmail.com with ESMTPSA id y18sm19438837wrq.6.2021.09.28.07.58.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Sep 2021 07:58:12 -0700 (PDT) Date: Tue, 28 Sep 2021 14:58:08 +0000 From: David Brazdil To: Marc Zyngier Cc: linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, ascull@google.com, James Morse , Suzuki K Poulose , Alexandru Elisei , kernel-team@android.com Subject: Re: [PATCH] KVM: arm64: Allow KVM to be disabled from the command line Message-ID: References: <20210903091652.985836-1-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210903091652.985836-1-maz@kernel.org> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Hey Marc, that all makes sense: Reviewed-by: David Brazdil > @@ -2137,8 +2142,15 @@ static int __init early_kvm_mode_cfg(char *arg) > return 0; > } > > - if (strcmp(arg, "nvhe") == 0 && !WARN_ON(is_kernel_in_hyp_mode())) > + if (strcmp(arg, "nvhe") == 0 && !WARN_ON(is_kernel_in_hyp_mode())) { > + kvm_mode = KVM_MODE_DEFAULT; > return 0; > + } > + > + if (strcmp(arg, "none") == 0 && !WARN_ON(is_kernel_in_hyp_mode())) { nit: I noticed we check is_kernel_in_hyp_mode here for nvhe/none but for protected it is checked in is_kvm_protected_mode. May be worth unifying? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5565FC433EF for ; Tue, 28 Sep 2021 14:58:19 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id B85BD61215 for ; Tue, 28 Sep 2021 14:58:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B85BD61215 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 2F05A4B108; Tue, 28 Sep 2021 10:58:18 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@google.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lFH7y4SVkTN9; Tue, 28 Sep 2021 10:58:17 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 2E3CB4A3A5; Tue, 28 Sep 2021 10:58:17 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id E9BCD40C88 for ; Tue, 28 Sep 2021 10:58:15 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VHaZO7F5SNzy for ; Tue, 28 Sep 2021 10:58:14 -0400 (EDT) Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id C9FCB4086C for ; Tue, 28 Sep 2021 10:58:14 -0400 (EDT) Received: by mail-wm1-f52.google.com with SMTP id j27so3754513wms.0 for ; Tue, 28 Sep 2021 07:58:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=QW/iGDRyZchN8Mm3Lgfi04v5R4JX67d3vWd6I5nvOfo=; b=FvlIwZje7r3p4KVXKgsdwTakffjTJxcd4A9dlfMHkXtKs7DHBGoAvR8MW+KJ9f/hw2 6Tut5KjpHd2FMxSXkoZTVrsglrVf2C/S98s+ca3WF2S7w/Vbw6acGa2JMSDs5nchXV5A CLIW6COY/gSYlO4B5aNuaPAXuzOxcC3FpDwEXWm6bhC+nENuW1x2aP/+T6Y0qckbS2Q8 H0ytpN5VGVN6urXXLIIyQ7RSljWlhjuBqld1d9qCOWzfsPALe4kQ0dT7dIvbQuIt4yBx d2fDN5qZ2+7fPl1KAPFf5tvR4TxyVTEqVt4UaZjSO1GeCVEzcawSYUle2SD8VJBxqW06 uTLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=QW/iGDRyZchN8Mm3Lgfi04v5R4JX67d3vWd6I5nvOfo=; b=bSNzkQME54AVzhPozIzPuebnug9zaxehdyzyd+jq83Zsjb4jP7/hycwIwDRcRq2Zwv K4iKKFZMvMT53eiBeR/IqhCW64OVJeUYuOAUfjp0Y3JE1Cb68hGsslyLCU5b7EjQDbQH kGLpaSeBO/cscxcLntI7m0TIQissfqjWRKPybRnhGO4c03FeOgZ2DkaOortYzzD8d1tM zdLNjmAqI0KwEEcNp4ezQbktnEhy/V306/kvY2Q4glizIgeneTCHhpRA+Aw8D+mYyWsB 3Z1PWb/w5UoYhx7YUWJHUWRYlvr9JhRTM/twooKgYfdFe7TeCmBKrbB5lJIkYt5bXAha woHg== X-Gm-Message-State: AOAM531s2XCyPH540tDh2FLRK88cxe8nLvspuevyePr0PEbhXYPc4ji+ jvMddhtOd/qB8G+WI/c1+TJ1Yw== X-Google-Smtp-Source: ABdhPJyAA3f06QGMTVpZuEqToVOc8cuAiYcICGxkpGqBtD1I5r+gyQ+DGMhDjtEeRgVh9SnNFt+29w== X-Received: by 2002:a7b:ca58:: with SMTP id m24mr1846215wml.0.1632841093668; Tue, 28 Sep 2021 07:58:13 -0700 (PDT) Received: from google.com (216.131.76.34.bc.googleusercontent.com. [34.76.131.216]) by smtp.gmail.com with ESMTPSA id y18sm19438837wrq.6.2021.09.28.07.58.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Sep 2021 07:58:12 -0700 (PDT) Date: Tue, 28 Sep 2021 14:58:08 +0000 From: David Brazdil To: Marc Zyngier Subject: Re: [PATCH] KVM: arm64: Allow KVM to be disabled from the command line Message-ID: References: <20210903091652.985836-1-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210903091652.985836-1-maz@kernel.org> Cc: kvm@vger.kernel.org, kernel-team@android.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu Hey Marc, that all makes sense: Reviewed-by: David Brazdil > @@ -2137,8 +2142,15 @@ static int __init early_kvm_mode_cfg(char *arg) > return 0; > } > > - if (strcmp(arg, "nvhe") == 0 && !WARN_ON(is_kernel_in_hyp_mode())) > + if (strcmp(arg, "nvhe") == 0 && !WARN_ON(is_kernel_in_hyp_mode())) { > + kvm_mode = KVM_MODE_DEFAULT; > return 0; > + } > + > + if (strcmp(arg, "none") == 0 && !WARN_ON(is_kernel_in_hyp_mode())) { nit: I noticed we check is_kernel_in_hyp_mode here for nvhe/none but for protected it is checked in is_kvm_protected_mode. May be worth unifying? _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68D3AC433FE for ; Tue, 28 Sep 2021 15:00:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2FAD46101A for ; Tue, 28 Sep 2021 15:00:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2FAD46101A Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9r9fx7swRSJ13rhkeu++4yaXdSAYnLRcd7Abux2r0F0=; b=U1ivlPXSDL2w7G ORm2R3BN24IJX+ZzOxPbiUZkSXvIwpcqMQZBe6eI/2MY4H5O9ScRM2YljASNKKzDU4JIpXTAXJrV7 4afbW1qUNjeuDSMhXPSip6HgbvU8ZN3UwKi6wMBy7lQ7D2QsMxgXtFvZWCNAtLHiPemx5W6xQodTR 0As050ciy78UI4bd7gxtQYwe2dPEoikcL2h3nIY45sWFL2gIgRqu9GVBLtePVJDDjPbO681tWih+J ez/dvZ6+PKgfYQIvew61WEdRyIvKWwg+gtD3icIzqSgoERI4dyDn67OQqWyMusLvW11BDSRwmq+aH sjmHCqEInYKhWJv3Xb5A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVEYo-007hBs-4Y; Tue, 28 Sep 2021 14:58:22 +0000 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVEYk-007hB9-KM for linux-arm-kernel@lists.infradead.org; Tue, 28 Sep 2021 14:58:19 +0000 Received: by mail-wm1-x333.google.com with SMTP id c73-20020a1c9a4c000000b0030d040bb895so2986142wme.2 for ; Tue, 28 Sep 2021 07:58:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=QW/iGDRyZchN8Mm3Lgfi04v5R4JX67d3vWd6I5nvOfo=; b=FvlIwZje7r3p4KVXKgsdwTakffjTJxcd4A9dlfMHkXtKs7DHBGoAvR8MW+KJ9f/hw2 6Tut5KjpHd2FMxSXkoZTVrsglrVf2C/S98s+ca3WF2S7w/Vbw6acGa2JMSDs5nchXV5A CLIW6COY/gSYlO4B5aNuaPAXuzOxcC3FpDwEXWm6bhC+nENuW1x2aP/+T6Y0qckbS2Q8 H0ytpN5VGVN6urXXLIIyQ7RSljWlhjuBqld1d9qCOWzfsPALe4kQ0dT7dIvbQuIt4yBx d2fDN5qZ2+7fPl1KAPFf5tvR4TxyVTEqVt4UaZjSO1GeCVEzcawSYUle2SD8VJBxqW06 uTLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=QW/iGDRyZchN8Mm3Lgfi04v5R4JX67d3vWd6I5nvOfo=; b=19EREsGBq+KLmlueYtUw1qnxTyZ802//UcletKu6JLvh4yfCGoQCkdy/w88SeG6ed/ S3LmaoEFYKKrA4QRiNYMBqxfDUeqUFWorBgtbnmmzmHIPC6ZkZi8ahZaK4m3B/V+xwZB IrX95lWQllVlpLTwD5PCX+H3fGTV5aqnhcyc8wEgzEIx+yb01K9i1xHGd/i+iau4NscG k35u5RiCL6Spy+RxL8HExs6t/ZjmreAzdrZbEdTZWrrN/Xng9J3kpV15XfbCHAWL9Vrr +06Dd48A/ZFgri3UpLIqcHLdOWxx/w/ZbFmAJYw1CMnlvIjXM9S1mJNS/+Epi6zxBYRT 3k1g== X-Gm-Message-State: AOAM5330HLztA7NGdeHcH15E3Q2aApV6ZKeH30XwaRzFMcCKTwZyUtRO D7CnnuIh4h4i6EmuY4oQoVVZUg== X-Google-Smtp-Source: ABdhPJyAA3f06QGMTVpZuEqToVOc8cuAiYcICGxkpGqBtD1I5r+gyQ+DGMhDjtEeRgVh9SnNFt+29w== X-Received: by 2002:a7b:ca58:: with SMTP id m24mr1846215wml.0.1632841093668; Tue, 28 Sep 2021 07:58:13 -0700 (PDT) Received: from google.com (216.131.76.34.bc.googleusercontent.com. [34.76.131.216]) by smtp.gmail.com with ESMTPSA id y18sm19438837wrq.6.2021.09.28.07.58.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Sep 2021 07:58:12 -0700 (PDT) Date: Tue, 28 Sep 2021 14:58:08 +0000 From: David Brazdil To: Marc Zyngier Cc: linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, ascull@google.com, James Morse , Suzuki K Poulose , Alexandru Elisei , kernel-team@android.com Subject: Re: [PATCH] KVM: arm64: Allow KVM to be disabled from the command line Message-ID: References: <20210903091652.985836-1-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210903091652.985836-1-maz@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210928_075818_692787_85C96EF7 X-CRM114-Status: GOOD ( 12.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hey Marc, that all makes sense: Reviewed-by: David Brazdil > @@ -2137,8 +2142,15 @@ static int __init early_kvm_mode_cfg(char *arg) > return 0; > } > > - if (strcmp(arg, "nvhe") == 0 && !WARN_ON(is_kernel_in_hyp_mode())) > + if (strcmp(arg, "nvhe") == 0 && !WARN_ON(is_kernel_in_hyp_mode())) { > + kvm_mode = KVM_MODE_DEFAULT; > return 0; > + } > + > + if (strcmp(arg, "none") == 0 && !WARN_ON(is_kernel_in_hyp_mode())) { nit: I noticed we check is_kernel_in_hyp_mode here for nvhe/none but for protected it is checked in is_kvm_protected_mode. May be worth unifying? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel