From: "Daniel P. Berrangé" <berrange@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: Pankaj Gupta <pankaj.gupta.linux@gmail.com>,
Eduardo Habkost <ehabkost@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
qemu-devel@nongnu.org, Igor Mammedov <imammedo@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v3 1/7] util/oslib-posix: Let touch_all_pages() return an error
Date: Tue, 28 Sep 2021 17:21:46 +0100 [thread overview]
Message-ID: <YVNBGqz8NeKL/049@redhat.com> (raw)
In-Reply-To: <20210816094739.21970-2-david@redhat.com>
On Mon, Aug 16, 2021 at 11:47:33AM +0200, David Hildenbrand wrote:
> Let's prepare touch_all_pages() for returning differing errors. Return
> an error from the thread and report the last processed error.
>
> Translate SIGBUS to -EFAULT, as a SIGBUS can mean all different kind of
> things (memory error, read error, out of memory). When allocating memory
> fails via the current SIGBUS-based mechanism, we'll get:
> os_mem_prealloc: preallocating memory failed: Bad address
>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
> util/oslib-posix.c | 28 ++++++++++++++++------------
> 1 file changed, 16 insertions(+), 12 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2021-09-28 16:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-16 9:47 [PATCH v3 0/7] util/oslib-posix: Support MADV_POPULATE_WRITE for os_mem_prealloc() David Hildenbrand
2021-08-16 9:47 ` [PATCH v3 1/7] util/oslib-posix: Let touch_all_pages() return an error David Hildenbrand
2021-09-28 16:21 ` Daniel P. Berrangé [this message]
2021-08-16 9:47 ` [PATCH v3 2/7] util/oslib-posix: Support MADV_POPULATE_WRITE for os_mem_prealloc() David Hildenbrand
2021-09-28 16:45 ` Daniel P. Berrangé
2021-08-16 9:47 ` [PATCH v3 3/7] util/oslib-posix: Introduce and use MemsetContext for touch_all_pages() David Hildenbrand
2021-08-16 9:47 ` [PATCH v3 4/7] util/oslib-posix: Don't create too many threads with small memory or little pages David Hildenbrand
2021-09-28 16:47 ` Daniel P. Berrangé
2021-08-16 9:47 ` [PATCH v3 5/7] util/oslib-posix: Avoid creating a single thread with MADV_POPULATE_WRITE David Hildenbrand
2021-09-28 16:52 ` Daniel P. Berrangé
2021-08-16 9:47 ` [PATCH v3 6/7] util/oslib-posix: Support concurrent os_mem_prealloc() invocation David Hildenbrand
2021-09-28 16:56 ` Daniel P. Berrangé
2021-09-28 17:01 ` Daniel P. Berrangé
2021-09-28 17:17 ` David Hildenbrand
2021-08-16 9:47 ` [PATCH v3 7/7] util/oslib-posix: Forward SIGBUS to MCE handler under Linux David Hildenbrand
2021-09-28 16:59 ` Daniel P. Berrangé
2021-09-28 17:13 ` David Hildenbrand
2021-09-28 14:01 ` [PATCH v3 0/7] util/oslib-posix: Support MADV_POPULATE_WRITE for os_mem_prealloc() David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVNBGqz8NeKL/049@redhat.com \
--to=berrange@redhat.com \
--cc=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=pankaj.gupta.linux@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.