From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBECCC433F5 for ; Tue, 28 Sep 2021 16:59:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A8F696128B for ; Tue, 28 Sep 2021 16:59:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241773AbhI1RBQ (ORCPT ); Tue, 28 Sep 2021 13:01:16 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:22158 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S240713AbhI1RBQ (ORCPT ); Tue, 28 Sep 2021 13:01:16 -0400 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 18SF8g52012111; Tue, 28 Sep 2021 12:59:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : sender : content-transfer-encoding : mime-version; s=pp1; bh=ZqSiiLhGkB2H1klIsBMzmzRqTOEnaeMz55tic8y9ce0=; b=LXzEHPRf8v/f7jvsmynQinWXchm7l6uwd+7iNo4Du4ZFZ6RwE8AJSloU9hlNb4c+M1HH yz6+3q+5YA/3A8hHohRtKQLhtRWhSkuE+lOLUWMEdsDsYzIVS89jGvPxrsk+HYKdBuLB ysOitR4xbvYH6tA9fyLbHOknl1Zhqdj1gVwu07D6uvEqlYM+M5CMMEa/fsK5QUxEaP5o PYgvelS3/xdPsIyJ+O/dzVYSM/Wj7zV/5DIwmFgEsdHzHxe5O/NLJuk++tLnRTGhmqdo JKOk4GaHV/+gq5gss5L9fO/I44irmHS6C0D6TNSgZWeTi5cD/QUJEyWJfCmbTG05M8ec bw== Received: from ppma01fra.de.ibm.com (46.49.7a9f.ip4.static.sl-reverse.com [159.122.73.70]) by mx0b-001b2d01.pphosted.com with ESMTP id 3bbwqsp82p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 28 Sep 2021 12:59:33 -0400 Received: from pps.filterd (ppma01fra.de.ibm.com [127.0.0.1]) by ppma01fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 18SGvvk8012562; Tue, 28 Sep 2021 16:59:32 GMT Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by ppma01fra.de.ibm.com with ESMTP id 3b9ud9pgdb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 28 Sep 2021 16:59:31 +0000 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 18SGxSF640173892 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 28 Sep 2021 16:59:28 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 694624C050; Tue, 28 Sep 2021 16:59:28 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 570124C040; Tue, 28 Sep 2021 16:59:28 +0000 (GMT) Received: from t480-pf1aa2c2 (unknown [9.145.72.153]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Tue, 28 Sep 2021 16:59:28 +0000 (GMT) Received: from bblock by t480-pf1aa2c2 with local (Exim 4.94.2) (envelope-from ) id 1mVGRz-000EWv-Q3; Tue, 28 Sep 2021 18:59:27 +0200 Date: Tue, 28 Sep 2021 18:59:27 +0200 From: Benjamin Block To: Bart Van Assche Cc: "Martin K . Petersen" , linux-scsi@vger.kernel.org, "James E.J. Bottomley" Subject: Re: [PATCH 03/84] scsi: core: Call scsi_done directly Message-ID: References: <20210918000607.450448-1-bvanassche@acm.org> <20210918000607.450448-4-bvanassche@acm.org> Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20210918000607.450448-4-bvanassche@acm.org> Sender: Benjamin Block X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: UUNPzccVKrVU9bPz2xFpk37LG0pYA7zu X-Proofpoint-GUID: UUNPzccVKrVU9bPz2xFpk37LG0pYA7zu Content-Transfer-Encoding: 8bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-28_05,2021-09-28_01,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 malwarescore=0 phishscore=0 impostorscore=0 mlxlogscore=999 lowpriorityscore=0 spamscore=0 priorityscore=1501 bulkscore=0 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001 definitions=main-2109280096 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On Fri, Sep 17, 2021 at 05:04:46PM -0700, Bart Van Assche wrote: > Conditional statements are faster than indirect calls. Hence call > scsi_done() directly. > > Signed-off-by: Bart Van Assche > --- > drivers/scsi/hosts.c | 2 +- > include/scsi/scsi_host.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Benjamin Block -- Best Regards, Benjamin Block / Linux on IBM Z Kernel Development / IBM Systems IBM Deutschland Research & Development GmbH / https://www.ibm.com/privacy Vorsitz. AufsR.: Gregor Pillen / Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen / Registergericht: AmtsG Stuttgart, HRB 243294