From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22F30C433EF for ; Tue, 28 Sep 2021 23:27:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0019E61368 for ; Tue, 28 Sep 2021 23:27:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243251AbhI1X3Z (ORCPT ); Tue, 28 Sep 2021 19:29:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243181AbhI1X3Y (ORCPT ); Tue, 28 Sep 2021 19:29:24 -0400 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61337C061745 for ; Tue, 28 Sep 2021 16:27:44 -0700 (PDT) Received: by mail-pl1-x62d.google.com with SMTP id x4so215325pln.5 for ; Tue, 28 Sep 2021 16:27:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=EhcU8Kjwg9ut3Xb/ULqWAtFmuiERKbM2e3Paikz24PM=; b=nCBwjJ8wk+eIIztcdWohvrAoPS9xE411Mk0+osyihr2YQCUeGX0gh9UMreKbvuCfCQ Mf9HWw/kEzftTvW+em1VMKWn01o/uu820IpoBiAlkseaOsar779zc8yyoAgwM4JDKi+f KkuJiv9wze5HfP0ZZiPfJZeqBY+5uUsTaBubiEhmeLJ26WbSXy5qxQ4q3AcfTGdQTeI9 IkdMu/Qyl0m+a3odOSa7UbeJ4fDidepVwH4MeKi8XCnLRA7oOCPDvfaEez3tN886ju3h aDp+OFLJ3x0Pe/lFNNAFDRQcF1aLZGnj0NA7NoWIrqhE9+JgVfHu4msus8UIYtt94Y3w IX5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=EhcU8Kjwg9ut3Xb/ULqWAtFmuiERKbM2e3Paikz24PM=; b=MPl747EGthGmz0GlGlM2PkNbnTvT+2On31JBYVBT+HwKXRhx+MzdywKg1NjpdtWKJb MC8+zvge1P+NlUU6LOS1zI/KqUyzreMgxL/aua28pk0tfyxtdfe5F3egHIpMG+ZiFj2Q FOm1F6jJZhb5ozNj+jmzfC/KZKvKy/UIbmDIN9+k0vf6MudnZigYrTTnWYmL1V04QrCO aNdcWaWqEzZihktlea/+FFOYTdyQv0bwqkmvwG92yhdaOZLYe27xwTNhEz00y2GYuz8U tC6oRZ8rxaHE+x7I1RSLPjIIPgcRyuMB9PeN4JRURU8BO5P+tT0vV5p5WacZJ2NJk9rB k0NA== X-Gm-Message-State: AOAM532PF2LyelgOm8lqmhvoZ/SQDgoP4FSK6oYDmsMO+vaP2fk0Jtfz yYJWopGb/iqlvm/h1pO1f+6mvILE6KjppA== X-Google-Smtp-Source: ABdhPJwAWvHmSQDULEyAN8bGPHlrdsyt6zkLtTY6gHMHgQlJIEht1JMpZbQ76VX+lMCX9P5doqCUWA== X-Received: by 2002:a17:902:a70e:b0:13e:1274:c352 with SMTP id w14-20020a170902a70e00b0013e1274c352mr7331772plq.58.1632871663648; Tue, 28 Sep 2021 16:27:43 -0700 (PDT) Received: from google.com (254.80.82.34.bc.googleusercontent.com. [34.82.80.254]) by smtp.gmail.com with ESMTPSA id z23sm121863pgv.45.2021.09.28.16.27.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Sep 2021 16:27:42 -0700 (PDT) Date: Tue, 28 Sep 2021 23:27:39 +0000 From: David Matlack To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, seanjc@google.com Subject: Re: [PATCH v3 00/31] KVM: x86: pass arguments on the page fault path via struct kvm_page_fault Message-ID: References: <20210924163152.289027-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210924163152.289027-1-pbonzini@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 24, 2021 at 12:31:21PM -0400, Paolo Bonzini wrote: > The current kvm page fault handlers passes around many arguments to the > functions. To simplify those arguments and local variables, introduce > a data structure, struct kvm_page_fault, to hold those arguments and > variables. struct kvm_page_fault is allocated on stack on the caller > of kvm fault handler, kvm_mmu_do_page_fault(), and passed around. > > Later in the series, my patches are interleaved with David's work to > add the memory slot to the struct and avoid repeated lookups. Along the > way you will find some cleanups of functions with a ludicrous number of > arguments, so that they use struct kvm_page_fault as much as possible > or at least receive related information from a single argument. make_spte > in particular goes from 11 to 10 arguments (yeah I know) despite gaining > two for kvm_mmu_page and kvm_memory_slot. > > This can be sometimes a bit debatable (for example struct kvm_mmu_page > is used a little more on the TDP MMU paths), but overall I think the > result is an improvement. For example the SET_SPTE_* constants go > away, and they absolutely didn't belong in the TDP MMU. But if you > disagree with some of the changes, please speak up loudly! Thanks for getting this cleaned up and sent out. The series looks good overall. I had 2 small comments but otherwise: Reviewed-by: David Matlack > > Testing: survives kvm-unit-tests on Intel with all of ept=0, ept=1 > tdp_mmu=0, ept=1. Will do more before committing to it in kvm/next of > course. > > Paolo > > David Matlack (5): > KVM: x86/mmu: Fold rmap_recycle into rmap_add > KVM: x86/mmu: Pass the memslot around via struct kvm_page_fault > KVM: x86/mmu: Avoid memslot lookup in page_fault_handle_page_track > KVM: x86/mmu: Avoid memslot lookup in rmap_add > KVM: x86/mmu: Avoid memslot lookup in make_spte and > mmu_try_to_unsync_pages > > Paolo Bonzini (25): > KVM: MMU: pass unadulterated gpa to direct_page_fault > KVM: MMU: Introduce struct kvm_page_fault > KVM: MMU: change mmu->page_fault() arguments to kvm_page_fault > KVM: MMU: change direct_page_fault() arguments to kvm_page_fault > KVM: MMU: change page_fault_handle_page_track() arguments to > kvm_page_fault > KVM: MMU: change kvm_faultin_pfn() arguments to kvm_page_fault > KVM: MMU: change handle_abnormal_pfn() arguments to kvm_page_fault > KVM: MMU: change __direct_map() arguments to kvm_page_fault > KVM: MMU: change FNAME(fetch)() arguments to kvm_page_fault > KVM: MMU: change kvm_tdp_mmu_map() arguments to kvm_page_fault > KVM: MMU: change tdp_mmu_map_handle_target_level() arguments to > kvm_page_fault > KVM: MMU: change fast_page_fault() arguments to kvm_page_fault > KVM: MMU: change kvm_mmu_hugepage_adjust() arguments to kvm_page_fault > KVM: MMU: change disallowed_hugepage_adjust() arguments to > kvm_page_fault > KVM: MMU: change tracepoints arguments to kvm_page_fault > KVM: MMU: mark page dirty in make_spte > KVM: MMU: unify tdp_mmu_map_set_spte_atomic and > tdp_mmu_set_spte_atomic_no_dirty_log > KVM: MMU: inline set_spte in mmu_set_spte > KVM: MMU: inline set_spte in FNAME(sync_page) > KVM: MMU: clean up make_spte return value > KVM: MMU: remove unnecessary argument to mmu_set_spte > KVM: MMU: set ad_disabled in TDP MMU role > KVM: MMU: pass kvm_mmu_page struct to make_spte > KVM: MMU: pass struct kvm_page_fault to mmu_set_spte > KVM: MMU: make spte an in-out argument in make_spte > > Sean Christopherson (1): > KVM: x86/mmu: Verify shadow walk doesn't terminate early in page > faults > > arch/x86/include/asm/kvm_host.h | 4 +- > arch/x86/include/asm/kvm_page_track.h | 4 +- > arch/x86/kvm/mmu.h | 84 +++++- > arch/x86/kvm/mmu/mmu.c | 408 +++++++++++--------------- > arch/x86/kvm/mmu/mmu_internal.h | 22 +- > arch/x86/kvm/mmu/mmutrace.h | 18 +- > arch/x86/kvm/mmu/page_track.c | 6 +- > arch/x86/kvm/mmu/paging_tmpl.h | 137 +++++---- > arch/x86/kvm/mmu/spte.c | 29 +- > arch/x86/kvm/mmu/spte.h | 14 +- > arch/x86/kvm/mmu/tdp_mmu.c | 123 +++----- > arch/x86/kvm/mmu/tdp_mmu.h | 4 +- > 12 files changed, 390 insertions(+), 463 deletions(-) > > -- > 2.27.0 >