All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Avri Altman <Avri.Altman@wdc.com>
Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
	Linux Doc Mailing List <linux-doc@vger.kernel.org>,
	Jonathan Corbet <corbet@lwn.net>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Bean Huo <beanhuo@micron.com>, Can Guo <cang@codeaurora.org>,
	Daejun Park <daejun7.park@samsung.com>,
	Lukas Bulwahn <lukas.bulwahn@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 16/17] ABI: sysfs-driver-ufs: Add another What for platform drivers
Date: Wed, 29 Sep 2021 09:39:41 +0200	[thread overview]
Message-ID: <YVQYPW5gDR2nvOcW@kroah.com> (raw)
In-Reply-To: <DM6PR04MB6575B12DCA2D78A387E61852FCA99@DM6PR04MB6575.namprd04.prod.outlook.com>

On Wed, Sep 29, 2021 at 07:23:32AM +0000, Avri Altman wrote:
> > On Wed, Sep 29, 2021 at 06:32:40AM +0000, Avri Altman wrote:
> > > > The current what expressions:
> > > >         What:          /sys/bus/platform/drivers/ufshcd/*/...
> > > >
> > > > Doesn't actually match what (some?) platform drivers actually
> > > > export. For instance, drivers/scsi/ufs/ufs-hisi.c actually creates
> > > > the sysfs struct for ufshcd inside this directory:
> > > >
> > > >         /sys/devices/platform/soc/ff3c0000.ufs
> > > >
> > > > Which has those aliases:
> > > >
> > > >         /sys/devices/virtual/devlink/platform:fff35000.crg_ctrl--
> > > > platform:ff3c0000.ufs/consumer/
> > > >         /sys/bus/platform/drivers/ufshcd-hisi/ff3c0000.ufs/
> > > >         /sys/bus/platform/devices/soc/ff3c0000.ufs/
> > > >         /sys/bus/platform/devices/ff3c0000.ufs/
> > > >
> > > > So, add another What: for such files that will match the device ufs
> > > > entries, e. g.:
> > > >
> > > >         What:          /sys/bus/platform/devices/*.ufs/
> > > On some platforms the suffix is .ufshc So Maybe use:
> > > /sys/bus/platform/devices/*.ufs*/
> > 
> > That's confusing.  How about describing why "ufshc" is used in another
> > entry?  You all must have picked the new name for some reason to
> > differentiate, right?
> It's a platform thing. Better let the platform guys answer that.

What plaform people?

  reply	other threads:[~2021-09-29  7:39 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-27 13:59 [PATCH 00/17] ABI: update files to reduce the documentation gap Mauro Carvalho Chehab
2021-09-27 13:59 ` [PATCH 01/17] ABI: stable/sysfs-module: better document modules Mauro Carvalho Chehab
2021-09-27 13:59 ` [PATCH 02/17] ABI: stable/sysfs-module: document version and srcversion Mauro Carvalho Chehab
2021-09-27 13:59 ` [PATCH 03/17] ABI: testing/sysfs-module: document initstate Mauro Carvalho Chehab
2021-09-27 13:59 ` [PATCH 04/17] ABI: sysfs-devices-power: document some RPM statistics Mauro Carvalho Chehab
2021-09-27 13:59 ` [PATCH 05/17] ABI: sysfs-devices: add /dev ABI Mauro Carvalho Chehab
2021-09-27 13:59 ` [PATCH 06/17] ABI: sysfs-bus-pci: add documentation for modalias Mauro Carvalho Chehab
2021-09-28 10:48   ` Greg Kroah-Hartman
2021-09-28 11:48     ` Mauro Carvalho Chehab
2021-09-27 13:59 ` [PATCH 07/17] ABI: o2cb: add an obsolete file for /sys/o2cb Mauro Carvalho Chehab
2021-09-27 13:59 ` [PATCH 08/17] ABI: sysfs-kernel-slab: Document some stats Mauro Carvalho Chehab
2021-09-27 13:59 ` [PATCH 09/17] ABI: sysfs-devices-power: add some debug sysfs files Mauro Carvalho Chehab
2021-09-27 13:59 ` [PATCH 10/17] ABI: sysfs-bus-pci: add a alternative What fields Mauro Carvalho Chehab
2021-09-28 18:34   ` Bjorn Helgaas
2021-09-28 22:07     ` Mauro Carvalho Chehab
2021-09-27 13:59 ` [PATCH 11/17] ABI: sysfs-class-bdi: use What: to describe each property Mauro Carvalho Chehab
2021-09-27 13:59 ` [PATCH 12/17] ABI: sysfs-bus-mdio: add alternate What for mdio symbols Mauro Carvalho Chehab
2021-09-27 13:59 ` [PATCH 13/17] ABI: sysfs-bus-usb: use a wildcard for interface name on What Mauro Carvalho Chehab
2021-09-27 13:59 ` [PATCH 14/17] ABI: sysfs-bus-usb: add missing sysfs fields Mauro Carvalho Chehab
2021-09-27 13:59 ` [PATCH 15/17] ABI: obsolete/sysfs-bus-iio: add some missing blank lines Mauro Carvalho Chehab
2021-09-27 13:59 ` [PATCH 16/17] ABI: sysfs-driver-ufs: Add another What for platform drivers Mauro Carvalho Chehab
2021-09-29  6:32   ` Avri Altman
2021-09-29  7:03     ` Greg Kroah-Hartman
2021-09-29  7:23       ` Avri Altman
2021-09-29  7:39         ` Greg Kroah-Hartman [this message]
2021-09-27 13:59 ` [PATCH 17/17] ABI: sysfs-bus-platform: add modalias description Mauro Carvalho Chehab
2021-09-27 21:00   ` Barry Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YVQYPW5gDR2nvOcW@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Avri.Altman@wdc.com \
    --cc=adrian.hunter@intel.com \
    --cc=beanhuo@micron.com \
    --cc=cang@codeaurora.org \
    --cc=corbet@lwn.net \
    --cc=daejun7.park@samsung.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=martin.petersen@oracle.com \
    --cc=mchehab+huawei@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.