From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E4152F80 for ; Wed, 29 Sep 2021 15:24:48 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 604FF61440; Wed, 29 Sep 2021 15:24:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632929088; bh=xBRRX1rYjiTzPEoPMHw1rL24TvrnK+689UnwZagbnsQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aP/SzhecYqJ59hW7NpP/05VpI6etnlUtWV51qr4Sjrsj7iIglusLMXx2XNaO0fT0M RyFp76HRYmy1cib0bH0hsp/eVZnogcmCelT/ZwaymqsJegIyZJRgdg5tNKJsghh0RX h735xxlR9XptIYNPpeHPeVEIWeiC9Q4ek0t3XMoih4QzIJ1mz04rG59BZZLxMrAzht MHpF9eFzGaB22t5a325IB+YbBszRNGWukMKfRmsCWK+zMzKR3DD/rQmxK4ETBnoB+G hvBLRT6RtSXZYMSVRvFbB12XrLiTkxZUMC0ZQ7vldriFuDLP8cPBDmDxWn6bw8TPTP TWgYqiOk6HtYQ== Date: Wed, 29 Sep 2021 18:24:44 +0300 From: Leon Romanovsky To: Jakub Kicinski Cc: "David S . Miller" , Alexandre Belloni , Andrew Lunn , Ariel Elior , Bin Luo , Claudiu Manoil , Coiby Xu , Derek Chickles , drivers@pensando.io, Eric Dumazet , Felix Manlunas , Florian Fainelli , Geetha sowjanya , Greg Kroah-Hartman , GR-everest-linux-l2@marvell.com, GR-Linux-NIC-Dev@marvell.com, hariprasad , Ido Schimmel , intel-wired-lan@lists.osuosl.org, Ioana Ciornei , Jerin Jacob , Jesse Brandeburg , Jiri Pirko , Jonathan Lemon , Linu Cherian , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-rdma@vger.kernel.org, linux-staging@lists.linux.dev, Manish Chopra , Michael Chan , Moshe Shemesh , netdev@vger.kernel.org, oss-drivers@corigine.com, Richard Cochran , Saeed Mahameed , Salil Mehta , Satanand Burla , Shannon Nelson , Shay Drory , Simon Horman , Subbaraya Sundeep , Sunil Goutham , Taras Chornyi , Tariq Toukan , Tony Nguyen , UNGLinuxDriver@microchip.com, Vadym Kochan , Vivien Didelot , Vladimir Oltean , Yisen Zhuang Subject: Re: [PATCH net-next v1 4/5] net/mlx5: Register separate reload devlink ops for multiport device Message-ID: References: <20210929065549.43b13203@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20210929072631.437ffad9@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20210929073551.16dd2267@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210929073551.16dd2267@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> On Wed, Sep 29, 2021 at 07:35:51AM -0700, Jakub Kicinski wrote: > On Wed, 29 Sep 2021 17:31:04 +0300 Leon Romanovsky wrote: > > On Wed, Sep 29, 2021 at 07:26:31AM -0700, Jakub Kicinski wrote: > > > On Wed, 29 Sep 2021 17:16:28 +0300 Leon Romanovsky wrote: > > > > devlink_ops pointer is not constant at this stage, so why can't I copy > > > > reload_* pointers to the "main" devlink ops? > > > > > > > > I wanted to avoid to copy all pointers. > > > > > > Hm. I must be missing a key piece here. IIUC you want to have different > > > ops based on some device property. But there is only one > > > > > > static struct devlink_ops mlx5_devlink_ops; > > > > > > so how can two devlink instances in the system use that and have > > > different ops without a copy? > > > > No, I have two: > > * Base ops - mlx5_devlink_ops > > * Extra reload commands - mlx5_devlink_reload > > Still those are global for the driver, no? Ugh, yes > > What if you have multiple NICs or whatever. I missed it and always tested with one device L(. I'll add copy-all-ops code. Thanks From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leon Romanovsky Date: Wed, 29 Sep 2021 18:24:44 +0300 Subject: [Intel-wired-lan] [PATCH net-next v1 4/5] net/mlx5: Register separate reload devlink ops for multiport device In-Reply-To: <20210929073551.16dd2267@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> References: <20210929065549.43b13203@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20210929072631.437ffad9@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20210929073551.16dd2267@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On Wed, Sep 29, 2021 at 07:35:51AM -0700, Jakub Kicinski wrote: > On Wed, 29 Sep 2021 17:31:04 +0300 Leon Romanovsky wrote: > > On Wed, Sep 29, 2021 at 07:26:31AM -0700, Jakub Kicinski wrote: > > > On Wed, 29 Sep 2021 17:16:28 +0300 Leon Romanovsky wrote: > > > > devlink_ops pointer is not constant at this stage, so why can't I copy > > > > reload_* pointers to the "main" devlink ops? > > > > > > > > I wanted to avoid to copy all pointers. > > > > > > Hm. I must be missing a key piece here. IIUC you want to have different > > > ops based on some device property. But there is only one > > > > > > static struct devlink_ops mlx5_devlink_ops; > > > > > > so how can two devlink instances in the system use that and have > > > different ops without a copy? > > > > No, I have two: > > * Base ops - mlx5_devlink_ops > > * Extra reload commands - mlx5_devlink_reload > > Still those are global for the driver, no? Ugh, yes > > What if you have multiple NICs or whatever. I missed it and always tested with one device L(. I'll add copy-all-ops code. Thanks