All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: kernel test robot <lkp@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	kbuild-all@lists.01.org, Alexey Dobriyan <adobriyan@gmail.com>,
	Oleg Nesterov <oleg@redhat.com>, Andrey Vagin <avagin@gmail.com>,
	Dmitry Safonov <0x7f454c46@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [PATCH v2] prctl: PR_SET_MM - unify copying of user's auvx
Date: Wed, 29 Sep 2021 18:34:50 +0300	[thread overview]
Message-ID: <YVSHmu0Wtin/2pXN@grain> (raw)
In-Reply-To: <202109292307.smDkJddi-lkp@intel.com>

On Wed, Sep 29, 2021 at 11:20:23PM +0800, kernel test robot wrote:
...
> sparse warnings: (new ones prefixed by >>)
> >> kernel/sys.c:1997:58: sparse: sparse: incorrect type in argument 3 (different address spaces) @@     expected void const [noderef] __user *addr @@     got unsigned long long [usertype] *[addressable] auxv @@
>    kernel/sys.c:1997:58: sparse:     expected void const [noderef] __user *addr
>    kernel/sys.c:1997:58: sparse:     got unsigned long long [usertype] *[addressable] auxv
>    kernel/sys.c:1068:32: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected struct task_struct *p1 @@     got struct task_struct [noderef] __rcu *real_parent @@
>    kernel/sys.c:1068:32: sparse:     expected struct task_struct *p1
>    kernel/sys.c:1068:32: sparse:     got struct task_struct [noderef] __rcu *real_parent
>    kernel/sys.c: note: in included file (through include/linux/rcuwait.h, include/linux/percpu-rwsem.h, include/linux/fs.h, ...):
>    include/linux/sched/signal.h:710:37: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected struct spinlock [usertype] *lock @@     got struct spinlock [noderef] __rcu * @@
>    include/linux/sched/signal.h:710:37: sparse:     expected struct spinlock [usertype] *lock
>    include/linux/sched/signal.h:710:37: sparse:     got struct spinlock [noderef] __rcu *
> 
> vim +1997 kernel/sys.c

Thanks for report! I happen to miss Dima's reply in first place as well :(
I'll take a look on this patch. The issie itself is implicit type conversion,
shouldn't be a bug in general but need to address as well. Will do.

WARNING: multiple messages have this Message-ID (diff)
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v2] prctl: PR_SET_MM - unify copying of user's auvx
Date: Wed, 29 Sep 2021 18:34:50 +0300	[thread overview]
Message-ID: <YVSHmu0Wtin/2pXN@grain> (raw)
In-Reply-To: <202109292307.smDkJddi-lkp@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1664 bytes --]

On Wed, Sep 29, 2021 at 11:20:23PM +0800, kernel test robot wrote:
...
> sparse warnings: (new ones prefixed by >>)
> >> kernel/sys.c:1997:58: sparse: sparse: incorrect type in argument 3 (different address spaces) @@     expected void const [noderef] __user *addr @@     got unsigned long long [usertype] *[addressable] auxv @@
>    kernel/sys.c:1997:58: sparse:     expected void const [noderef] __user *addr
>    kernel/sys.c:1997:58: sparse:     got unsigned long long [usertype] *[addressable] auxv
>    kernel/sys.c:1068:32: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected struct task_struct *p1 @@     got struct task_struct [noderef] __rcu *real_parent @@
>    kernel/sys.c:1068:32: sparse:     expected struct task_struct *p1
>    kernel/sys.c:1068:32: sparse:     got struct task_struct [noderef] __rcu *real_parent
>    kernel/sys.c: note: in included file (through include/linux/rcuwait.h, include/linux/percpu-rwsem.h, include/linux/fs.h, ...):
>    include/linux/sched/signal.h:710:37: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected struct spinlock [usertype] *lock @@     got struct spinlock [noderef] __rcu * @@
>    include/linux/sched/signal.h:710:37: sparse:     expected struct spinlock [usertype] *lock
>    include/linux/sched/signal.h:710:37: sparse:     got struct spinlock [noderef] __rcu *
> 
> vim +1997 kernel/sys.c

Thanks for report! I happen to miss Dima's reply in first place as well :(
I'll take a look on this patch. The issie itself is implicit type conversion,
shouldn't be a bug in general but need to address as well. Will do.

  reply	other threads:[~2021-09-29 15:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-21 20:36 [PATCH] prctl: fix overwrite last but one entry in auxv vector Cyrill Gorcunov
2021-03-22  6:42 ` Cyrill Gorcunov
2021-03-23 22:06 ` [PATCH v2] prctl: PR_SET_MM - unify copying of user's auvx Cyrill Gorcunov
2021-03-26  0:24   ` Dmitry Safonov
2021-09-29 15:20   ` kernel test robot
2021-09-29 15:20     ` kernel test robot
2021-09-29 15:34     ` Cyrill Gorcunov [this message]
2021-09-29 15:34       ` Cyrill Gorcunov
2021-11-12 17:21   ` kernel test robot
2021-11-12 17:21     ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YVSHmu0Wtin/2pXN@grain \
    --to=gorcunov@gmail.com \
    --cc=0x7f454c46@gmail.com \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=avagin@gmail.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lkp@intel.com \
    --cc=oleg@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.