From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: LakshmiPraveen Kopparthi <LakshmiPraveen.Kopparthi@microchip.com>,
wsa@kernel.org, treding@nvidia.com, mirq-linux@rere.qmqm.pl,
s.shtylyov@omp.ru, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com
Subject: Re: [PATCH v1 1/2] i2c:busses:Register PCI1XXXX adapter to I2C subsystem
Date: Wed, 29 Sep 2021 19:44:37 +0300 [thread overview]
Message-ID: <YVSX9ZE5hJpYNgN5@smile.fi.intel.com> (raw)
In-Reply-To: <d39e99ff-6498-e532-e833-1c65861d566f@gmail.com>
On Wed, Sep 29, 2021 at 10:18:46AM +0300, Dmitry Osipenko wrote:
> 29.09.2021 09:22, LakshmiPraveen Kopparthi пишет:
...
> return intr_handled ? IRQ_HANDLED : IRQ_NONE;
> Or turn intr_handled into "irqreturn_t ret" and return it directly.
Or
return IRQ_RETVAL(...);
...
> > +static const struct pci_device_id pci1xxxx_i2c_pci_id_table[] = {
> > + { PCI_DEVICE(PCI_VENDOR_ID_MICROCHIP, PCI12000_I2C_PID) },
> > + { PCI_DEVICE(PCI_VENDOR_ID_MICROCHIP, PCI11010_I2C_PID) },
> > + { PCI_DEVICE(PCI_VENDOR_ID_MICROCHIP, PCI11101_I2C_PID) },
> > + { PCI_DEVICE(PCI_VENDOR_ID_MICROCHIP, PCI11400_I2C_PID) },
> > + { PCI_DEVICE(PCI_VENDOR_ID_MICROCHIP, PCI11414_I2C_PID) },
If you switch to PCI_VDEVIDE, you will see how you may improve the device ID
definitions.
> > + {0, }
Redundant content inside curly braces.
> > +};
> > +
Redundant blank line.
> > +MODULE_DEVICE_TABLE(pci, pci1xxxx_i2c_pci_id_table);
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-09-29 16:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 6:22 [PATCH v1 0/2] i2c:busses:Microchip PCI1XXXX I2C adapter LakshmiPraveen Kopparthi
2021-09-29 6:22 ` [PATCH v1 1/2] i2c:busses:Register PCI1XXXX adapter to I2C subsystem LakshmiPraveen Kopparthi
2021-09-29 7:18 ` Dmitry Osipenko
2021-09-29 14:35 ` Dmitry Osipenko
2021-10-05 8:49 ` LakshmiPraveen Kopparthi
2021-09-29 16:44 ` Andy Shevchenko [this message]
2021-10-05 8:49 ` LakshmiPraveen Kopparthi
2021-10-05 8:50 ` LakshmiPraveen Kopparthi
2021-10-07 16:24 ` Dmitry Osipenko
2021-10-07 16:33 ` Andy Shevchenko
2021-10-07 16:30 ` Dmitry Osipenko
2021-09-29 17:12 ` Michał Mirosław
2021-10-08 6:22 ` LakshmiPraveen Kopparthi
2021-10-07 16:40 ` Dmitry Osipenko
2021-10-07 17:05 ` Andy Shevchenko
2021-09-29 6:22 ` [PATCH v1 2/2] i2c:busses:Read and Write routines for PCI1XXXX I2C module LakshmiPraveen Kopparthi
2021-09-29 7:20 ` Dmitry Osipenko
2021-10-05 8:48 ` LakshmiPraveen Kopparthi
2021-10-07 16:15 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVSX9ZE5hJpYNgN5@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=LakshmiPraveen.Kopparthi@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=digetx@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=s.shtylyov@omp.ru \
--cc=treding@nvidia.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.